1168612 - prevent mach automation from uploading in taskcluster

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

I just saw:

21:18:58     INFO -  CHECKSUM FILE END
21:18:58     INFO -  /home/worker/workspace/build/src/obj-firefox/_virtualenv/bin/python /home/worker/workspace/build/src/build/upload.py --base-path ../../../dist \
21:18:58     INFO -  		'../../../dist/fennec-41.0a1.en-US.android-arm.apk'     '../../../dist/fennec-41.0a1.en-US.android-arm.tests.zip' '../../../dist/fennec-41.0a1.en-US.android-arm.crashreporter-symbols.zip'  '../../../dist//fennec-41.0a1.en-US.android-arm.txt' '../../../dist//fennec-41.0a1.en-US.android-arm.json' '../../../dist//fennec-41.0a1.en-US.android-arm.mozinfo.json' '../../../dist//test_packages.json' '../../../dist/jsshell-android-arm.zip'   ../../../dist/gecko-unsigned-unaligned.apk  ../../../dist/robocop.apk  ../../../dist/fennec_ids.txt  ../../../dist/geckoview_library/geckoview_library.zip  ../../../dist/geckoview_library/geckoview_assets.zip  ../../../dist/../embedding/android/geckoview_example/geckoview_example.apk  ../../../dist/geckolibs-20150526204837.aar  ../../../dist/geckolibs-20150526204837.aar.sha1  ../../../dist/geckolibs-20150526204837.pom  ../../../dist/geckolibs-20150526204837.pom.sha1  ../../../dist/ivy-geckolibs-20150526204837.xml  ../../../dist/ivy-geckolibs-20150526204837.xml.sha1  ../../../dist/geckoview-20150526204837.aar  ../../../dist/geckoview-20150526204837.aar.sha1  ../../../dist/geckoview-20150526204837.pom  ../../../dist/geckoview-20150526204837.pom.sha1  ../../../dist/ivy-geckoview-20150526204837.xml  ../../../dist/ivy-geckoview-20150526204837.xml.sha1  ../../../dist/host/bin/mar  ../../../dist/host/bin/mbsdiff \
21:18:58     INFO -  		'../../../dist//fennec-41.0a1.en-US.android-arm.checksums'
21:58:58     INFO - Automation Error: mozprocess timed out after 2400 seconds running ['python2.7', 'mach', '--log-no-times', 'build', '-v']

because the 'upload' mach automation step is running.  I tried removing the upload hostname in bug 1166380 but that crashed due to some hard-coded substituations in c['env'] in a bunch of scripts, and anyway would just have made the upload fail instead of hanging.

It's a bit of a bummer there's no log output here, by the way.

I think the fix is to set the relevant MOZ_AUTOMATION flag in the build shell script; that will pass through mozharness and mach to the mozconfig script, which will not change the existing value.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=35a1f9246a0c

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=912ee0d8377d

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

OK, still not succeeding though, I think because of 

14:52:44  WARNING - Skipping S3 file upload: No taskcluster credentials.
14:52:44    ERROR - could not determine packageUrl property to use against sendchange. Was it set after 'mach build'?
14:52:44    ERROR - could not determine packageUrl property to use against sendchange. Was it set after 'mach build'?
14:52:44  WARNING - signing disabled because MOZ_SIGNING_SERVERS is not set

also, on error we're not uploading artifacts, which is kinda lame.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

I disabled sendchanges using morgan's `configs/disable_sendchanges.py`.  I'm going to work on moving all of the `_postflight_build` stuff into its own actions, though, so that we can just disable these in the task's build.sh with --no-upload, etc.

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5017a1787090

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

With the new actions in a pinned mozharness version

remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e0454785bef

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Try that again

https://treeherder.mozilla.org/#/jobs?repo=try&revision=086eae8ddef3

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

Woo

22:11:03     INFO - #####
22:11:03     INFO - ##### Skipping upload-files step.
22:11:03     INFO - #####
22:11:03     INFO - #####
22:11:03     INFO - ##### Skipping sendchange step.
22:11:03     INFO - #####

I added a little bit more to also try to disable signing (via mozharness config files)

remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=bcb8adf9f6ac

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

23:12:33     INFO - # TBPL SUCCESS #
23:12:33     INFO - #####
23:12:33     INFO - ##### FxDesktopBuild summary:
23:12:33     INFO - #####
23:12:33     INFO - # TBPL SUCCESS #
23:12:33     INFO - Copying logs to upload dir...
23:12:33     INFO - mkdir: /home/worker/workspace/build/upload/logs
23:12:33    DEBUG - Copying /home/worker/logs/localconfig.json to /home/worker/workspace/build/upload/logs/localconfig.json
23:12:33    DEBUG - mkdir_p: /home/worker/workspace/build/upload/logs Already exists.
23:12:33    DEBUG - Copying /home/worker/logs/log_info.log to /home/worker/workspace/build/upload/logs/log_info.log
23:12:33    DEBUG - mkdir_p: /home/worker/workspace/build/upload/logs Already exists.
23:12:33    DEBUG - Copying /home/worker/logs/log_raw.log to /home/worker/workspace/build/upload/logs/log_raw.log
23:12:33    DEBUG - mkdir_p: /home/worker/workspace/build/upload/logs Already exists.
23:12:33    DEBUG - Copying /home/worker/logs/log_warning.log to /home/worker/workspace/build/upload/logs/log_warning.log
23:12:33    DEBUG - mkdir_p: /home/worker/workspace/build/upload/logs Already exists.
23:12:33    DEBUG - Copying /home/worker/logs/log_critical.log to /home/worker/workspace/build/upload/logs/log_critical.log
23:12:33    DEBUG - mkdir_p: /home/worker/workspace/build/upload/logs Already exists.
23:12:33    DEBUG - Copying /home/worker/logs/log_error.log to /home/worker/workspace/build/upload/logs/log_error.log
23:12:33    DEBUG - mkdir_p: /home/worker/workspace/build/upload/logs Already exists.
23:12:33    DEBUG - Copying /home/worker/logs/log_debug.log to /home/worker/workspace/build/upload/logs/log_debug.log
23:12:33    DEBUG - mkdir_p: /home/worker/workspace/build/upload/logs Already exists.
23:12:33    DEBUG - Copying /home/worker/logs/log_fatal.log to /home/worker/workspace/build/upload/logs/log_fatal.log
cleanup
+ cleanup
+ '[' -n '' ']'
[taskcluster] Artifact "public/build" not found at path
"/home/worker/artifacts/" skipping.
[taskcluster] Unsuccessful task run with exit code: 1 completed in 1891.399
seconds

I'm really not sure why the exit code is 1, but at least it says TBPL SUCCESS.

Comment 10

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug1168612-mozharness.patch

Comment 11

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: MozReview Request: Bug 1168612: set MOZ_AUTOMATION_UPLOAD=0 in taskcluster; r=mrrrgn

Bug 1168612: set MOZ_AUTOMATION_UPLOAD=0 in taskcluster; r=mrrrgn

Comment 12

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: MozReview Request: Bug 1168612: link uploads to artifacts so that we get logs even on failure; r=mrrrgn

Bug 1168612: link uploads to artifacts so that we get logs even on failure; r=mrrrgn

Comment 13

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: MozReview Request: Bug 1168612: remove CCACHE variables from build.sh, as mozharness overrides them; r=mrrrgn

Bug 1168612: remove CCACHE variables from build.sh, as mozharness overrides them; r=mrrrgn

Comment 14

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: MozReview Request: Bug 1168612: disable sendchanges from taskcluster; r=mrrrgn

Bug 1168612: disable sendchanges from taskcluster; r=mrrrgn

Comment 15

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: MozReview Request: Bug 1168612: disable signing and platform_supports_post_upload_to_latest via mozharness configuration files; r=mrrrgn

Bug 1168612: disable signing and platform_supports_post_upload_to_latest via mozharness configuration files; r=mrrrgn

Comment 16

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: MozReview Request: Bug 1168612: update comment on unused oauth.txt; r=mrrrgn

Bug 1168612: remove unused oauth.txt; r=mrrrgn

Comment 17

[Morgan Phillips [:mrrrgn]]

Comment on attachment 8612898 [details]
MozReview Request: Bug 1168612: link uploads to artifacts so that we get logs even on failure; r=mrrrgn

:+1

Comment 18

[Morgan Phillips [:mrrrgn]]

Comment on attachment 8612897 [details]
MozReview Request: Bug 1168612: set MOZ_AUTOMATION_UPLOAD=0 in taskcluster; r=mrrrgn

https://reviewboard.mozilla.org/r/9651/#review8413

Ship It!

Comment 19

[Morgan Phillips [:mrrrgn]]

https://reviewboard.mozilla.org/r/9651/#review8415

Comment 20

[Morgan Phillips [:mrrrgn]]

https://reviewboard.mozilla.org/r/9651/#review8417

Comment 21

[Morgan Phillips [:mrrrgn]]

Comment on attachment 8612902 [details]
MozReview Request: Bug 1168612: update comment on unused oauth.txt; r=mrrrgn

I'm going to run my jobs without an oauth.txt to make sure this doesn't fail them....

Comment 22

[Morgan Phillips [:mrrrgn]]

Comment on attachment 8612900 [details]
MozReview Request: Bug 1168612: disable sendchanges from taskcluster; r=mrrrgn

https://reviewboard.mozilla.org/r/9657/#review8419

Comment 23

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8612894 [details] [diff] [review]
bug1168612-mozharness.patch

I'm running against this patch with a full-build try:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ed6bb6fd991

Comment 24

[Dustin J. Mitchell [:dustin] (he/him)]

https://reviewboard.mozilla.org/r/9661/#review8433

I updated this commit to just change the comments

Comment 25

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8612902 [details]
MozReview Request: Bug 1168612: update comment on unused oauth.txt; r=mrrrgn

Bug 1168612: update comment on unused oauth.txt; r=mrrrgn

Comment 26

[Dustin J. Mitchell [:dustin] (he/him)]

https://reviewboard.mozilla.org/r/9653/#review8443

Updated to use the correct path (`$WORKSPACE/build/upload` instead of `$HOME/build/upload`)

Comment 27

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8612898 [details]
MozReview Request: Bug 1168612: link uploads to artifacts so that we get logs even on failure; r=mrrrgn

Bug 1168612: link uploads to artifacts so that we get logs even on failure; r=mrrrgn

Comment 28

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8612899 [details]
MozReview Request: Bug 1168612: remove CCACHE variables from build.sh, as mozharness overrides them; r=mrrrgn

Bug 1168612: remove CCACHE variables from build.sh, as mozharness overrides them; r=mrrrgn

Comment 29

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8612900 [details]
MozReview Request: Bug 1168612: disable sendchanges from taskcluster; r=mrrrgn

Bug 1168612: disable sendchanges from taskcluster; r=mrrrgn

Comment 30

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8612901 [details]
MozReview Request: Bug 1168612: disable signing and platform_supports_post_upload_to_latest via mozharness configuration files; r=mrrrgn

Bug 1168612: disable signing and platform_supports_post_upload_to_latest via mozharness configuration files; r=mrrrgn

Comment 31

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8612902 [details]
MozReview Request: Bug 1168612: update comment on unused oauth.txt; r=mrrrgn

Bug 1168612: update comment on unused oauth.txt; r=mrrrgn

Comment 32

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: MozReview Request: Bug 1168612: don't spoil the exit status with a trap function; r=mrrrgn

Bug 1168612: don't spoil the exit status with a trap function; r=mrrrgn

Comment 33

[Dustin J. Mitchell [:dustin] (he/him)]

Ugh, sorry, I was hoping mozreview wouldn't flag all of the unchanged commits as r?.  I manually carried forward three r+'s -- the other r?'s are legit.

Comment 34

[Morgan Phillips [:mrrrgn]]

Comment on attachment 8612898 [details]
MozReview Request: Bug 1168612: link uploads to artifacts so that we get logs even on failure; r=mrrrgn

C'est logique.

Comment 35

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: MozReview Request: Bug 1168612: move upload-files, sendchange, and check-test to independent actions; r=jlund

Bug 1168612: move upload-files, sendchange, and check-test to independent actions; r=jlund

Comment 36

[Morgan Phillips [:mrrrgn]]

Comment on attachment 8612902 [details]
MozReview Request: Bug 1168612: update comment on unused oauth.txt; r=mrrrgn

This breaks builds. See this task, which completes successfully until oauth is removed: https://tools.taskcluster.net/task-inspector/#lpw5-FFUTtOQBvt8pv2-vA/0 

We'll need to modify mozharness, or make a custom config instead.

Comment 37

[Morgan Phillips [:mrrrgn]]

Comment on attachment 8612902 [details]
MozReview Request: Bug 1168612: update comment on unused oauth.txt; r=mrrrgn

https://reviewboard.mozilla.org/r/9661/#review8463

Ship It!

Comment 38

[Dustin J. Mitchell [:dustin] (he/him)]

Regarding "don't spoil the exit status with a trap function":
  [taskcluster] Successful task run with exit code: 0 completed in 1857.481

Comment 39

[Jordan Lund (:jlund)]

https://reviewboard.mozilla.org/r/9693/#review8493

nice. I think it's better than these are ripped out and made into their own actions. I've added some comments below that we'll need to discuss before I'll r+

::: mozharness/mozilla/building/buildbase.py:1679
(Diff revision 1)
> +        if not self.config.get('enable_check_test'):

if we are moving this step outside of build and into its own action, we should be able to remove the 'enable_check_test' config item.

Instead, we just define the 'check-test' action to be run in the respective config files that have enable_check_test==True

::: scripts/fx_desktop_build.py:38
(Diff revision 1)
> +                'check-test',

adding these actions here tells mozharness that this script is capable of running these three. To actually avail of them, we will need to add them where we want in each platform+variant config file:

http://mxr.mozilla.org/build/search?string=default_actions&find=mozharness%2Fconfigs%2Fbuilds&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=build

Comment 40

[Jordan Lund (:jlund)]

Comment on attachment 8612990 [details]
MozReview Request: Bug 1168612: move upload-files, sendchange, and check-test to independent actions; r=jlund

clearing my queue. r- mainly because I believe we will need to tell the configs to use the new actions.

Comment 41

[Dustin J. Mitchell [:dustin] (he/him)]

https://reviewboard.mozilla.org/r/9693/#review8541

> adding these actions here tells mozharness that this script is capable of running these three. To actually avail of them, we will need to add them where we want in each platform+variant config file:
> 
> http://mxr.mozilla.org/build/search?string=default_actions&find=mozharness%2Fconfigs%2Fbuilds&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=build

Ah, good point.  So I'll add `upload-files`, `sendchange`, and `check-test` everywhere I see `build` that looks like it's using buildbase (and not buildb2gbase)

Comment 42

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: MozReview Request: Bug 1168612: add new actions to all buildbase-based configs; r=jlund

Bug 1168612: add new actions to all buildbase-based configs; r=jlund

Comment 43

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: MozReview Request: Bug 1168612: remove `check-test` action where enable_check_test=False; r=jlund

Bug 1168612: remove `check-test` action where enable_check_test=False; r=jlund

Comment 44

[Dustin J. Mitchell [:dustin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=146071751b1e

Comment 45

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8612990 [details]
MozReview Request: Bug 1168612: move upload-files, sendchange, and check-test to independent actions; r=jlund

Comments addressed in subsequent patches

Comment 46

[Jordan Lund (:jlund)]

Comment on attachment 8613493 [details]
MozReview Request: Bug 1168612: add new actions to all buildbase-based configs; r=jlund

https://reviewboard.mozilla.org/r/9751/#review8623

pretty much looks good. I see some failures[1]. IIUC the configs/b2g/releng-* configs are used with b2g_build.py and is independant from BuildScript. For example, b2g/releng-emulator.py[2]

So we will need to remove those and then I think we are good to ship it.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=146071751b1e&filter-resultStatus=busted
[2] http://mxr.mozilla.org/build/source/buildbot-configs/mozilla/b2g_config.py#701

Comment 47

[Dustin J. Mitchell [:dustin] (he/him)]

Ah, I thought the `releng-` indicated it was ours :)

Comment 48

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8613493 [details]
MozReview Request: Bug 1168612: add new actions to all buildbase-based configs; r=jlund

Bug 1168612: add new actions to all buildbase-based configs; r=jlund

Comment 49

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8613494 [details]
MozReview Request: Bug 1168612: remove `check-test` action where enable_check_test=False; r=jlund

Bug 1168612: remove `check-test` action where enable_check_test=False; r=jlund

Comment 50

[Dustin J. Mitchell [:dustin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=91220226ad20

Comment 51

[Jordan Lund (:jlund)]

(In reply to Dustin J. Mitchell [:dustin] from comment #47)
> Ah, I thought the `releng-` indicated it was ours :)

they are. but they just use a different script with it's own set of actions because b2g device builds are 'built' very differently than ff.

Comment 52

[Dustin J. Mitchell [:dustin] (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=59a7055861e3

Comment 53

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8613493 [details]
MozReview Request: Bug 1168612: add new actions to all buildbase-based configs; r=jlund

Bug 1168612: add new actions to all buildbase-based configs; r=jlund

Comment 54

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8613494 [details]
MozReview Request: Bug 1168612: remove `check-test` action where enable_check_test=False; r=jlund

Bug 1168612: remove `check-test` action where enable_check_test=False; r=jlund

Comment 55

[Dustin J. Mitchell [:dustin] (he/him)]

That try run was green (well, Windows isn't done, but I'm confident)

Comment 56

[Jordan Lund (:jlund)]

Comment on attachment 8612990 [details]
MozReview Request: Bug 1168612: move upload-files, sendchange, and check-test to independent actions; r=jlund

https://reviewboard.mozilla.org/r/9695/#review8745

Ship It!

Comment 57

[Jordan Lund (:jlund)]

Comment on attachment 8613493 [details]
MozReview Request: Bug 1168612: add new actions to all buildbase-based configs; r=jlund

https://reviewboard.mozilla.org/r/9751/#review8747

Ship It!

Comment 58

[Jordan Lund (:jlund)]

Comment on attachment 8613494 [details]
MozReview Request: Bug 1168612: remove `check-test` action where enable_check_test=False; r=jlund

https://reviewboard.mozilla.org/r/9753/#review8749

Ship It!

Comment 59

[Jordan Lund (:jlund)]

(In reply to Dustin J. Mitchell [:dustin] from comment #55)
> That try run was green (well, Windows isn't done, but I'm confident)

lgtm :)

Comment 60

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b3986709cdde
https://hg.mozilla.org/integration/mozilla-inbound/rev/a449c95c4ea3
https://hg.mozilla.org/integration/mozilla-inbound/rev/cafeb76b7317
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f7f87515ebb
https://hg.mozilla.org/integration/mozilla-inbound/rev/479de45e9179

Comment 61

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bedbb4638d28
https://hg.mozilla.org/integration/mozilla-inbound/rev/6256ee8a3344

Comment 62

[Pulsebot]

https://hg.mozilla.org/mozilla-central/rev/83367fdf47b1

Comment 63

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b3986709cdde
https://hg.mozilla.org/mozilla-central/rev/a449c95c4ea3
https://hg.mozilla.org/mozilla-central/rev/cafeb76b7317
https://hg.mozilla.org/mozilla-central/rev/8f7f87515ebb
https://hg.mozilla.org/mozilla-central/rev/479de45e9179
https://hg.mozilla.org/mozilla-central/rev/bedbb4638d28
https://hg.mozilla.org/mozilla-central/rev/6256ee8a3344

Comment 64

[Jordan Lund (:jlund)]

Attachment: 150617_remove_check_test_config_item.patch

08:49 <chmanchester> jlund: it looks like we turned off make check, how often are we intending to run it?
08:50 <chmanchester> jlund: my recent try builds have "12:44:55     INFO - 'enable_check_test' is false; skipping"
08:50 <jlund> which platform(s)?
08:50 <chmanchester> same on trunk trees
08:53 <chmanchester> I think https://bugzilla.mozilla.org/show_bug.cgi?id=1168612 turned them off inadvertently
08:54 <chmanchester> with http://hg.mozilla.org/build/mozharness/rev/341cc9614896
08:57 <jlund> chmanchester: yes, looks like you're right
08:57 <jlund> dustin: ^ looks like when we moved build steps into their own mozharness action we forgot to remove this part: http://mxr.mozilla.org/build/source/mozharness/mozharness/mozilla/building/buildbase.py#1716
09:00 <dustin> oh, that patch removed enable_check_tests, but didn't remove the check for it?
09:00 <dustin> indeed

Comment 65

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8623737 [details] [diff] [review]
150617_remove_check_test_config_item.patch

Review of attachment 8623737 [details] [diff] [review]:
-----------------------------------------------------------------

__  _
       .-.'  `; `-._  __  _
      (_,         .-:'  `; `-._
    ,'o"(        (_,           )
   (__,-'      ,'o"(            )>
      (       (__,-'            )
       `-'._.--._(             )
          |||  |||`-'._.--._.-'
                     |||  |||

Comment 66

[Jordan Lund (:jlund)]

Comment on attachment 8623737 [details] [diff] [review]
150617_remove_check_test_config_item.patch

remote:   https://hg.mozilla.org/build/mozharness/rev/776dda3defa1

Comment 67

[Chris Manchester (limited bugmail, email directly)]

Try to see is this is safe to land: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8589ff914781

Comment 68

[Jordan Lund (:jlund)]

Attachment: 150617_disable_check_test_for_android.patch

I'd like to blame missing this on account of my mozreview noobness but I shouldn't. /me fails

context: https://bugzil.la/1175762

Comment 69

[Jordan Lund (:jlund)]

Comment on attachment 8624004 [details] [diff] [review]
150617_disable_check_test_for_android.patch

remote:   https://hg.mozilla.org/build/mozharness/rev/707a511a48e2

Comment 70

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1168612 - Temporarily disable TestMP4Reader.cpp so we can re-enable the rest of make check. r=jlund

Bug 1168612 - Temporarily disable TestMP4Reader.cpp so we can re-enable the rest of make check. r=jlund

Comment 71

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1168612 - Bump mozharness to get check tests back. r=jlund

Bug 1168612 - Bump mozharness to get check tests back. r=jlund

Comment 72

[Jordan Lund (:jlund)]

Comment on attachment 8624332 [details]
MozReview Request: Bug 1168612 - Temporarily disable TestMP4Reader.cpp so we can re-enable the rest of make check. r=jlund

https://reviewboard.mozilla.org/r/11669/#review10127

Ship It!

Comment 73

[Jordan Lund (:jlund)]

Comment on attachment 8624333 [details]
MozReview Request: Bug 1168612 - Bump mozharness to get check tests back. r=jlund

https://reviewboard.mozilla.org/r/11671/#review10129

Ship It!

Comment 74

[Pulsebot]

https://hg.mozilla.org/mozilla-central/rev/cdb870a85553
https://hg.mozilla.org/mozilla-central/rev/c9a79ec16280