117505 - Save file dialog (download) has paint issue with pause/resume button [ftp downloads]

Status: RESOLVED INCOMPLETE

(Core :: XUL, defect, P4)

Description

[Devoti Paolo]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.7+) Gecko/20011229
BuildID:    2001122908



Reproducible: Sometimes
Steps to Reproduce:
1.open url
2.doubleclick file to downdload eg:mozilla-win32-talkback.zip
3.download starts

Actual Results:  download works but a button has an odd frame around

Expected Results:  no odd frame

it happens always to the same button (see picture)

Comment 1

[Devoti Paolo]

Attachment: dialog screen shot

Comment 2

[Martin Poirier]

I also see this Win98SE moz trunk build 20011230, only around the pause button. 
It doesn't occur when there is no pause button.

Comment 3

[Boris Zbarsky [:bzbarsky]]

To File handling.

Comment 4

[Mike Schuette]

Do you have an ATI video card?  (or Matrox?)

Check out Bug #104992 and related.

Comment 5

[Devoti Paolo]

It's a voodoo 3 2000

Comment 6

[Martin Poirier]

Voodoo 3 3000 for me, but with voodoo 5 driver

Comment 7

[sairuh (rarely reading bugmail)]

also see this on linux.

bill, ben, any ideas why this is happening?

Comment 8

[sairuh (rarely reading bugmail)]

*** Bug 118982 has been marked as a duplicate of this bug. ***

Comment 9

[Martin Poirier]

I also see this with a Geforce 2 MX, so it`s not only ATI or Voodoo cards

Comment 10

[xyzzy]

*** Bug 119925 has been marked as a duplicate of this bug. ***

Comment 11

[Bill Law]

setting bug attributes to reflect minor cosmetic flaw

Comment 12

[[not reading bugmail]]

I have a GF2 MX and I dont see a problem with w2k.

but, I do see this on SIS630 chipset with integrated video using win98. (non SE)

Comment 13

[Mauricio Collares [:collares]]

*** Bug 121337 has been marked as a duplicate of this bug. ***

Comment 14

[Mauricio Collares [:collares]]

*** Bug 125002 has been marked as a duplicate of this bug. ***

Comment 15

[Bill Law]

I see the same thing in my new progress window (see bug 27609).

It seems to occur when you have a <button> in a <deck>.

I'm going to reset the component.

There may be some clever xul that will avoid the problem, but I don't know what
it is.

Comment 16

[John Morrison]

Looked at this for a while with DOM Inspector, and something's just going 
wrong with the painting of -moz-border-*-colors when inside that deck.

Comment 17

[Patty Mac]

I see the same problem with the "Pause" button in the saving file dialog (linux:
commercial netsape build: 2002-02-12-08-trunk)

Comment 18

[sairuh (rarely reading bugmail)]

*** Bug 125648 has been marked as a duplicate of this bug. ***

Comment 19

[Peter Trudelle]

nsbeta1+ per Nav triage team

Comment 20

[Peter Trudelle]

Mass move of nsbeta1+ bugs that didn't have a valid MachV milestone to mozilla1.0.

Comment 21

[R.K.Aa.]

Attachment: adding to the jungle of screenshots..

on a current CVS, linux - there initially seems to be TWO buttons there?
One of top of the other: See screenshot. After the window has been covered up,
the area outside the "real button" turns into a multicolored, mostly black,
sqare.

Comment 22

[Jeremy M. Dolan]

I'm seeing some other odd behavior with this button. When you click down on
pause or resume, and then drag off, the button doesn't pop back out. You can't
cancel the action, like you can on the cancel button. Should I file a seperate
bug? I have a feeling the two problems are related.

Comment 23

[Daniel Bratell]

For me (CVS build, Windows 2000) the are around the Pause button is all black. 
Like there is missing content.

Comment 24

[WD]

*** Bug 129588 has been marked as a duplicate of this bug. ***

Comment 25

[Peter Trudelle]

->hewitt

Comment 26

[Blake Ross]

This will be much easier to workaround than to fix.  The buttons don't have to
be in a deck, we could just use two different buttons and hide/show them when
necessary, or use the same button and change its label (and the action when
clickin it).

Comment 27

[Blake Ross]

Attachment: patch/workaround

Comment 28

[Blake Ross]

-> me

Comment 29

[Joe Hewitt (gone)]

Comment on attachment 74682 [details] [diff] [review]
patch/workaround

sr=hewitt

Comment 30

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 74682 [details] [diff] [review]
patch/workaround

a=dbaron for trunk checkin.  Please make sure there's still a bug open on the
underlying toolkit problem (whether it's this one or another one that you
file).

Comment 31

[Blake Ross]

Fixed. Filed bug 131653 for general problem.

Comment 32

[jag (Peter Annema)]

There's a bug somewhere which has a patch that's pretty much the reverse of this
one. The problem we tried to solve with the <deck> is that when you go from
"pause" to "resume" you end up pushing the last button slightly out of view (on
Mac, if I recall correctly). Maybe that's not the case anymore with the new
progress dialog, but can someone verify this?

Comment 33

[Bill Law]

I'm reopening this.

I think Jag is right about the "Resume" button being a tad wider and that 
causing some grief.

I think the <deck> was the means of solving that problem, and, the problem of 
hiding the button while still allocating space for it.  Note that the first 
child of the <deck> was a <spacer/> which was selected by default.  This meant 
that no button appeared unless we went through the ftp: case and selected 
either Pause or Resume.

Blake's patch makes the button visible for non-ftp: cases.  It should not be 
visible in such cases.

Comment 34

[Blake Ross]

Attachment: patch to fix visibility issue

Comment 35

[Blake Ross]

so are we going to get this patch in and deal with the slightly oversized dialog
or are we going to try to fix all the deck problems?

Comment 36

[Bill Law]

See http://www.nizkor.org/features/fallacies/false-dilemma.html

We only need to fix (or find a workaround) for *one* <deck> bug.  Probably if we
replaced the original <spacer/> with some other empty space tag, the original
painting bug would be fixed.

But hiding it (in the case of non-ftp locations) is definitely an improvement
over the way it works currently.

Comment 37

[Blake Ross]

A deck bug is usually hard to fix, especially now that evaughan is gone.  And 
no, there is more than one deck problem here. Note that, unlike with every other 
button, you can't cancel the click of the Pause/Resume button by mousing down 
and moving the cursor outside of the button, then releasing.  If this bug (a 
mere painting problem) is plussed, then I'm not sure I understand why that one 
(a functional bug) wouldn't be.

Comment 38

[Bill Law]

OK, then lets go with what we've got, with one minor improvement: change the
default button text to "Resume" (which may require a slight code tweak but
hopefully not).  That will ensure that the button is big enough, at least for en-US.

Would it be too tricky to add another entity for &longerOfPauseAndResume; and
instruct translators to set that to the longer of their "Pause" or "Resume"?

Comment 39

[Blake Ross]

I notice earlier you said you were surprised that http pause/resume actually
seemed to be working.  bbaetz also told me he thinks it works for http...

Comment 40

[Vadim Berezniker]

*** Bug 135662 has been marked as a duplicate of this bug. ***

Comment 41

[Vadim Berezniker]

*** Bug 136707 has been marked as a duplicate of this bug. ***

Comment 42

[Peter Trudelle]

Mass moving nsbeta1+/adt3 bugs assigned to Navigator team engineers out to
target milestone 1.0.1.  Please confine your attentions to driving down our list
of TM 1.0 bugs for beta.  Better to help, debug, or test one of them than fix
one of these.

Comment 43

[scottputterman]

Changing nsbeta1+ [adt3] bugs to nsbeta1- on behalf of the adt.  If you have any
questions about this, please email [e-mail].  You can search for
"changing adt3 bugs" to quickly find and delete these bug mails.

Comment 44

[scottputterman]

Changing nsbeta1+ [adt3] bugs to nsbeta1- on behalf of the adt.  If you have any
questions about this, please email [e-mail].  You can search for
"changing adt3 bugs" to quickly find and delete these bug mails.

Comment 45

[John Levon]

*** Bug 140545 has been marked as a duplicate of this bug. ***

Comment 46

[[e-mail]]

*** Bug 128359 has been marked as a duplicate of this bug. ***

Comment 47

[[e-mail]]

Comment on attachment 75078 [details] [diff] [review]
patch to fix visibility issue

Unnecessary now that that pause/resume button is always visible. Is there still
a potential problem with the labels, though?

Comment 48

[Devoti Paolo]

Attachment: dialog screen shot

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a5) Gecko/20041018 06
Still real but clicking the link a second time provides the window properly
resized to fit the buttons.

Comment 49

[OstGote!]

(In reply to comment #48)
> Created an attachment (id=162836) [details]
> dialog screen shot
> 
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a5) Gecko/20041018 06
> Still real but clicking the link a second time provides the window properly
> resized to fit the buttons.

That is Bug 280909.