Closed
Bug 11818
Opened 25 years ago
Closed 25 years ago
[DOGFOOD] {css3} need name for XUL virtual command key
Categories
(Core :: XUL, defect, P1)
Tracking
()
VERIFIED
FIXED
M12
People
(Reporter: akkzilla, Assigned: akkzilla)
References
Details
(Keywords: css3, Whiteboard: [PDT+])
XUL key bindings have the concept of a "virtual command key", so that a XUL file can specify a modifier key which will correspond to the command key on macs and the control key on other platforms. But this is currently called command, which is confusing to everyone since it doesn't really mean the command key. If there's going to be a virtual key it should be named something that doesn't correspond to an actual key. Ideally, this key should be changeable in the xul, so that Unix users can choose to use the Unix modifier key (alt) or the Windows modifier key (control) by changing one line instead of having to change every single key binding.
Updated•25 years ago
|
Status: NEW → ASSIGNED
Target Milestone: M10
Comment 1•25 years ago
|
||
Let the name voting begin. I'm voting for "shortcut". As for where to redefine it... maybe as an attribute of the keyset tag?
Assignee | ||
Comment 2•25 years ago
|
||
I still like "moz", but "shortcut" would be okay too. It would be ideal if we could define the modifier key sepately from a keyset. E.g. Kathy has <keyset id="defaultKeySet">; it would really rock if there were some way a user could say "use defaultKeySet, only use alt as the shortcut key". For instance, maybe after we've already read in all of <keyset id="defaultKeySet">, we might read in the user's own key binding file which might say something like <keyset modify id="defaultKeySet" shortcut="alt"> which would change all the bindings in defaultKeySet to use a different shortcut key. Or, if it's easier to implement, do it globally (not applied to a particular keyset id): <keyset shortcut="alt"> which would apply to every keyset read in in this session.
Comment 3•25 years ago
|
||
That would be cool... CCing hyatt to see if there is an similar precedent for this kind of thing. Is this a CSS candidate?
Comment 4•25 years ago
|
||
XP menus need this as well, e.g., a way of saying which key is the magic key (the one that activates the menu, a la ALT on Windows). I believe overlays or style sheets could be used to solve this problem. I'd be inclined to do it using style sheets, since it's something you want to apply to "all key sets" or "all menu bars". I have to cast my vote against the name shortcut though. I think commandkey or somesuch is better. If you put it in CSS, you'd need to preface it with moz, so you'd end up with a rule like: keyset { display: none; moz-commandkey: alt; }
Comment 5•25 years ago
|
||
Hmmm, actually I guess shortcut is ok.
Comment 6•25 years ago
|
||
saari, I think you should do this, and while you're at it, define moz-cropstyle as well (so that I can switch titledbuttons over to use that). :)
Comment 7•25 years ago
|
||
I also like shortcut. Hyatt brings up a good point--what do we call the accelerator for what I call "keyboard navigation of the menus" (Windows users use [alt])? I think it'd be confusing to call it the same thing as in the keybindings (Windows users use [Ctrl]). Maybe that should have its own bug?
Assignee | ||
Comment 8•25 years ago
|
||
Could we call that key "menu" or "menuKey", since that's what it's for? It's definitely a good point that this needs to be overridable too, since (some) Unix users will be using alt bindings for the accelerators and so won't have alt available for the menus, and they either need to turn off the menu nevigation key entirely, or put it somewhere else, like Meta.
Updated•25 years ago
|
Target Milestone: M10 → M11
Comment 9•25 years ago
|
||
There is apparently something similar proposed for CSS3, but Mr. Linss didn't mention the name... Anyway, this isn't an M10 priority so I'm pushing it to M11
Assignee | ||
Updated•25 years ago
|
Summary: need name for XUL virtual command key → [DOGFOOD] need name for XUL virtual command key
Assignee | ||
Comment 10•25 years ago
|
||
Okay, but please keep in mind that the longer you wait, the more people's keybinding files will be broken and will need updating when this eventually gets fixed. This needs to be fixed before Beta so outsiders see the final name for the key, so I'm marking the bug as dogfood.
Updated•25 years ago
|
Priority: P3 → P1
Updated•25 years ago
|
Summary: [DOGFOOD] need name for XUL virtual command key → [DOGFOOD] {css3} need name for XUL virtual command key
Comment 11•25 years ago
|
||
To see the current draft CSS3 spec for this see: http://www.w3.org/TR/1999/WD-css3-userint-19990916#key-equivalent Currently, the W3C are calling this virtual command key "accesskey", as in INPUT.open { key-equivalent: accesskey-O; } See the spec for many more examples. (URI is that above, scroll down a few pages to see the examples.)
Comment 12•25 years ago
|
||
Let's just use key-equivalent. It works for me on the menu bar.
Comment 13•25 years ago
|
||
Putting on PDT- radar
Assignee | ||
Updated•25 years ago
|
Whiteboard: [PDT-]
Assignee | ||
Comment 14•25 years ago
|
||
Kathy and I have been talking about this bug, and we'd like to see it re-evaluated by the PDT team. The issue here is that all XUL will have to change when this bug is fixed, so the longer we wait, the more XUL will have to be fixed (which makes it sort of an architectural bug as well, since key events and XUL infrastructure depend on it) and the more XUL authors will have to be re-educated about the change.
Updated•25 years ago
|
QA Contact: phillip → claudius
Comment 15•25 years ago
|
||
mass-moving most m11 bugs to m12
Updated•25 years ago
|
Assignee: saari → akkana
Status: ASSIGNED → NEW
Comment 16•25 years ago
|
||
reassigning to akkana, who has graciously offered to do the work. cc'ing pinkerton to assist with the Mac-specific changes that are needed.
Updated•25 years ago
|
Whiteboard: [PDT+] → [PDT+] [by 11/19]
Comment 17•25 years ago
|
||
this has been investigated and akkana has a good idea on how to resolve it; she may or may not need help from brade, saari, pink or ftang.
Updated•25 years ago
|
Whiteboard: [PDT+] [by 11/19] → [PDT+] [dependent on 13378 getting resolved]
Assignee | ||
Comment 18•25 years ago
|
||
In case anyone is just burning up with curiosity, I'm going to call the modifier "xulkey". It can't be "accesskey" because it turns out that menus are already using that. Chris says he's fine with calling it "xulkey".
Assignee | ||
Updated•25 years ago
|
Whiteboard: [PDT+] [dependent on 13378 getting resolved] → [PDT+] Have fix, awaiting review
Assignee | ||
Updated•25 years ago
|
Whiteboard: [PDT+] Have fix, awaiting review → [PDT+] Have fix, awaiting review, expect fix by 11/24
Assignee | ||
Updated•25 years ago
|
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Whiteboard: [PDT+] Have fix, awaiting review, expect fix by 11/24 → [PDT+]
Assignee | ||
Comment 19•25 years ago
|
||
The fix has been checked in. "command=" is now "xulkey=", and it's redefinable inside any given keyset.
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
Comment 20•25 years ago
|
||
code-level fix. marking VERIFIED.
Comment 21•25 years ago
|
||
hate to do this after the fact but, linking to 12658, composer pdt+ bug tracking
Comment 22•23 years ago
|
||
*** Bug 111834 has been marked as a duplicate of this bug. ***
Comment 23•23 years ago
|
||
Excuse the noise. Bug 111834 was not a dup of this one -- I meant to dup it to 111818 instead.
You need to log in
before you can comment on or make changes to this bug.
Description
•