Closed Bug 11818 Opened 25 years ago Closed 25 years ago

[DOGFOOD] {css3} need name for XUL virtual command key

Categories

(Core :: XUL, defect, P1)

x86
Linux
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: akkzilla, Assigned: akkzilla)

References

Details

(Keywords: css3, Whiteboard: [PDT+])

XUL key bindings have the concept of a "virtual command key", so that a XUL file
can specify a modifier key which will correspond to the command key on macs and
the control key on other platforms.  But this is currently called command, which
is confusing to everyone since it doesn't really mean the command key.

If there's going to be a virtual key it should be named something that doesn't
correspond to an actual key.

Ideally, this key should be changeable in the xul, so that Unix users can choose
to use the Unix modifier key (alt) or the Windows modifier key (control) by
changing one line instead of having to change every single key binding.
Status: NEW → ASSIGNED
Target Milestone: M10
Let the name voting begin. I'm voting for "shortcut".

As for where to redefine it... maybe as an attribute of the keyset tag?
I still like "moz", but "shortcut" would be okay too.

It would be ideal if we could define the modifier key sepately from a keyset.
E.g. Kathy has <keyset id="defaultKeySet">; it would really rock if there were
some way a user could say "use defaultKeySet, only use alt as the shortcut
key".  For instance, maybe after we've already read in all of <keyset
id="defaultKeySet">, we might read in the user's own key binding file which
might say something like

<keyset modify id="defaultKeySet" shortcut="alt">

which would change all the bindings in defaultKeySet to use a different shortcut
key.

Or, if it's easier to implement, do it globally (not applied to a particular
keyset id):

<keyset shortcut="alt">

which would apply to every keyset read in in this session.
That would be cool... CCing hyatt to see if there is an similar precedent for
this kind of thing. Is this a CSS candidate?
XP menus need this as well, e.g., a way of saying which key is the magic key
(the one that activates the menu, a la ALT on Windows).

I believe overlays or style sheets could be used to solve this problem.  I'd be
inclined to do it using style sheets, since it's something you want to apply to
"all key sets" or "all menu bars".

I have to cast my vote against the name shortcut though.  I think commandkey or
somesuch is better.  If you put it in CSS, you'd need to preface it with moz, so
you'd end up with a rule like:

keyset {
  display: none;
  moz-commandkey: alt;
}
Hmmm, actually I guess shortcut is ok.
saari, I think you should do this, and while you're at it, define moz-cropstyle
as well (so that I can switch titledbuttons over to use that). :)
I also like shortcut.

Hyatt brings up a good point--what do we call the accelerator for what I call
"keyboard navigation of the menus" (Windows users use [alt])?  I think it'd be
confusing to call it the same thing as in the keybindings (Windows users use
[Ctrl]).  Maybe that should have its own bug?
Could we call that key "menu" or "menuKey", since that's what it's for?

It's definitely a good point that this needs to be overridable too, since (some)
Unix users will be using alt bindings for the accelerators and so won't have alt
available for the menus, and they either need to turn off the menu nevigation
key entirely, or put it somewhere else, like Meta.
Target Milestone: M10 → M11
There is apparently something similar proposed for CSS3, but Mr. Linss didn't
mention the name...

Anyway, this isn't an M10 priority so I'm pushing it to M11
Summary: need name for XUL virtual command key → [DOGFOOD] need name for XUL virtual command key
Okay, but please keep in mind that the longer you wait, the more people's
keybinding files will be broken and will need updating when this eventually gets
fixed.  This needs to be fixed before Beta so outsiders see the final name for
the key, so I'm marking the bug as dogfood.
Priority: P3 → P1
Summary: [DOGFOOD] need name for XUL virtual command key → [DOGFOOD] {css3} need name for XUL virtual command key
To see the current draft CSS3 spec for this see:
   http://www.w3.org/TR/1999/WD-css3-userint-19990916#key-equivalent
Currently, the W3C are calling this virtual command key "accesskey", as in

   INPUT.open { key-equivalent: accesskey-O; }

See the spec for many more examples. (URI is that above, scroll down a few pages
to see the examples.)
Blocks: 15693
Let's just use key-equivalent.  It works for me on the menu bar.
Whiteboard: [PDT-]
Putting on PDT- radar
Whiteboard: [PDT-]
Kathy and I have been talking about this bug, and we'd like to see it
re-evaluated by the PDT team.  The issue here is that all XUL will have to
change when this bug is fixed, so the longer we wait, the more XUL will have to
be fixed (which makes it sort of an architectural bug as well, since key events
and XUL infrastructure depend on it) and the more XUL authors will have to be
re-educated about the change.
Whiteboard: [PDT+]
QA Contact: phillip → claudius
mass-moving most m11 bugs to m12
Blocks: 17907
Assignee: saari → akkana
Status: ASSIGNED → NEW
reassigning to akkana, who has graciously offered to do the work. cc'ing
pinkerton to assist with the Mac-specific changes that are needed.
Whiteboard: [PDT+] → [PDT+] [by 11/19]
this has been investigated and akkana has a good idea on how to resolve it; she
may or may not need help from brade, saari, pink or ftang.
Depends on: 13378
Blocks: 18951
Whiteboard: [PDT+] [by 11/19] → [PDT+] [dependent on 13378 getting resolved]
In case anyone is just burning up with curiosity, I'm going to call the modifier
"xulkey".  It can't be "accesskey" because it turns out that menus are already
using that.  Chris says he's fine with calling it "xulkey".
Whiteboard: [PDT+] [dependent on 13378 getting resolved] → [PDT+] Have fix, awaiting review
Whiteboard: [PDT+] Have fix, awaiting review → [PDT+] Have fix, awaiting review, expect fix by 11/24
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Whiteboard: [PDT+] Have fix, awaiting review, expect fix by 11/24 → [PDT+]
The fix has been checked in.  "command=" is now "xulkey=", and it's redefinable
inside any given keyset.
Status: RESOLVED → VERIFIED
code-level fix. marking VERIFIED.
Blocks: 20203
Blocks: 12658
hate to do this after the fact but, linking to 12658, composer pdt+ bug tracking
Keywords: css3
No longer blocks: 17907
No longer blocks: 18951
No longer blocks: 20203
*** Bug 111834 has been marked as a duplicate of this bug. ***
Excuse the noise.  Bug 111834 was not a dup of this one -- I meant to dup it to 
111818 instead.
You need to log in before you can comment on or make changes to this bug.