1188478 - Make it easier and more discoverable to enter into passwords importer

Status: VERIFIED FIXED

(Toolkit :: Password Manager, enhancement)

Description

[Edwin Wong [:edwong]]

Currently the only entry points for Passwords importer (Safari, Chrome, IE) are First Run and Bookmark Manager > import data from another browser. This is really hard to get to. Let's expose the import passwords tool in a more discoverable location or in a contextual event.

Comment 1

[Bill Maggs (bmaggs)]

We would like to make it easier for people to switch to Firefox for all or part of their browsing, and making Migration of data easier has been a much higher priority for competitor browsers than for us. Soon passwords will again be importable from Chrome, IE, and potentially Safari. 


Right now the migration experience is strongly deprecated after living in the File menu for a number of releases; it is in the Library view as part of the Bookmark import and backup button; bookmarks are probably only the third or fourth most important data type to migrate. 

To accomplish this we would need to convince ourselves that the somewhat crufty Migrator code works well enough to promote, so we would need some tests. 

Candidates for unburying the Migrator: 

1. FxA Onboarding process
2. Recurring CTA for the first few times you log into FxA
3. Contextual menu  
4. Permanent spot in the Sync Preferences pane. 

Is there anything stopping us from doing all or some of these, given a good quality experience?

Comment 2

[Bill Maggs (bmaggs)]

The behavior of the importer seems to be a bit uneven; only Bookamrks from Chrome are imported when Chrome is open; when Chrome is closed, History, cookies, and Bookmarks are imported, but the Bookmarks come in another duplicated folder.

Comment 3

[Edwin Wong [:edwong]]

+1 on getting a test pass completed to gain confidence toward making this first class. Adding Kamil.

Comment 4

[Matthew N. [:MattN]]

(In reply to Edwin Wong [:edwong] from comment #3)
> +1 on getting a test pass completed to gain confidence toward making this
> first class. Adding Kamil.

QE does a test pass of migrators in beta for every release btw. Verification for new migrations can be done in their own bugs.

Comment 5

[Ryan Feeley [:rfeeley]]

Would a simple “Import…” button in Preferences suffice?
https://www.lucidchart.com/publicSegments/view/54eb7f2f-a530-42a9-9530-2cb50a00c10b/image.png

Comment 6

[Edwin Wong [:edwong]]

works for me. Putting this on the backlog.

Comment 7

[Matthew N. [:MattN]]

Attachment: MozReview Request: Bug 1188478 - Add an Import button to the password manager to open the browser migrator. r=dolske

Bug 1188478 - Add an Import button to the password manager to open the browser migrator. r=dolske

Windows-only for now since we can't yet import passwords on other platforms.

Comment 8

[Bill Maggs (bmaggs)]

(In reply to Ryan Feeley from comment #5)
> Would a simple “Import…” button in Preferences suffice?
> https://www.lucidchart.com/publicSegments/view/54eb7f2f-a530-42a9-9530-
> 2cb50a00c10b/image.png

This is of course the right place for a permanent Import button, but we should still investigate other prompts such as fresh downloads and FxA onboarding.

Comment 9

[Kamil Jozwiak [:kjozwiak]]

(In reply to Matthew N. [:MattN] from comment #4)
> (In reply to Edwin Wong [:edwong] from comment #3)
> > +1 on getting a test pass completed to gain confidence toward making this
> > first class. Adding Kamil.
> 
> QE does a test pass of migrators in beta for every release btw. Verification
> for new migrations can be done in their own bugs.

Florin, are the migration passes still happening for each m-b release? I remember seeing something about migration testing with Spartan/Win 10 but not sure if work is still being done on the other browsers.

Comment 10

[Justin Dolske [:Dolske]]

Comment on attachment 8644148 [details]
MozReview Request: Bug 1188478 - Add an Import button to the password manager to open the browser migrator. r=dolske

https://reviewboard.mozilla.org/r/15235/#review13803

Ship It!

::: toolkit/components/passwordmgr/content/passwordManager.js:459
(Diff revision 1)
> +function OpenMigrator() {

I don't think we need the ifdefs here. As long as it's not in the UI, there's no harm in having callable code that doesn't work in not-Firefox.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/a4836b5699de

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a4836b5699de

Comment 13

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

(In reply to Kamil Jozwiak [:kjozwiak] from comment #9)
> Florin, are the migration passes still happening for each m-b release? I
> remember seeing something about migration testing with Spartan/Win 10 but
> not sure if work is still being done on the other browsers.

Yes, migrators are covered in each Beta cycle now. For Firefox 40 this happened in Beta 4 (https://docs.google.com/spreadsheets/d/1ZGOcdnEVy8RC1OPf2YPzKNPY3Df9lLmrdKarwjPcbFA/edit#gid=34497851).

I'm assigning this to myself, along with some other Migrator fixes, so I can get new tests and get them verified. Note that since the fixes are in Firefox 42 they will be treated with medium priority, meaning it may be weeks before we can get to this.

Comment 14

[Kamil Jozwiak [:kjozwiak]]

I haven't tested the migrator as per comment # 13 but I did check and made sure that the "Import" button is correctly appearing under Windows (Win 8.1 x64 & Win 10 x64) and not under OSX (10.10.4) and Ubunutu (14.04.2) via about:preferences#security -> Saved Passwords. Checked on both m-c and m-a.

Comment 15

[Vasilica Tamas, QA [:vtamas]]

I can confirm that the imported passwords are now exposed in about:preferences#security.

During this testing on Firefox 44.0a1 (2015-09-27), Firefox 43.0a2 (2015-09-27) and Firefox 42 Beta 1 (20150921151815) under Windows 7 64-bit and Windows 10 32-bit, I’ve encountered 2 new issues: Bug 1209034 and Bug 1209048 .

Based on the above mentions, I am marking this bug as Verified, since the other issues are tracked separately.