119496 - Small HTML file impossible to save (no "attachments")

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Boris Zbarsky [:bzbarsky]]

BUILD: Linux 2002-01-07-06 nightly and 2002-01-11 morning CVS build

STEPS TO REPRODUCE:
1) Load the first attachment to this bug in the browser
2) Hit Ctrl-S
3) Choose "foobar.html" as the filename
4) Choose "Web Page, Complete" as the method
5) Click "Save"

EXPECTED RESULTS: Page is saved

ACTUAL RESULTS:  A "Saving File" dialog appears, no values are filled in for the
                 locations, times, status, etc, the only enabled button is
                 "Cancel".  File is _not_ saved.

Notes:
A)  Step #4 may not be necessary.  I cannot test becase on Linux there is no way
    to save in non-complete mode.
B)  This is distinct from bug 116757 / bug 115216.  The page contains no
    external references of any kind.
C)  This bug makes creating minimal testcases for various file save bugs
    impossible because the testcases do not get saved.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: File to save

Comment 2

[Adam Lock]

Patch for 115216 should fix this.

There is some dumb logic that saves the document(s) after the last URI has been
saved, but there are no URIs so no document ever gets saved!

Comment 3

[Boris Zbarsky [:bzbarsky]]

Heh.  Adding dependency, then.  :)

Comment 4

[Adam Lock]

Checkin for bug 110135 now allows the file to be saved but the save progress
dialog does not disappear. This indicates that a STATE_NETWORK_STOP progress
notification or somesuch is not being sent when saving a document with no
embedded URIs.

Comment 5

[Boris Zbarsky [:bzbarsky]]

*** Bug 120044 has been marked as a duplicate of this bug. ***

Comment 6

[Ben Tremblay]

2002011003 on Win95
simple .html saves using "HTML only" but fails using "complete", with empty dir 
created.
Absent URIs, save should fall through to "HTML only" (or fail) _before_ creation 
of directory.

bandaid: set "HTML only" (which is the traditional action) as default

Comment 7

[Adam Lock]

Moving out to 0.9.9. Updated patch for bug 116279 will probably fix this.

Comment 8

[Adam Lock]

Correction, patch for bug 115216 will probably fix this.

Comment 9

[Adam Lock]

*** Bug 120558 has been marked as a duplicate of this bug. ***

Comment 10

[Adam Lock]

Attachment: Patch

Patch puts progress notifications in saveDocument so even if no URIs were
actually saved the listener still gets STATE_START & STATE_STOP events. Patch
also cleans up the code a bit.

Reviews?

Comment 11

[Kathleen :Brade]

Comment on attachment 65497 [details] [diff] [review]
Patch

r=brade

Comment 12

[Asa Dotzler [:asa]]

drivers would like this for 0.9.8. What kind of risk does this fix entail?

Comment 13

[Adam Lock]

This bug should be pretty low risk.

Comment 14

[Adam Lock]

*** Bug 117829 has been marked as a duplicate of this bug. ***

Comment 15

[David Hyatt]

sr=hyatt

Comment 16

[Adam Lock]

Comment on attachment 65497 [details] [diff] [review]
Patch

sr=hyatt

Comment 17

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin to the 0.9.8 branch

Comment 18

[Adam Lock]

Fix checked into branch and trunk

Comment 19

[Kathleen :Brade]

*** Bug 121065 has been marked as a duplicate of this bug. ***

Comment 20

[Kathleen :Brade]

*** Bug 121870 has been marked as a duplicate of this bug. ***

Comment 21

[Ray Frush]

Build 2002012803: Running on Windows 2000 Pro WS (SP2)

Within Composer:
File Save fails silently when saving to local and network file systems.
Tested with files originally opened locally and from network.

File Save AS  pops up a dialog box titled "Save Page" reporting "Saving file
failed!"  This is an improvement, but I still can's save changes!

Originally reported as bug #121870
(http://bugzilla.mozilla.org/show_bug.cgi?id=121870)

Please consider re-opening this bug

Comment 22

[Adam Lock]

Reopen the other bug if necessary not this one. The patch does fix the reported
issue and there is a futher patch in bug 122078 which may catch whatever is
causing the editor to fail.

Comment 23

[Kathleen :Brade]

I don't think the Composer problem is fixed by patch in bug 122078.
The Composer failure dialog bug is bug 122043.

Comment 24

[sairuh (rarely reading bugmail)]

vrfy'd fixed using 2002.01.29.xx comm bits on linux rh7.2, mac 10.1.2 and win2k.
thx for the test case/recipe, bz!

Comment 25

[Boris Zbarsky [:bzbarsky]]

*** Bug 123558 has been marked as a duplicate of this bug. ***