Closed Bug 1202360 Opened 4 years ago Closed 4 years ago

Bring Firefox Account handling modules back to TV system

Categories

(Firefox OS Graveyard :: Gaia::TV::System, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(feature-b2g:2.5+)

RESOLVED FIXED
feature-b2g 2.5+

People

(Reporter: yifan, Assigned: yifan)

References

Details

(Whiteboard: [ft:conndevices][partner-cherry-pick])

Attachments

(1 file)

Firefox Account modules were not included in the TV system app since the beginning of the TV project. Now we need Firefox Account sync features so we have to merge them back to TV system app.
Assignee: nobody → yliao
Status: NEW → ASSIGNED
Blocks: 1202376
feature-b2g: --- → 2.5+
Comment on attachment 8659105 [details] [review]
[gaia] begeeben:1202360_bring_firefox_account > mozilla-b2g:master

The patch brings the Firefox Account sign in feature in the system app to Firefox OS TV system. Please help to review it, thanks Rex!

Hi Fernando, I've added 1 line in shared/js/fxa_iac_client.js to enabled IAC connection with the TV smart system app. Please help to review it, thanks!
Attachment #8659105 - Flags: review?(rexboy)
Attachment #8659105 - Flags: review?(ferjmoreno)
Comment on attachment 8659105 [details] [review]
[gaia] begeeben:1202360_bring_firefox_account > mozilla-b2g:master

Thank you YiFan. LGTM.

This patch adds the FxA module exactly as it is on the phone. So I guess you'll need to adapt the UI so it looks good on the TV. Is there any bug filed for that?
Attachment #8659105 - Flags: review?(ferjmoreno) → review+
Blocks: 1203898
Thank you Fernando! It would be bug 1203898. We'll start working on it once visual design is completed.
Comment on attachment 8659105 [details] [review]
[gaia] begeeben:1202360_bring_firefox_account > mozilla-b2g:master

First thank you for the effort of arranging these libraries into smart-system!
It looks good overall, but there are just 3 test cases failed; Let's fix them before landing. See some of my comments on Github. Thanks!
Attachment #8659105 - Flags: review?(rexboy) → review-
Comment on attachment 8659105 [details] [review]
[gaia] begeeben:1202360_bring_firefox_account > mozilla-b2g:master

Thanks Rex! Fixed nits. Please review it, thanks!

Hi Ricky, the build test for GAIA_DEVICE_TYPE=tv in apps/system is removed, please help to review, thanks!
Attachment #8659105 - Flags: review?(rexboy)
Attachment #8659105 - Flags: review?(rchien)
Attachment #8659105 - Flags: review-
Comment on attachment 8659105 [details] [review]
[gaia] begeeben:1202360_bring_firefox_account > mozilla-b2g:master

r+ for build part changesets. 

A small question, I wonder why you need to put dev_apps/uitest in app.list?
Attachment #8659105 - Flags: review?(rchien) → review+
Thanks! The tests for fxa modules need uitest app to work.
Blocks: 1207488
Blocks: 1207481
Blocks: 1207483
Comment on attachment 8659105 [details] [review]
[gaia] begeeben:1202360_bring_firefox_account > mozilla-b2g:master

Looks good to me.
Thanks a lot!
Attachment #8659105 - Flags: review?(rexboy) → review+
Thanks! Merged into master:

https://github.com/mozilla-b2g/gaia/pull/31782
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Component: Gaia::TV → Gaia::TV::System
Whiteboard: [ft:conndevices] → [ft:conndevices][partner-cherry-pick]
You need to log in before you can comment on or make changes to this bug.