1202361 - [Stingray][fling-player][TV][2.5] (TV side) TV to receive video casted from Fennec

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::Fling, defect, P1)

Description

[KM Lee [:rexboy] (inactivate after Sep. 22)]

We need to revise the fling player such that it works on our new presentation API use case. The working items includes:
1. Add spatial navigator.
2. Add control box which is able to play/stop the video.
3. The control box should sync its playing/stopping status with its remote sender.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] Fischer-L:ft-presentation-cast-video > mozilla-b2g:master

Comment 2

[Fischer [:Fischer]]

Attachment: PR #31905

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8662802 [details] [review]
PR #31905

Overall it looks good to me, just with some style and typo errors.
But since the interface of Presentation API in Gecko has moved to newer version, we need to align to it before landing.
I'm still trying to make the updated Gecko build works :-/
I'll ping you once it's ready.

Thanks for your work!

Comment 5

[Josh Cheng [:josh]]

(In reply to KM Lee [:rexboy] from comment #4)
> Comment on attachment 8662802 [details] [review]
> PR #31905
> 
> Overall it looks good to me, just with some style and typo errors.
> But since the interface of Presentation API in Gecko has moved to newer
> version, we need to align to it before landing.
> I'm still trying to make the updated Gecko build works :-/
> I'll ping you once it's ready.
> 
> Thanks for your work!

Hi Rex,
Can you give us an update for the current status of the updated Gecko build? Can we get this done before Oct/2?

Comment 6

[Fischer [:Fischer]]

Attachment: PR #32120

Comment 7

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Let's try to finish reviewing it this week.

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8667689 [details] [review]
PR #32120

Looks good to me overall, most of them are just coding style issue. But since several places need to be changed, and I'm a little bit concerned about adding in-code behavior test in the main code. Please come to me if you need discussion. Please set r? to me again after you finished changes. 

Thank you!

Comment 9

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8667689 [details] [review]
PR #32120

Looks good to me. Thank you!

Comment 10

[KM Lee [:rexboy] (inactivate after Sep. 22)]

There's a one jshint error, please be sure to fix it before merging.

Comment 11

[Fischer [:Fischer]]

Landed on master: https://github.com/mozilla-b2g/gaia/commit/b77dde37d8e02e22f7421b082687e6f3ecd58480
Test: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=e467a2a2845df86152ce428be00425e97ece3a41