Closed
Bug 1210700
Opened 9 years ago
Closed 9 years ago
[Stingray][fling-player][TV][2.5] Fling player control panel should hide and show based on user's key input
Categories
(Firefox OS Graveyard :: Gaia::TV::Fling, defect, P1)
Firefox OS Graveyard
Gaia::TV::Fling
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Fischer, Assigned: Fischer, NeedInfo)
References
Details
(Whiteboard: [ft:conndevices][partner-cherry-picked<2015/11/10>])
Attachments
(2 files)
Fling player control panel should
(1) Hide automatically
(2) Show when user presses remote control's key
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → fliu
Assignee | ||
Updated•9 years ago
|
Component: Gaia::TV → Gaia::TV::Fling
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8670699 -
Flags: review?(ehung)
Comment 3•9 years ago
|
||
Comment on attachment 8670699 [details] [review]
PR #32290
It seems you didn't add too much features in this patch but split codes into some small files which I'm not sure if it's worth doing.
As we discussed offline, we can't workaround Gecko issues in Gaia just for easier doing manual test, instead we should push Gecko guys to fix them and list them as your blockers if they really block your development.
Please also try new mozIntl api to your time formatting case as Zibi suggested in the mail. Thanks.
Attachment #8670699 -
Flags: review?(ehung) → review-
Assignee | ||
Updated•9 years ago
|
Attachment #8670699 -
Flags: review- → review?(ehung)
Assignee | ||
Comment 4•9 years ago
|
||
Please see the updated PR: https://github.com/mozilla-b2g/gaia/pull/32290
Because the mozIntl formats based on locale and my format case should disregard locale, would just leave the mozIntl there.
Comment 5•9 years ago
|
||
Comment on attachment 8670699 [details] [review]
PR #32290
Luke, could you feedback on the change of simple_key_navigation.js? Thanks!
Attachment #8670699 -
Flags: feedback?(lchang)
Assignee | ||
Comment 6•9 years ago
|
||
@Zibi
My case is that the current video time(hh:mm:ss) and the video total duration(hh:mm:ss) are placed on the two sides of time progress bar.
Since the control panel of my TV video player has no text but just icon, time bar and time digits(in hh:mm:ss), I am not sure my case fit the mozIntl.DurationFormat use case.
Could you please elaborate more about the mozIntl.DurationFormat use case ?
Comment 7•9 years ago
|
||
Comment on attachment 8670699 [details] [review]
PR #32290
Just a few nits need to be addressed, please see my comments on Github.
I'd like to know Zibi's opinion on the playback time. I guess we need to localize it. Thanks.
Attachment #8670699 -
Flags: review?(ehung)
Assignee | ||
Comment 8•9 years ago
|
||
@Zibi,
My case is that the current video time(hh:mm:ss) and the video total duration(hh:mm:ss) are placed on the two sides of time progress bar.
Since the control panel of my TV video player has no text but just icon, time bar and time digits(in hh:mm:ss), I am not sure my case fit the mozIntl.DurationFormat use case.
Could you please elaborate more about the mozIntl.DurationFormat use case ?
Flags: needinfo?(gandalf)
Comment 9•9 years ago
|
||
Comment on attachment 8670699 [details] [review]
PR #32290
I left some comments on "simple_key_navigation.js". Please take a look. Thanks.
Attachment #8670699 -
Flags: feedback?(lchang)
Assignee | ||
Updated•9 years ago
|
Attachment #8670699 -
Flags: review?(ehung)
Attachment #8670699 -
Flags: feedback?(lchang)
Comment 10•9 years ago
|
||
Comment on attachment 8670699 [details] [review]
PR #32290
"simple_key_navigation.js" looks good to me. Thanks.
Attachment #8670699 -
Flags: feedback?(lchang) → feedback+
Comment 11•9 years ago
|
||
Comment on attachment 8670699 [details] [review]
PR #32290
r+ with nits addressed. Please file a follow-up bug for mozIntl thing. Thanks.
Attachment #8670699 -
Flags: review?(ehung) → review+
Assignee | ||
Comment 12•9 years ago
|
||
Land to master: https://github.com/mozilla-b2g/gaia/pull/32290
Test: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=1a1c447e4516ca77b90569ccd6eab51a9b8f8c25
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Whiteboard: [ft:conndevices][partner-cherry-pick] → [ft:conndevices][partner-cherry-picked<2015/11/10>]
You need to log in
before you can comment on or make changes to this bug.
Description
•