121215 - MailNews sidebar is empty at startup for Alt 3-pane

Status: VERIFIED INVALID

(SeaMonkey :: Sidebar, defect, P3)

Description

[Pierre Chanial]

Linux build 2002 01 21 21.
Could not find a duplicate.

Step to reproduce:
- start mozilla
- open mail window
- open the sidebar
- close mozilla
- reopen mozilla 
- open mail window

Actual result: No sidebar
Expected result: presence of the sidebar.

Comment 1

[Oliver Klee]

Confirming on 2002011503 Win2k. The sidebar is not completely gone though, it's
just collapsed to the bottom.

Comment 2

[Oliver Klee]

Oh, and OS=All.

Comment 3

[Olga]

Win2K, today's build: Sidebar appears without tabs, just first line on the top:
My Sidebar, Tabs, [x] buttons - after re-opening Mail.

Comment 4

[Pierre Chanial]

Oliver, the arrows are poInting downwards, that indicates that the sidebar is
not collapsed, but empty. 
Clicking on the grippy does not show up the sidebar. But F9 does.
Changing summary to reflect that.

Comment 5

[[not reading bugmail]]

see related bug 116094, and bug 117130.

Comment 6

[Armen]

I would also like to add that after disabling thene nabling the sidebar to get
it to show up in the blank pane, Mozilla hangs trying to load the sidebar
content. This is on .9.8, win32 build.

Comment 7

[Pierre Chanial]

adding keywords, nominating since this bug prevents the user
to have the addressbook tab in the mailnews window at startup ala OE.
The workaround is to hit F9 twice, since clicking on the sidebar grippy does not
work.
cc'ing sgehani.

Comment 8

[[not reading bugmail]]

seth, 

some of this problem is related to the 3-pane Mail/News sidebar bug 123205.

Comment 9

[scottputterman]

Olga, does this still happen?  Does this happen on a new profile?  I was seeing
this a few weeks ago but haven't seen this since.

Comment 10

[Olga]

Update with yesterday's and today's build - 02-14-2002. New and existing profile.
Sidebar looks okey on the Browser and Mail. But when move splitter down, empty
gray area gets unveiled. The part from the splitter till Tabs changes size. I
see it on Win2K and Linux, both browser and mail.

Comment 11

[scottputterman]

I think that may be a different bug. Could you file that if it doesn't exist and
assign it to the Sidebar component?  I'm going to mark this WFM.

Comment 12

[Olga]

Verified WFM on today's build, Win2K, Linux, Mac OSX.
For empty gray area - bug 125547.

Comment 13

[[not reading bugmail]]

putterman, this is still here, just blake's recent decision to backout
sidebarOverlay.xul put this back to the way it was.  so Reopening.  

noting: http://bugzilla.mozilla.org/show_bug.cgi?id=124620#c39

Comment 14

[[not reading bugmail]]

pierre can you confirm and double check my thoughts here for me on this, I've
been having problems recently with my brain and not thinking straight, so, I'm
pretty sure this is back after that.  Thanks.

Comment 15

[Pierre Chanial]

Yes, Dennis, you're right.
I confirm that the sidebar is still empty at startup.

Comment 16

[scottputterman]

reassigning to component owner.

Comment 17

[sujay]

TRacy and I are gonna test this out on today's builds..

Comment 18

[Tracy Walker [:tracy]]

while we are waiting for the builds to come out...isn't this  just another 
version of bug 126661?

I have seen the same thing happen with the stand alone IM in netscape.  sidebar 
(in the stand alone there isn't a sidebar..the stand alone is a sort of sidebar 
with buddy list as default) sometimes starts empty. Same thing as this and 
126661 closing and opening brings up content.

Comment 19

[sujay]

*** This bug has been marked as a duplicate of 126661 ***

Comment 20

[Pierre Chanial]

reopening

Comment 21

[Olga]

Update with 2002-02-22-10-trunk build.
1. Correct launch with Mail Sidebar just after installation - existing profile.
2. Created new profile - correct Mail Sidebar.
3. Exit and started again with my previous existing profile. Noticed that
Browser did not show first as expected. So, in coming Mail the Sidebar is empty.
But as soon as I clicked Cancel on password dialog, Sidebar got its content.
Looks fine.
4. To reproduce it I exited and started application again with my existing
profile. The difference now is that Sidebar is still empty after Cancel
passwords, after moving scroll bars, after selecting my account and logging in.
Now Mail has empty Sidebar and Browser has correct one.

Comment 22

[Peter Trudelle]

nsbeta1+ per ADT triage team

Comment 23

[Syd Logan]

*** Bug 123205 has been marked as a duplicate of this bug. ***

Comment 24

[[not reading bugmail]]

syd, my bug 123205 is not really a dupe, its about if you move the grippy first,
it causes some real weird painting problems, before you decide to load the
sidebar.. so with help on this take a look at my analysis of bug 123205, so if
you have a load issue, maybe my bug will be fixed, not fix the underlining
problem in my bug, if anything this should be depended on that underlining
issue.   But not sure if that will fix the problem which is all by itself,
without loading.. there is a serious flaw in the xul code for mail/news sidebar
as I found out, that probably didn't quite make tree -> outliner correct changes
or something thereof.

Comment 25

[sujay]

is it possible this is a DUP of 119975 ? can someone check..

Comment 26

[[not reading bugmail]]

Sujay,

just to keep these bugs straight, 

no, I dont think so.. bug 119975 before and after it was fixed and broken is for
Browser sidebar, This is for Mail/News sidebar, and doesn't get affected by the
code within the browser except SidebarOverlay files.. as I found out in my bug
123205 that syd decided to dupe against this... this is affected by XUL code in
mail/news section.

Now by again looking at my dupe, I believe this will not be fixed unless you
take a look at my dupe and fix that first, which will probably fix this problem.
 Bug 119975 appears to stem from the problem in bug 127113.. which Samir noted
that it probably doesn't affect this bug per a comment I asked in bug 127113. :)

Comment 27

[Pierre Chanial]

Dennis, your efforts in finding when the regression occurred are great.
This bug seems to be really old, since this bug should have been marked as a
dupe of bug 54276 (my bad), althought Dennis states that this bug is not present
in mozilla 0.9.4.1.

Nevertherless, you are inverting bug dependencies:
In your original report in bug 123205, you hit the present bug in step 2. The
following steps are acting on a broken feature (see comment 4).
Thus, when the present bug will get fixed, you will have to check if the bug you
have reported still exist.
Finally, Samir was referring to the recent regression (hopely fixed) in all
sidebars that is not related to this bug.

Comment 28

[[not reading bugmail]]

thanks pierre, for also helping to clarify those putting these into a bigger
picture here.. Which is what I trying to write so others may understand how
these bugs fit together.  Sorry, as I see I left a hole or two in my comment
thought process regarding the whole picture from one bug you have to the bug I
have, how they mix together and the other sidebar bugs, I see you have noted
those descrete details here, thanks! .. thanks for your help everyone!

Comment 29

[[not reading bugmail]]

note, regarding netscape 6.2.1, it shows the arrows pointing upward with the
grippy, even at the bottom of the pane.

Comment 30

[Matthias Versen [:Matti]]

*** Bug 130535 has been marked as a duplicate of this bug. ***

Comment 31

[Jaime Rodriguez, Jr.]

ADT2 per ADT/Nav triage.

Comment 32

[Samir Gehani]

Attachment: Patch v1

Set hidden="false" for older profiles instead of removing hidden from
sidebar-panels-splitter-box because the default localstore.rdf for mozilla the
hidden persisted as true (not the case for the default ns localstore.rdf though
so mailnews always had a sidebar there).  We used to use the hidden attribute
to detect sidebar display state but migrated to the collapsed attribute.  This
is cleanup.

Also moved the nav-buttons-box into the sidebar-panels-splitter-box since
mailnews hides or shows this box instead ofthe parent sidebar-box which it also
uses to show the folder outliner.

Comment 33

[Samir Gehani]

morse, please r.
alecf, please sr.

Thanks.

Comment 34

[Stephen P. Morse]

So we are doing this for backwards compatability with older profiles.  
Instead, is there any way we can detect the old profile and fix it up the fly? 

Comment 35

[Samir Gehani]

Steve,
(a) There's no way that I know of that we can detect an older
mozilla/netscape6.x profile once we have started.  I looked at the
nsIProfile*.idl interfaces but found nothing and didn't expect to.  I believe
this sort of migration is OK.  The code is really small.

(b) The backaward compatibility was already being handled.  We are just tweaking
how we are handling the backward compatibility in this patch.

Comment 36

[Stephen P. Morse]

OK then.  r=morse

Comment 37

[Alec Flett]

Comment on attachment 75329 [details] [diff] [review]
Patch v1

sr=alecf

Comment 38

[Asa Dotzler [:asa]]

Comment on attachment 75329 [details] [diff] [review]
Patch v1

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 39

[Samir Gehani]

Fix checked in.

Comment 40

[Olga]

Again I see blank Sidebar when toggle F9 on 3-pane window - existing profile,
today's build, Win2K. I turn Sidebar off. Exit, restart - on Browser: very
narrow blank Sidebar. On Mail: after F9: it appears closed - just horizontal
splitter with small arrows showing up.  The same behavior what I've seen last
builds.
Created new profile: Nice appearance in Browser and Mail with default tabs: News
(opened), Stocks, Buddy List.  But problems start show up after toggle F9 and
collapsing Sidebar. Empty - just gray area on the narrow Sidebar.  
I guess it is related to bug 131689.
I check again on Monday.

Comment 41

[sujay]

Olga, REOPEN this bug if you feel it is not fixed...

Comment 42

[Olga]

Bug is still valid for Alt 3-pane mail window - I add this to the summary and
reopen.
Steps:
1. Initial state: 3-pane
2. Start N6, open mail window, open the sidebar.
3. Exit, re-start browser and mail - sidebar is shown.
4. Change themes to Alt 3-pane in Preferences (second option). After closing
Pref. exit applic.
5. Open N6: now Empty Sidebar (instead of showing content) is shown at the very
left side of the Mail window.
6. Exit and re-start still shows empty Sidebar.

Comment 43

[[not reading bugmail]]

ok, I apologize, I found the real time that was actually broken.. its not 0.9.4.
branch at all.. its furthur back and happened.. after the 0.6, 0.8, and 0.9
milestones work the same, it give me content and it is broken in the 0.9.1
milestone. 


Some notes in 0.9 milestone: Sidebar grippy height = half of the folder pane. 
There are panels there with content and sidebar is 'on'.   

This behavior changed to grippy at the bottom of folder pane, and no panels are
shown when moving grippy up.. which is what we still see today: which is broken
in 0.9.1 milestone.


I've been looking at checkins for 3/26/2001 milestone release date to 5/7/2001
0.9.1 milestone release date.  I think it could have started earlier than 3/26 
but I *couldn't* get Mozilla to spit out the whole checkin list on dialup.. so..

I've resorted to LXR and searched for sidebar.. 
and I'm thinking the original problem came from the changes that happened from
bug 60071, just before the 0.9.1 milestone.  This bug added the Hide/Show/F9
capability to all the sidebars.. I didn't search for Messenger.xul to see if
this didn't get changed properly.. or even the Mail/News 3Pane file.

Next maybe's are bug 70746 and bug 72923 XUL changes that occured, when I looked
in LXR from around 0.9 to 0.9.1 timeframe as well.  So this has been broken for
a  whole year..

This should be more helpful to you Samir.

Comment 44

[Damien Covey]

This is exactly what is STILL happening to me on Linux with build 2002050221. 
I've tried creating a new profile, but that didnt fix this problem either!  I've
been having this probelm for months now.  Is there any progress? I not that
target milestone is 1.0, and I tend to agree with that, this should work for 1.0.

Comment 45

[Peter Trudelle]

removing + for retriage, should be very low impact now if it only affects alt
3-pane.

Comment 46

[Peter Trudelle]

nsbeta1- per Nav triage team

Comment 47

[[not reading bugmail]]

but isn't alt-3 pane different then the 4 pane right.. which is the default.. as
does happen each time.. I'd like to just see either a) fixed eventually, or b)
copy addressbook functionality.

Comment 48

[David G King]

I've just started seeing this happening with nightly Trunk builds 2002062004 and
20020619. And yes, I'm using the second 3-pane viewing option.

If I press F9 (or use View-Show/Hide) twice it goes away. What a pain....

Comment 49

[David G King]

I should note that the first time I press F9 (under Win98SE) I get the following
message.

Alert.
The file
/D:/PROGRAM%20FILES/MOZILLA.ORG/MOZILLA/chrome/packages/aim/SidebarPanel.xul
cannot be found. Please check the location and try again.

I suspect this is a seperate issue, but thought I'd mention it in case it isn't.

Comment 50

[Matthias Versen [:Matti]]

The mailnews isebar is removed -> invalid

Comment 51

[Tracy Walker [:tracy]]

verified