Closed Bug 1220588 Opened 6 years ago Closed 6 years ago
[TV] FTE for usage matrics
+++ This bug was initially created as a clone of Bug #1220584 +++ This bug should implement FTE for usage matrics. UX spec is currently on-going in bug 1199313.
Whiteboard: [ft:conndevices] → [ft:conndevices][partner-cherry-pick]
No longer blocks: 1225847
Comment on attachment 8689869 [details] [review] PR #33286 See my comments.
Comment on attachment 8689869 [details] [review] PR #33286 The updates: * Focus on the terms section on load * Add one downward arrow icon to guide user scroll down the terms * Show the default scroll bar when scrolling the terms and no frame or outline effect when focusing on the terms * Hide the downward arrow icon when scrolling down to the end of the terms * Use Simple Navigation to resolve the navigation issue on the small screen
Comment on attachment 8689869 [details] [review] PR #33286 r+ but see my comments. Please correct them before landing. I would suggest you to scan your patch by yourself once before sending review, if you didn't do that before. Also take care of your variable naming, avoid misleading names.
Attachment #8689869 - Flags: review?(rexboy) → review+
Updated and land to master: https://github.com/Fischer-L/gaia/commit/904ffc3716d41a68fc587ae7e1e413d3b97d0778 Tets: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=904ffc3716d41a68fc587ae7e1e413d3b97d0778
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [ft:conndevices][partner-cherry-pick] → [ft:conndevices][partner-cherry-pick][partner-blocker]
Comment on attachment 8689868 [details] [review] [gaia] Fischer-L:bug_1220588-FTE-for-usage-metrics > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): 1220588 [User impact] if declined: The user will not be able to chose whether to send data to Firefox or not. [Testing completed]: Yes [Risk to taking this patch] (and alternatives if risky): Low [String changes made]: No
Attachment #8689868 - Flags: approval-gaia-v2.5?
[Blocking Requested - why for this release]:
blocking-b2g: --- → 2.5?
Comment on attachment 8689868 [details] [review] [gaia] Fischer-L:bug_1220588-FTE-for-usage-metrics > mozilla-b2g:master Approve for TV FTE
Attachment #8689868 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
You need to log in before you can comment on or make changes to this bug.