123029 - News accounts are always shown collapsed on Mozilla restart

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, enhancement)

Description

[Aleksey Nogin]

Reproducible: always, on 3 different machines (all - RedHat Linux)

To reproduce (assuming you've set up several News accounts in Mozilla):

1) In the folders pane of 3-pane window, expand the view of some of them.
2) Restart Mozilla

Expected: On restart, the collapsed/expanded state is preserved
Actual: On restart, they are all collapsed.

Note: for Local/Pop/IMAP account the state is preserved, only News ones are
problematic.

It used to work some time ago (at least several milestones back, so I do not
remember exactly). I am currently running BuildID 2002012619 (trunk) on RedHat
Linux 7.2

I just tried deleting all the per-host .msf files in the News directory, it did
not change anything. I haven't tried setting up a complete new profile though...

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

bug 103010, Aleksey.

*** This bug has been marked as a duplicate of 103010 ***

Comment 2

[Aleksey Nogin]

In that case please consider this an RFE for having a preference to override
this (bug 103010) desision.

I have 3 NNTP accounts that I want to actively monitor and be notified of new
messages ASAP. I have "check for new mail every 1 minute" set for those
accounts, I *always* have them expanded and currently the first thing I do every
time I restart Mozilla is going and expanding all those. 

We need either a separate preference for leaving things expanded or consider
"check for new mail every xxx minutes" to be such a preferences (e.g. if I want
to actively monitor and NNTP server and I used to have it expanded, it's a
reasonable assumption that I'd still want to have it expanded next time I start
Mozilla).

IMHO, the second choice is the better and more logical...

Comment 3

[Alfonso Martinez]

Such preference already exists. Add this line to pref.js in your profile
directory (or better to user.js)

user_pref("news.persist_server_open_state_in_folderpane", true);

Comment 4

[Aleksey Nogin]

Would it make sense to use "is biff ienabled for that account" in addition to or
instead of news.persist_server_open_state_in_folderpane ?

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 147113 has been marked as a duplicate of this bug. ***

Comment 6

[Peter Lairo]

Editing pref.js is not the solution to this bug. If users leave their folders
open, they are doing so for a reason. At a *minimum* if biff notification is on,
mozilla should respect the user-chosen open folders.

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 185717 has been marked as a duplicate of this bug. ***

Comment 8

[Troodon]

This bug may have been fixed, see bug 270653 and check with a nightly build.

Comment 9

[[e-mail]]

FYI as per bug 350864 we now have a per-account checkbox to check for new news on startup that replaces the old system of having to set this pref.

Comment 10

[[e-mail]]

Attachment: Part 1: Remove superfluous PerformExpandForAllOpenServers

Since only imap and news servers have ever implemented PerformExpand and imap was always excluded because it had biff on startup then now that news has biff on startup it becomes completely unnecessary.

Comment 11

[[e-mail]]

Attachment: Part 2: kill news.persist_server_open_state_in_folderpane

Comment 12

[[e-mail]]

Attachment: Part 3: kill persistElided

I guess for branch you'd just want the first nsMsgDBFolder hunk, right?

Comment 13

[David :Bienvenu]

Comment on attachment 236641 [details] [diff] [review]
Part 2: kill news.persist_server_open_state_in_folderpane

thx, Neil!

Comment 14

[David :Bienvenu]

Comment on attachment 236644 [details] [diff] [review]
Part 3: kill persistElided

yes, for 2.0, we'd rather not remove a method from an interface...

Comment 15

[[e-mail]]

Fixes checked in.

Comment 16

[Peter Lairo]

(In reply to comment #11)
> Created an attachment (id=236641) [edit]
> Part 2: kill news.persist_server_open_state_in_folderpane

Please pardon my non-programmer ignorance. If what "fixed" this bug in a pref was "killed", how was this bug then "fixed"? :-\

Comment 17

[[e-mail]]

(In reply to comment #16)
>Please pardon my non-programmer ignorance. If what "fixed" this bug in a pref
>was "killed", how was this bug then "fixed"? :-\
The folder default is not to collapse on restart. What I killed was the news server override which, confusingly, was controlled by a pref that defaulted to force collapse on restart. So what I really killed was the override.

Comment 18

[Peter Lairo]

(In reply to comment #17)
> The folder default is not to collapse on restart. What I killed was the news
> server override which, confusingly, was controlled by a pref that defaulted to
> force collapse on restart. So what I really killed was the override.

Devil's Advocate: So if someone were to actually *want* the newsfolders to collapse on restart, could they no longer do that? Wouldn't it have been better to simply *reverse the default setting* of news.persist_server_open_state_in_folderpane from FALSE to TRUE, and let the "collapse-lovers" set it to FALSE?

Comment 19

[[e-mail]]

(In reply to comment #18)
>Devil's Advocate: So if someone were to actually *want* the newsfolders to
>collapse on restart, could they no longer do that?
Nobody's complained that they can't make mail folders collapse on restart.
Also, the pref was only introduced because expanding the servers caused biff.

Comment 20

[Magnus Melin [:mkmelin]]

Guess this was forgot about for tb2...

Comment 21

[Alessio]

After upgrading from Seamonkey 2.8 to 2.9 (and 2.9.1 too) the same bug appeared again, this time for the mail accounts.