1694546 - [linux] Bookmarks toolbar looks like it is one with other toolbars, but bookmarks toolbar is not draggable, unlike other toolbars

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect, P3)

Description

[Karl Tomlinson (:karlt)]

I'd guess the bookmarks toolbar is somehow not included in -moz-window-dragging rules.

Comment 1

[Karl Tomlinson (:karlt)]

The bookmarks toolbar wasn't visible (on new tabs/windows) until bug 1674091 was fixed.

Comment 2

[:Gijs (he/him)]

(In reply to Karl Tomlinson (:karlt) from comment #1)

The bookmarks toolbar wasn't visible (on new tabs/windows) until bug 1674091 was fixed.

But you could trivially make it visible by using the context menu on the main toolbar, or going into Customize Mode...

Comment 3

[:Gijs (he/him)]

It looks like this is because:

https://searchfox.org/mozilla-central/rev/6f8f3d0e9022b6f0405da26ec940a89455416202/toolkit/content/xul.css#195-200

has an ifndef for Gtk. Linux is the only theme that has additional dragging rules (for the navbar, https://searchfox.org/mozilla-central/rev/6f8f3d0e9022b6f0405da26ec940a89455416202/browser/themes/linux/browser.css#266 ), the titlebar is draggable on Linux because of https://searchfox.org/mozilla-central/rev/6f8f3d0e9022b6f0405da26ec940a89455416202/browser/base/content/browser.css#348 . This was originally simplified in bug 1387415.

It seems like if we want the toolbar to be draggable on Linux, we should just remove the linux and browser/base styling, and remove the ifndef in xul.css . Dão, does that seem reasonable?

Comment 4

[Dão Gottwald [:dao]]

(In reply to :Gijs (he/him) from comment #3)

It seems like if we want the toolbar to be draggable on Linux, we should just remove the linux and browser/base styling, and remove the ifndef in xul.css . Dão, does that seem reasonable?

Sounds good to me. The current inconsistency seems to stem from -moz-window-dragging not being implemented for GTK originally. I don't think there's any other reason at this point.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Bug 1393512 is similar

Comment 7

[Graham Perrin]

This bug is for:

• bookmarks toolbar, reportedly not draggable

– bug 1727956 is for:

• Bookmarks toolbar items, which is draggable in some situations.

Was resolution of 1727956, as a duplicate, a misunderstanding?

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Graham Perrin from comment #7)

This bug is for:

• bookmarks toolbar, reportedly not draggable

– bug 1727956 is for:

• Bookmarks toolbar items, which is draggable in some situations.

Was resolution of 1727956, as a duplicate, a misunderstanding?

Sorry, it was a misunderstanding.

Comment 9

[:Gijs (he/him)]

Attachment: Bug 1694546 - fix bookmark toolbar draggability on Linux, r?dao

I came across this again when trying to address bug 1756676 and figured
I would just address this bug immediately per our previous discussion
on the bug.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ace96dd0c98b
fix bookmark toolbar draggability on Linux, r=dao

Comment 11

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/ace96dd0c98b