Closed Bug 1253386 Opened 8 years ago Closed 8 years ago

[e10s] Images glitch in sites that use a popular KenBurns slider with Disabled HWA on Ubuntu

Categories

(Core :: Graphics, defect, P5)

47 Branch
x86
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
e10s + ---
firefox46 --- unaffected
firefox47 --- wontfix
firefox48 --- fixed

People

(Reporter: alice0775, Assigned: eflores)

References

Details

(Keywords: regression, Whiteboard: [gfx-noted])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1252275 Comment 5 +++

Build Identifier:


Reproducible : always

Steps To Reproduce:
1. e10s on + HWA off
2. Open index.html from attachment 8725374 [details]
   (original web page: http://wowslider.com/it/banner-maker-geometric-kenburns-demo.html )


Actual Results:
 Images glitch during animation
 Screencast : https://www.youtube.com/watch?v=2_1tMueQgxQ  (around20,25,34s)

Expected results:
 No glitch

Regression window on ubuntu14.04 (e10s on + HWA off):
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=600942ae9823ae85186cd613b65582078489daa4&tochange=432ef38dab958e325c2e56dd4093be023c221043

Regressed by: Bug 1241832
Summary: [e10s] Images glitch in sites that use a popular KenBurns slider with Disabled HWA → [e10s] Images glitch in sites that use a popular KenBurns slider with Disabled HWA on Ubuntu
Assignee: nobody → edwin
Edwin, let's see if we can help get "no xrender" in a better state.
See Also: → 1252046
Status: NEW → ASSIGNED
This is probably the same bug as 1253995, but bug 1253995 has a nice test case attached!
See Also: → 1253995
Flags: needinfo?(twalker)
This happens to me in a non-e10s window.
tracking-e10s: --- → -
(In reply to Bill McCloskey (:billm) from comment #3)
> This happens to me in a non-e10s window.

I cannot reproduce with "disabled e10s".
I think "non-e10s window" is not equal to "disabled e10s"
Blocks: 1252275
Blocks: e10s-gfx
I can reproduce this reliably Ubuntu 14.04, Nightly 48.0a1, 20160310030242 by mousing hovering around over the images that are being animated/swapped.

I cannot reproduce if HWA is on nor in non-e10s.
Flags: needinfo?(twalker)
Blocks: e10s-perf
Priority: -- → P5
Reposting findings from bug 1252275 here:


I discussed with Edwin, Nical, and Matt regarding what we thought the underlying issue was and the best way to progress with a workaround in the short-term.

The issue seems to be a manifestation of bug 1251257, that we are overwriting the canvas client's buffer while the compositor is using it. This ends up causing tearing.

Matt suspects that we should be fine just to double buffer the canvas client based on the refresh driver synchronization he had implemented here: http://mxr.mozilla.org/mozilla-central/source/layout/base/nsRefreshDriver.cpp#1647

I tested a double-buffering prototype Edwin was working on both under Linux and Windows. I was able to reproduce the issue on both platforms without the patch, and with the patch, the problem was fixed on both platforms.

Arguably we might want to fix this under bug 1251257, or perhaps save bug 1251257 for a long-term solution (if desired and if differs from short-term fix) and go with a short-term fix in this bug.
Depends on: 1251257
See Also: → 1254560
See Also: → 1254318
Attached patch hmmmmmmmSplinter Review
This will work, according to bug 1252275 comment 9.
Attachment #8731372 - Flags: review?(nical.bugzilla)
Attachment #8731372 - Flags: review?(nical.bugzilla) → review+
https://hg.mozilla.org/mozilla-central/rev/705f2b00c129
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
No longer blocks: 1252275
e10s will be disabled on release for 47. It is still enabled in beta 47 for some of the beta population. So I'm marking this as wontfix for 47.
No longer blocks: 1263222
You need to log in before you can comment on or make changes to this bug.