Closed
Bug 1274137
(akita-participants-store)
Opened 9 years ago
Closed 9 years ago
stand up basic ParticipantStore
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dmosedale, Assigned: mancas)
References
Details
(Whiteboard: [akita-alpha])
User Story
As a developer, I can expect participants in a room to be tracked by a ParticipantStore. Acceptance criteria: * ParticipantStore is usable by a view to get the current participants in a room * ParticipantStore is automatically updated whenever Firebase changes
Attachments
(2 files)
Some of this functionality is currently part of ActiveWindowStore, and may need to be factored out of there.
Note that this has a missing dependency on (at least) FirebaseDriver, which doesn't yet have bugs tracking it, AFAIK.
|
||
Comment 1•9 years ago
|
||
This should be done at the same time as Bug 1274168, as the Participant Store can only receive interesting data from Firebase
|
|
||
Updated•9 years ago
|
Rank: 4
Priority: -- → P1
Whiteboard: [akita] [missing dependency] → [akita]
|
||
Comment 2•9 years ago
|
||
ianb added some details of presence data that could be part of the ParticipantsStore in 1274171 comment 1.
The data driver interface might have two methods something like.. updateCurrentParticipant and refreshCurrentPresence.
|
|
||
Updated•9 years ago
|
Whiteboard: [akita] → [akita-alpha]
|
Reporter | |
Updated•9 years ago
|
Blocks: akita-chat-displaynames
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → b.mcb
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 3•9 years ago
|
||
@mancas, could you put up a WIP PR so that those of us who are interested in the API can follow along?
|
|
||
Comment 4•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8757186 -
Flags: feedback?(standard8)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8757186 -
Flags: review?(standard8)
Attachment #8757186 -
Flags: review?(edilee)
Attachment #8757186 -
Flags: review?(dmose)
Attachment #8757186 -
Flags: feedback?(standard8)
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8757186 [details] [review]
[loop] mancas:bug1274137 > mozilla:akita
r=Mardak with some fixes. We need an initial "ping timeout" -> "not considered here" but that'll be easy to change. Let's just say 1 day for now.. ?
Attachment #8757186 -
Flags: review?(standard8)
Attachment #8757186 -
Flags: review?(edilee)
Attachment #8757186 -
Flags: review?(dmose)
Attachment #8757186 -
Flags: review+
|
|
||
Comment 6•9 years ago
|
||
Comment on attachment 8757186 [details] [review]
[loop] mancas:bug1274137 > mozilla:akita
Turns out calculating ping time deltas is slightly tricky!
Attachment #8757186 -
Flags: feedback+
|
|
||
Comment 7•9 years ago
|
||
|
|
||
Comment 8•9 years ago
|
||
Squashed and merged:
https://github.com/mozilla/loop/commit/f3f8fb33a55c2dd482e73587ec80f5212ea410d6
Sorry for the authorship change :( Apparently github's "squash and merge" takes the last commit's author but at least you can see the individual commits that were squashed!
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•