Closed Bug 1303184 Opened 8 years ago Closed 8 years ago

Reduce duplicate files we package and ship

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox51 affected, firefox52 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox51 --- affected
firefox52 --- fixed

People

(Reporter: catlee, Assigned: catlee)

References

(Depends on 3 open bugs, Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1303184 - Add exception list to find-dupes, and error out when unexpected dupes are detected.
58 bytes, text/x-review-board-request
gps
: review+
Details
We run find-dupes.py as part of the packaging process. Right now it spits out a warning, and carries on. Currently we're including about 300kb of duplicate files for win64, and 600kb for osx in release Firefox. Nightly is higher. Sample warning: 15:12:02 INFO - WARNING: Found 52 duplicated files taking 636997 bytes (uncompressed) I suggest we tackle this as follows: 1) Add a whitelist to exempt current duplicates. 2) Change find-dupes.py to error out if new duplicates are found. 3) File bugs in relevant components to reduce their duplicates, and then update the whitelist The goal would be to reduce the number of exceptions to as close to zero as possible.
Note that most of those files should be in omni.ja, so they are compressed, and the reported size is uncompressed. Files not in omni.ja are also further compressed in the installer/tarball.
Sure, but many files are fairly non-compressable. e.g. lots of .gif, .png files. From https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-beta-macosx64/1473712816/mozilla-beta-macosx64-bm84-build1-build94.txt.gz: 15:11:59 INFO - /builds/slave/m-beta-m64-0000000000000000000/build/src/obj-firefox/x86_64/_virtualenv/bin/python /builds/slave/m-beta-m64-0000000000000000000/build/src/toolkit/mozapps/installer/find-dupes.py ../../dist/universal/firefox 15:12:02 INFO - Duplicates 281780 bytes: 15:12:02 INFO - Firefox.app/Contents/Library/LaunchServices/org.mozilla.updater 15:12:02 INFO - Firefox.app/Contents/MacOS/updater.app/Contents/MacOS/org.mozilla.updater 15:12:02 INFO - Duplicates 2705 bytes: 15:12:02 INFO - Firefox.app/Contents/MacOS/crashreporter.app/Contents/Resources/English.lproj/MainMenu.nib/classes.nib 15:12:02 INFO - Firefox.app/Contents/MacOS/crashreporter.app/Contents/Resources/English.lproj/MainMenuRTL.nib/classes.nib 15:12:02 INFO - Duplicates 62552 bytes: 15:12:02 INFO - Firefox.app/Contents/MacOS/firefox 15:12:02 INFO - Firefox.app/Contents/MacOS/firefox-bin 15:12:02 INFO - Duplicates 8 bytes: 15:12:02 INFO - Firefox.app/Contents/MacOS/plugin-container.app/Contents/PkgInfo 15:12:02 INFO - Firefox.app/Contents/MacOS/updater.app/Contents/PkgInfo 15:12:02 INFO - Duplicates 2084 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/icon.png 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/browser/skin/classic/browser/theme-switcher-icon.png 15:12:02 INFO - Duplicates 1377 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/features/firefox@getpocket.com/chrome/skin/linux/menuPanel.png 15:12:02 INFO - Firefox.app/Contents/Resources/browser/features/firefox@getpocket.com/chrome/skin/windows/menuPanel.png 15:12:02 INFO - Duplicates 2671 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/features/firefox@getpocket.com/chrome/skin/linux/menuPanel@2x.png 15:12:02 INFO - Firefox.app/Contents/Resources/browser/features/firefox@getpocket.com/chrome/skin/windows/menuPanel@2x.png 15:12:02 INFO - Duplicates 1111 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/modules/devtools/client/framework/gDevTools.jsm 15:12:02 INFO - Firefox.app/Contents/Resources/browser/modules/devtools/gDevTools.jsm 15:12:02 INFO - Duplicates 9760 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/browser/content/browser/defaultthemes/5.footer.png 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/browser/content/browser/defaultthemes/5.header.png 15:12:02 INFO - Duplicates 1397 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/browser/content/browser/extension.svg 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/browser/skin/classic/browser/addons/addon-install-confirm.svg 15:12:02 INFO - Duplicates 1766 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/browser/content/browser/places/bookmarkProperties.xul 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/browser/content/browser/places/bookmarkProperties2.xul 15:12:02 INFO - Duplicates 805 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/browser/skin/classic/browser/controlcenter/warning-gray.svg 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/skin/images/security-state-broken.svg 15:12:02 INFO - Duplicates 1695 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/browser/skin/classic/browser/identity-mixed-active-loaded.svg 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/skin/images/security-state-insecure.svg 15:12:02 INFO - Duplicates 1656 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/browser/skin/classic/browser/identity-mixed-passive-loaded.svg 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/skin/images/security-state-weak.svg 15:12:02 INFO - Duplicates 62639 bytes (2 times): 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/browser/skin/classic/browser/identity-not-secure.svg 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/skin/images/security-state-local.svg 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/skin/images/tabs-icon.svg 15:12:02 INFO - Duplicates 1121 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/browser/skin/classic/browser/identity-secure.svg 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/skin/images/security-state-secure.svg 15:12:02 INFO - Duplicates 199 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/pdfjs/content/web/images/findbarButton-next-rtl.png 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/pdfjs/content/web/images/findbarButton-previous.png 15:12:02 INFO - Duplicates 304 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/pdfjs/content/web/images/findbarButton-next-rtl@2x.png 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/pdfjs/content/web/images/findbarButton-previous@2x.png 15:12:02 INFO - Duplicates 193 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/pdfjs/content/web/images/findbarButton-next.png 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/pdfjs/content/web/images/findbarButton-previous-rtl.png 15:12:02 INFO - Duplicates 296 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/pdfjs/content/web/images/findbarButton-next@2x.png 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/pdfjs/content/web/images/findbarButton-previous-rtl@2x.png 15:12:02 INFO - Duplicates 7402 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/pdfjs/content/web/images/loading-small.png 15:12:02 INFO - Firefox.app/Contents/Resources/chrome/toolkit/skin/classic/global/icons/loading-inverted.png 15:12:02 INFO - Duplicates 16131 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/pdfjs/content/web/images/loading-small@2x.png 15:12:02 INFO - Firefox.app/Contents/Resources/chrome/toolkit/skin/classic/global/icons/loading-inverted@2x.png 15:12:02 INFO - Duplicates 2217 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/content/dom/content/dom-view.css 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/modules/devtools/client/dom/content/dom-view.css 15:12:02 INFO - Duplicates 979 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/content/dom/dom.html 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/modules/devtools/client/dom/dom.html 15:12:02 INFO - Duplicates 940 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/content/dom/main.js 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/modules/devtools/client/dom/main.js 15:12:02 INFO - Duplicates 14218 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/content/framework/toolbox-options.js 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/modules/devtools/client/framework/toolbox-options.js 15:12:02 INFO - Duplicates 6915 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/content/inspector/fonts/fonts.js 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/modules/devtools/client/inspector/fonts/fonts.js 15:12:02 INFO - Duplicates 25684 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/content/inspector/layout/layout.js 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/modules/devtools/client/inspector/layout/layout.js 15:12:02 INFO - Duplicates 2330 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/content/memory/initializer.js 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/modules/devtools/client/memory/initializer.js 15:12:02 INFO - Duplicates 2201 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/content/projecteditor/lib/helpers/readdir.js 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/modules/devtools/client/projecteditor/lib/helpers/readdir.js 15:12:02 INFO - Duplicates 6538 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/content/shared/frame-script-utils.js 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/modules/devtools/client/shared/frame-script-utils.js 15:12:02 INFO - Duplicates 6071 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/content/shared/theme-switching.js 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/modules/devtools/client/shared/theme-switching.js 15:12:02 INFO - Duplicates 1719 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/modules/devtools/client/dom/content/components/search.svg 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/modules/devtools/client/jsonview/css/search.svg 15:12:02 INFO - Duplicates 1630 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/modules/devtools/client/jsonview/css/controls.png 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/skin/images/controls.png 15:12:02 INFO - Duplicates 2045 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/modules/devtools/client/jsonview/css/controls@2x.png 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/skin/images/controls@2x.png 15:12:02 INFO - Duplicates 9357 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/modules/devtools/client/themes/common.css 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/skin/common.css 15:12:02 INFO - Duplicates 7372 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/modules/devtools/client/themes/variables.css 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/skin/variables.css 15:12:02 INFO - Duplicates 205 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/skin/promisedebugger.css 15:12:02 INFO - Firefox.app/Contents/Resources/modules/commonjs/index.js 15:12:02 INFO - Duplicates 359 bytes (2 times): 15:12:02 INFO - Firefox.app/Contents/Resources/chrome/en-US/locale/en-US/global-platform/mac/intl.properties 15:12:02 INFO - Firefox.app/Contents/Resources/chrome/en-US/locale/en-US/global-platform/unix/intl.properties 15:12:02 INFO - Firefox.app/Contents/Resources/chrome/en-US/locale/en-US/global-platform/win/intl.properties 15:12:02 INFO - Duplicates 495 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/chrome/en-US/locale/en-US/global-platform/unix/accessible.properties 15:12:02 INFO - Firefox.app/Contents/Resources/chrome/en-US/locale/en-US/global-platform/win/accessible.properties 15:12:02 INFO - Duplicates 6057 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/components/FxAccountsPush.js 15:12:02 INFO - Firefox.app/Contents/Resources/modules/FxAccountsPush.js 15:12:02 INFO - Duplicates 405 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/modules/commonjs/sdk/ui/button/view/events.js 15:12:02 INFO - Firefox.app/Contents/Resources/modules/commonjs/sdk/ui/state/events.js 15:12:02 INFO - Duplicates 1069 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/modules/devtools/Console.jsm 15:12:02 INFO - Firefox.app/Contents/Resources/modules/devtools/shared/Console.jsm 15:12:02 INFO - Duplicates 1125 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/modules/devtools/Loader.jsm 15:12:02 INFO - Firefox.app/Contents/Resources/modules/devtools/shared/Loader.jsm 15:12:02 INFO - Duplicates 1080 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/modules/devtools/Simulator.jsm 15:12:02 INFO - Firefox.app/Contents/Resources/modules/devtools/shared/apps/Simulator.jsm 15:12:02 INFO - Duplicates 5940 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/chrome/toolkit/skin/classic/global/icons/tabprompts-bgtexture.png 15:12:02 INFO - Firefox.app/Contents/Resources/chrome/toolkit/skin/classic/global/media/clicktoplay-bgtexture.png 15:12:02 INFO - Duplicates 2288 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/chrome/toolkit/skin/classic/mozapps/downloads/buttons.png 15:12:02 INFO - Firefox.app/Contents/Resources/chrome/toolkit/skin/classic/mozapps/update/buttons.png 15:12:02 INFO - Duplicates 1769 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/chrome/toolkit/skin/classic/mozapps/extensions/category-dictionaries.png 15:12:02 INFO - Firefox.app/Contents/Resources/chrome/toolkit/skin/classic/mozapps/extensions/dictionaryGeneric.png 15:12:02 INFO - Duplicates 822 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/chrome/toolkit/skin/classic/mozapps/extensions/category-experiments.png 15:12:02 INFO - Firefox.app/Contents/Resources/chrome/toolkit/skin/classic/mozapps/extensions/experimentGeneric.png 15:12:02 INFO - Duplicates 835 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/res/table-remove-column-active.gif 15:12:02 INFO - Firefox.app/Contents/Resources/res/table-remove-row-active.gif 15:12:02 INFO - Duplicates 841 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/res/table-remove-column-hover.gif 15:12:02 INFO - Firefox.app/Contents/Resources/res/table-remove-row-hover.gif 15:12:02 INFO - Duplicates 841 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/res/table-remove-column.gif 15:12:02 INFO - Firefox.app/Contents/Resources/res/table-remove-row.gif 15:12:02 INFO - WARNING: Found 52 duplicated files taking 636997 bytes (uncompressed)
While the reported size makes things sound worse than they are, bloat is bloat. I agree with catlee's suggestions of establishing a list of expected failures, changing find-dupes to error if that doesn't match reality, then have bugs on file to get us to 0 dupes.
Top 6, sorted by size: 15:12:02 INFO - Duplicates 281780 bytes: 15:12:02 INFO - Firefox.app/Contents/Library/LaunchServices/org.mozilla.updater 15:12:02 INFO - Firefox.app/Contents/MacOS/updater.app/Contents/MacOS/org.mozilla.updater 15:12:02 INFO - Duplicates 62639 bytes (2 times): 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/browser/skin/classic/browser/identity-not-secure.svg 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/skin/images/security-state-local.svg 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/skin/images/tabs-icon.svg 15:12:02 INFO - Duplicates 62552 bytes: 15:12:02 INFO - Firefox.app/Contents/MacOS/firefox 15:12:02 INFO - Firefox.app/Contents/MacOS/firefox-bin 15:12:02 INFO - Duplicates 25684 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/content/inspector/layout/layout.js 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/modules/devtools/client/inspector/layout/layout.js 15:12:02 INFO - Duplicates 16131 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/pdfjs/content/web/images/loading-small@2x.png 15:12:02 INFO - Firefox.app/Contents/Resources/chrome/toolkit/skin/classic/global/icons/loading-inverted@2x.png 15:12:02 INFO - Duplicates 14218 bytes: 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/content/framework/toolbox-options.js 15:12:02 INFO - Firefox.app/Contents/Resources/browser/chrome/devtools/modules/devtools/client/framework/toolbox-options.js That makes a total of 525643 bytes, which is 82% of the overall reported duplicates. 2 are outside omni.ja (there's an open bug for firefox-bin already), and 3 of the 4 remaining are not PNG or GIF.
FWIW, on the linux build for 48.0: WARNING: Found 57 duplicated files taking 270224 bytes (uncompressed), 144841 bytes (compressed) (locally modified the script to output compressed size, doesn't require much changes, will file a separate bug ; sorting the output would be useful too)
Depends on: 1303210
Depends on: 1311178
Depends on: 658850
Depends on: 1311194
Attachment #8803035 - Flags: feedback?(gps)
Comment on attachment 8803035 [details] Bug 1303184 - Add exception list to find-dupes, and error out when unexpected dupes are detected. https://reviewboard.mozilla.org/r/87274/#review86758 This is awesome. Fix the bustage detected on Try and this should be good to land! ::: toolkit/mozapps/installer/find-dupes.py:16 (Diff revision 1) > +# Known duplicate files > +# This list is ideally empty, but some existing files will be grandfathered in > +# See bug 1303184 > +ALLOWED_DUPES = set([ I think you should have an UPPERCASE WARNING discouraging people from adding new entries. Also, bonus points if we get bugs on file for the dupe list in each component and link those inline.
Attachment #8803035 - Flags: feedback?(gps) → feedback+
Depends on: 1313106
Depends on: 1313107
Comment on attachment 8803035 [details] Bug 1303184 - Add exception list to find-dupes, and error out when unexpected dupes are detected. https://reviewboard.mozilla.org/r/87274/#review87846 ::: toolkit/mozapps/installer/find-dupes.py:292 (Diff revision 3) > else 'uncompressed') > > + if unexpected_dupes: > + print "ERROR: The following duplicated files are not allowed:" > + print "\n".join(unexpected_dupes) > + exit(1) This should be `sys.exit`. I'll fix this and push for you.
Attachment #8803035 - Flags: review?(gps) → review+
Pushed by gszorc@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/532415dbd620 Add exception list to find-dupes, and error out when unexpected dupes are detected; r=gps
https://hg.mozilla.org/mozilla-central/rev/532415dbd620
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
This breaks now comm-central. What can we do to add our files to the dupes list until they are cleaned? Is there a possibility to expand the ALLOWED_DUPES list in c-c to not need to edit the m-c file?
Flags: needinfo?(catlee)
Yeah, a separate list for c-c ALLOWED_DUPES sounds like a good idea. How would find-dupes.py know it's being used for a c-c build or not?
Flags: needinfo?(catlee)
(In reply to Chris AtLee [:catlee] from comment #16) > Yeah, a separate list for c-c ALLOWED_DUPES sounds like a good idea. How > would find-dupes.py know it's being used for a c-c build or not? Aleth, you are now our build specialist. Do you know the answer?
Flags: needinfo?(aleth)
(In reply to Richard Marti (:Paenglab) from comment #17) > (In reply to Chris AtLee [:catlee] from comment #16) > > Yeah, a separate list for c-c ALLOWED_DUPES sounds like a good idea. How > > would find-dupes.py know it's being used for a c-c build or not? > > Aleth, you are now our build specialist. Do you know the answer? I don't know what would be the most convenient in this context, but one way would be to check if MOZILLA_SRCDIR is set: http://searchfox.org/mozilla-central/source/config/baseconfig.mk#52
Flags: needinfo?(aleth)
Also, what is considered a duplicate file here? Are only filenames compared or really bit-for-bit identical files?
Identical content.
Blocks: 1313640
(In reply to aleth [:aleth] from comment #18) > (In reply to Richard Marti (:Paenglab) from comment #17) > > (In reply to Chris AtLee [:catlee] from comment #16) > > > Yeah, a separate list for c-c ALLOWED_DUPES sounds like a good idea. How > > > would find-dupes.py know it's being used for a c-c build or not? Actually, is c-c vs m-c really the right distinction to be making here? Naively I would have expected the duplicate list to differ by appname (e.g Firefox, Fennec, Thunderbird, Seamonkey,...), in which case it would make more sense to read ALLOWED_DUPES from a file in the app directory.
Should we move this discussion to a new bug? Looking at a log, these are the "offending" files for Thunderbird (see below), 230KB in total. For that amount of saving it is certainly not worth jeopardising a major release. It's really hard to believe that something like this with a Firefox-only approach got landed without consideration or heads-up for other projects, especially not 10 days before an ESR branch day. Can we back this out until an integrated approach has been implemented? Or at least not stop the build on so-called "unexpected" (since non-Firefox) duplicates? === Duplicates 260 bytes: extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/linux/lightning/imip.css extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/windows/lightning/imip.css Duplicates 290 bytes: extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/linux/calendar/calendar-invitations-dialog.css extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/windows/calendar/calendar-invitations-dialog.css Duplicates 359 bytes (2 times): chrome/en-US/locale/en-US/global-platform/mac/intl.properties chrome/en-US/locale/en-US/global-platform/unix/intl.properties chrome/en-US/locale/en-US/global-platform/win/intl.properties Duplicates 361 bytes: extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/linux/lightning/lightning-widgets.css extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/windows/lightning/lightning-widgets.css Duplicates 405 bytes: modules/commonjs/sdk/ui/button/view/events.js modules/commonjs/sdk/ui/state/events.js Duplicates 440 bytes: extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/linux/lightning/accountCentral.css extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/windows/lightning/accountCentral.css Duplicates 495 bytes: chrome/en-US/locale/en-US/global-platform/unix/accessible.properties chrome/en-US/locale/en-US/global-platform/win/accessible.properties Duplicates 505 bytes: extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/linux/calendar/calendar-daypicker.css extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/windows/calendar/calendar-daypicker.css Duplicates 546 bytes: chrome/classic/skin/classic/messenger/icons/flag-col.png chrome/classic/skin/classic/messenger/icons/flag.png Duplicates 588 bytes: chrome/classic/skin/classic/messenger/icons/flag-XP.png chrome/classic/skin/classic/messenger/icons/flag-col-XP.png Duplicates 597 bytes: extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/linux/calendar/calendar-alarm-dialog.css extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/windows/calendar/calendar-alarm-dialog.css Duplicates 658 bytes: extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/linux/calendar/checkbox-images.png extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/windows/calendar/checkbox-images.png Duplicates 679 bytes (2 times): chrome/messenger/skin/classic/messenger/messages/Incoming/buddy_icon.png chrome/messenger/skin/classic/messenger/messages/Outgoing/buddy_icon.png chrome/classic/skin/classic/messenger/userIcon.png Duplicates 756 bytes (2 times): extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/linux/calendar/calendar-invitations-dialog-button-images.png extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/osx/calendar/calendar-invitations-dialog-button-images.png extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/windows/calendar/calendar-invitations-dialog-button-images.png Duplicates 772 bytes: extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/linux/calendar/calendar-management.css extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/windows/calendar/calendar-management.css Duplicates 775 bytes: extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/linux/calendar/calendar-event-dialog.png extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/windows/calendar/calendar-event-dialog.png Duplicates 835 bytes: res/table-remove-column-active.gif res/table-remove-row-active.gif Duplicates 841 bytes: res/table-remove-column-hover.gif res/table-remove-row-hover.gif Duplicates 841 bytes: res/table-remove-column.gif res/table-remove-row.gif Duplicates 953 bytes: extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/osx/calendar/cal-icon24.png extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/osx/calendar/cal-icon32.png Duplicates 1069 bytes: modules/devtools/Console.jsm modules/devtools/shared/Console.jsm Duplicates 1072 bytes: chrome/chat/skin/classic/chat/icons/insecure.png chrome/classic/skin/classic/messenger/icons/insecure.png Duplicates 1080 bytes: modules/devtools/Simulator.jsm modules/devtools/shared/apps/Simulator.jsm Duplicates 1111 bytes: chrome/chat/skin/classic/chat/icons/secure.png chrome/classic/skin/classic/messenger/icons/secure.png Duplicates 1111 bytes: modules/devtools/client/framework/gDevTools.jsm modules/devtools/gDevTools.jsm Duplicates 1125 bytes: modules/devtools/Loader.jsm modules/devtools/shared/Loader.jsm Duplicates 1203 bytes: chrome/classic/skin/classic/messenger/activity/defaultEventIcon-XP.png chrome/classic/skin/classic/messenger/activity/defaultEventIcon.png Duplicates 1250 bytes: extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/linux/calendar/calendar-task-dialog.png extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/windows/calendar/calendar-task-dialog.png Duplicates 1623 bytes: chrome/toolkit/skin/classic/global/icons/Warning.png chrome/classic/skin/classic/messenger/activity/defaultWarningIcon.png Duplicates 1683 bytes: chrome/messenger/content/messenger/cloudfile/Box/management.js chrome/messenger/content/messenger/cloudfile/Hightail/management.js Duplicates 1842 bytes: extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/linux/lightning/imip.png extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/windows/lightning/imip.png Duplicates 2150 bytes (2 times): extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/linux/calendar/calendar-invitations-dialog-list-images.png extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/osx/calendar/calendar-invitations-dialog-list-images.png extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/windows/calendar/calendar-invitations-dialog-list-images.png Duplicates 2571 bytes: extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/linux/calendar/calendar-occurrence-prompt.png extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/windows/calendar/calendar-occurrence-prompt.png Duplicates 3243 bytes: chrome/toolkit/skin/classic/mozapps/downloads/downloadButtons-XP.png chrome/toolkit/skin/classic/mozapps/update/downloadButtons-XP.png Duplicates 4390 bytes (2 times): extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/linux/calendar/ok-cancel.png extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/osx/calendar/ok-cancel.png extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/windows/calendar/ok-cancel.png Duplicates 4404 bytes: chrome/messenger/content/branding/icon48.png chrome/classic/skin/classic/messenger/icons/new-mail-alert.png Duplicates 5148 bytes: chrome/toolkit/skin/classic/mozapps/downloads/downloadButtons.png chrome/toolkit/skin/classic/mozapps/update/downloadButtons.png Duplicates 6886 bytes: extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/icons/default/calendar-event-dialog.ico extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/icons/default/calendar-event-summary-dialog.ico Duplicates 6886 bytes: extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/icons/default/calendar-task-dialog.ico extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/icons/default/calendar-task-summary-dialog.ico Duplicates 8696 bytes (2 times): extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/linux/calendar/calendar-event-dialog-attendees.png extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/osx/calendar/calendar-event-dialog-attendees.png extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/skin/windows/calendar/calendar-event-dialog-attendees.png Duplicates 37430 bytes: extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/calendar-js/calFilter.js extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/calendar/content/calendar/calFilter.js Duplicates 40165 bytes: chrome/toolkit/skin/classic/global/icons/loading@2x.png chrome/classic/skin/classic/messenger/icons/loading@2x.png Duplicates 66537 bytes: extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/calendar-js/calUtils.js extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome/calendar/content/calendar/calUtils.js WARNING: Found 43 duplicated files taking 231661 bytes (uncompressed)
Flags: needinfo?(catlee)
Blocks: 1313670
Filed bug 1313670 for the comm-central issue. Let's move the discussion there.
Flags: needinfo?(catlee)
Depends on: 1314023
Blocks: 1315309
Assignee: nobody → catlee
Product: Core → Firefox Build System
Depends on: 1451016
Depends on: 1518445
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: