Support the av1 video codec

NEW
Assigned to

Status

()

Core
Audio/Video: Playback
P3
normal
6 months ago
4 days ago

People

(Reporter: rillian, Assigned: rillian)

Tracking

(Depends on: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(13 attachments)

59 bytes, text/x-review-board-request
Details | Review
59 bytes, text/x-review-board-request
Details | Review
59 bytes, text/x-review-board-request
Details | Review
59 bytes, text/x-review-board-request
Details | Review
59 bytes, text/x-review-board-request
Details | Review
59 bytes, text/x-review-board-request
Details | Review
59 bytes, text/x-review-board-request
Details | Review
59 bytes, text/x-review-board-request
Details | Review
59 bytes, text/x-review-board-request
Details | Review
59 bytes, text/x-review-board-request
Details | Review
59 bytes, text/x-review-board-request
Details | Review
59 bytes, text/x-review-board-request
Details | Review
59 bytes, text/x-review-board-request
Details | Review
(Assignee)

Description

6 months ago
Tracking bug for supporting the Alliance for Open Media's av1 codec.

https://aomedia.googlesource.com/aom/
http://aomedia.org/
(Assignee)

Updated

6 months ago
Assignee: nobody → giles
Priority: -- → P3
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
See Also: → bug 1332136
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 18

7 days ago
FYI: --enable-av1 builds fine on FreeBSD 12 (Clang 4.0 or GCC 6.3).
That's great to hear. Thanks for testing so quickly!
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 28

5 days ago
mozreview-review
Comment on attachment 8857713 [details]
Bug 1314147 - Port the libvpx mozbuild generator to libav1.

https://reviewboard.mozilla.org/r/129644/#review134722

::: media/libaom/moz.build:12
(Diff revision 4)
> +with Files('*'):
> +    BUG_COMPONENT = ('Core', 'Audio/Video')
> +
> +include('sources.mozbuild')
> +
> +if CONFIG['VPX_USE_YASM']:

`VPX_USE_YASM` isn't defined for `--with-system-libvpx`. Maybe replace with `HAVE_YASM` + `INTEL_ARCHITECTURE` or adjust old-configure.in while keeping in mind `--with-system-aom` maybe added in future.

```
/usr/bin/clang -std=gnu99 -o aom_convolve_copy_sse2.o -fPIC -Wa,--noexecstack -include objdir/mozilla-config.h -DMOZILLA_CLIENT  -Imedia/libaom/config/linux/x64/ -I. -Ithird_party/aom  -c third_party/aom/aom_dsp/x86/aom_convolve_copy_sse2.asm
clang: warning: argument unused during compilation: '-std=gnu99' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-include objdir/mozilla-config.h' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-D MOZILLA_CLIENT' [-Wunused-command-line-argument]
third_party/aom/aom_dsp/x86/aom_convolve_copy_sse2.asm:2:17: error: unexpected token in argument list
; Copyright (c) 2016, Alliance for Open Media. All rights reserved
                ^
third_party/aom/aom_dsp/x86/aom_convolve_copy_sse2.asm:4:15: error: unexpected token in argument list
; This source code is subject to the terms of the BSD 2 Clause License and
              ^
[...]
```
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
With this patch set, I can play back https://people-mozilla.org/~rgiles/2017/rush_hour_444.av1.webm although the aspect ratio is wrong.

Another file crashes with a simd alignment assert: https://people-mozilla.org/~rgiles/2017/sintel_trailer_2k_480p24.av1.webm

Still, a happy milestone.
(Assignee)

Updated

4 days ago
Depends on: 1358662
You need to log in before you can comment on or make changes to this bug.