1314491 - Kongregate's Flash game doesn't load with Flash protected mode disabled and plugin asyncdrawing enabled

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[kalviskajaks]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20161019084923

Steps to reproduce:

1) Go to http://www.kongregate.com/games/ConArtists/the-last-stand-dead-zone
2) Log in and make sure game loads fine
3) Turn off Flash protected mode(restart to be sure the change sticks)
4)Open http://www.kongregate.com/games/ConArtists/the-last-stand-dead-zone again


Actual results:

Game does not load. Tried with new profile in both release 49 and nightly 52.


Expected results:

Game should load without problems.

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Looks like a plugin issue, not the Firefox.

Comment 2

[Loic]

You should report the issue to Adobe.

Comment 3

[kalviskajaks]

Ok here it is
https://bugbase.adobe.com/index.cfm?event=bug&id=4197247

Comment 4

[Loic]

Ok, I'm able to reproduce the issue in this situation:
1) Flash protected mode disabled
2) plugin asyncdrawing enabled (dom.ipc.plugins.asyncdrawing.enabled=true)

Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=02c69f4f896255189ce2f9f4e0d875e383bcfbd7&tochange=a1bd47d76f71162534090485acc57866dcd55eef

Same issue with FF49 or 52.

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

Async plugin drawing is still nightly only, but I will leave this as affecting 52 in case we decide to uplift.

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

Jim, any idea how we should proceed?  Is disabling the protected mode something we want to support with async drawing?

Comment 7

[Jim Mathies [:jimm]]

This is async painting related.

Comment 8

[Jim Mathies [:jimm]]

http://www.kongregate.com/games/GaiaByte/cosmos-quest
http://www.kongregate.com/games/SoulGame/swords-and-souls
http://www.kongregate.com/games/Ninjakiwi/bloons-td-5
http://www.kongregate.com/games/tensquaregames/lets-hunt (webgl)

^ all play fine with protected mode off

Not having a lot of issues here, although the original game listed in comment 1 is almost impossible to get into to test.

Comment 9

[kalviskajaks]

Ok. Just tested and the 4 games you tried indeed work fine. The original one at 
http://www.kongregate.com/games/ConArtists/the-last-stand-dead-zone 
is still broken with protected mode off and dom.ipc.plugins.asyncdrawing.enabled=true

Why do you mean by impossible to get into? If you are seeing a black screen with a spinner and the text "Connecting to Kongregate..." Than you have actually reproduced the bug.

Comment 10

[Jim Mathies [:jimm]]

(In reply to kalviskajaks from comment #9)
> Ok. Just tested and the 4 games you tried indeed work fine. The original one
> at 
> http://www.kongregate.com/games/ConArtists/the-last-stand-dead-zone 
> is still broken with protected mode off and
> dom.ipc.plugins.asyncdrawing.enabled=true
> 
> Why do you mean by impossible to get into? If you are seeing a black screen
> with a spinner and the text "Connecting to Kongregate..." Than you have
> actually reproduced the bug.

On this game I get stuck at "Connecting to Kongregate..." with async drawing enabled and disabled though.

Comment 11

[Jim Mathies [:jimm]]

Also interesting to note that this dead zone game requests direct wmode rendering, which isn't windowed based.

Comment 12

[Jim Mathies [:jimm]]

Ok, turns out this is is similar to bug 1323403.

Kongregate has a small subset of games that use wmode=direct rendering. These applets normally get windowed mode for this. However through the new async drawing feature these apps get converted over to windowless by flash. There's a quirk with windowed mode plugins such that even if the underlying content is collapsed flash will still display. This is because the child window associated with windowed mode consumes space even if the div or other element container is collapsed.

In Kongragate markup we have:

<div id="game_wrapper" style="height: 0px;">
 <object type="application/x-shockwave-flash" id="deadzonegame" name="deadzonegame" data="http://r.playerio.com/r/dev-the-last-stand-iret8ormbeshajyk6woewg/game/preloader.swf" width="100%" height="100%">
 ..
 </object>
</div>

They set the height on this div to 0, which prevents the flash applet from loading. If I modify that vis inspector the game loading screen shows up.

Comment 13

[Jim Mathies [:jimm]]

Karl, I've got another popular flash site here similar to bug 1323403. According to the forums Kongregate has a large number of firefox users on it, so presumably they'll be open to testing and addressing this in their html.

Comment 14

[Benjamin Smedberg]

Do they serve the same markup to mac users? Mac has never had windowed mode.

We could apply hacks to this site using the site compatibility addon, if we think this is a limited problem.

Comment 15

[Jim Mathies [:jimm]]

(In reply to Benjamin Smedberg [:bsmedberg] from comment #14)
> Do they serve the same markup to mac users? Mac has never had windowed mode.
> 
> We could apply hacks to this site using the site compatibility addon, if we
> think this is a limited problem.

Generally looks about the same. Looking at the markup I see the game_wrapper div with a height of 100%, vs 0px on windows. That migth have changed dynamically though during the game load, which completes on mac.

Comment 16

[Jim Mathies [:jimm]]

Taking this bug back to search for a local fix.

Comment 17

[Jim Mathies [:jimm]]

Attachment: screen

Comment 18

[Jim Mathies [:jimm]]

Comment on attachment 8853399 [details]
screen

wrong bug

Comment 19

[Jim Mathies [:jimm]]

The part of this bug tied to async drawing technically is a dupe of bug 1348629. The remainder is general plugin bug 1352395.

The bit about Flash games not working with protected mode off needs investigating still. I tested against non-stage 3d games on kongragate and experienced no issues.

Comment 20

[Jim Mathies [:jimm]]

(In reply to Jim Mathies [:jimm] from comment #19)
> The part of this bug tied to async drawing technically is a dupe of bug
> 1348629. The remainder is general plugin bug 1352395.
> 
> The bit about Flash games not working with protected mode off needs
> investigating still. I tested against non-stage 3d games on kongragate and
> experienced no issues.

Just tested with flash protected mode off, async drawing on and off, both 64 and 32 bit builds, the game fails to load. So this doesn't appear to be async drawing related.

Comment 21

[Jim Mathies [:jimm]]

(In reply to Jim Mathies [:jimm] from comment #20)
> (In reply to Jim Mathies [:jimm] from comment #19)
> > The part of this bug tied to async drawing technically is a dupe of bug
> > 1348629. The remainder is general plugin bug 1352395.
> > 
> > The bit about Flash games not working with protected mode off needs
> > investigating still. I tested against non-stage 3d games on kongragate and
> > experienced no issues.
> 
> Just tested with flash protected mode off, async drawing on and off, both 64
> and 32 bit builds, the game fails to load. So this doesn't appear to be
> async drawing related.

Filed bug 1353768.

Comment 22

[kalviskajaks]

Just tested with the newest beta flash version, and can confirm that the game loads fine now.

Comment 23

[Chris Peterson [:cpeterson]]

(In reply to kalviskajaks from comment #22)
> Just tested with the newest beta flash version, and can confirm that the
> game loads fine now.

Thanks for testing, kalviskajaks! Adobe fixed this bug in Flash (bug 1348629).

Comment 24

[manavmathur1]

I am unable to load games from http://www.virteract.com/
Please help!