Mark SimplePrograms that require xul as GeckSimplePrograms in xpcom/moz.build

RESOLVED FIXED in Firefox 52

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: erahm, Assigned: erahm)

Tracking

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(2 attachments)

There are several test programs that are listed as SimplePrograms but actually need xul. We should update their declarations as they've started causing build failures after the final GeckoCppUnitTest removals (see bug 1313485, comment 18).

Most of these could also be gtests, but lets get things building before we cross that bridge.

This includes:
    'nsIFileEnumerator'
    'TestCallTemplates',
    'TestINIParser',
    'TestRacingServiceManager',
    'TestRegistrationOrder',
    'TestThreadPoolListener',
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Attachment #8808845 - Flags: review?(nfroyd) → review+
Please don't do this. We should remove this/stop building them completely, since you won't be *able* to link against xul anyway.
Comment on attachment 8809043 [details]
Bug 1316184 - remove the "simple programs" from xpcom/tests that aren't actually being run in automation anywhere,

https://reviewboard.mozilla.org/r/91710/#review91630

Several of these are used in a nsIProcess xpcshell test, some are run via make check, some are intended to cause failure due to compilation warnings, some can be converted to gtests.
Attachment #8809043 - Flags: review?(erahm) → review-
(In reply to Benjamin Smedberg [:bsmedberg] from comment #2)
> Please don't do this. We should remove this/stop building them completely,
> since you won't be *able* to link against xul anyway.

This is temporary so I can land previous gtest conversions, see bug 1315830, bug 1316189, bug 1316191, bug 1316193, bug 1316194, bug 1316195 for follow-ups.
Comment on attachment 8809043 [details]
Bug 1316184 - remove the "simple programs" from xpcom/tests that aren't actually being run in automation anywhere,

https://reviewboard.mozilla.org/r/91710/#review91640

I'll defer to Eric here.  It doesn't seem useful to sweep all of this away; surely we can take some of it for gtests, etc. and remove only the pieces that are too busted to be saved.
Attachment #8809043 - Flags: review?(nfroyd)
https://hg.mozilla.org/integration/mozilla-inbound/rev/058b48a72e502bc73e1a85d5a0f2a197ed6a5c61
Bug 1316184 - Make SimplePrograms that need XUL GeckoSimplePrograms. r=froydnj
Does the list in comment 5 cover everything? I'm trying to get the full XPCOM API removal reviewed and landed by Monday.
Flags: needinfo?(erahm)
(In reply to Benjamin Smedberg [:bsmedberg] from comment #8)
> Does the list in comment 5 cover everything? I'm trying to get the full
> XPCOM API removal reviewed and landed by Monday.

Yes, or at least that's my intent. I can push reviews to you if you'd like so that we can get this done quickly.
Flags: needinfo?(erahm)
If that would help, go ahead.
https://hg.mozilla.org/mozilla-central/rev/058b48a72e50
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.