Closed Bug 1322120 Opened 6 years ago Closed 6 years ago

Address bar items and select items are not highlighted properly


(Core :: Widget: Gtk, defect, P1)




Tracking Status
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 + verified


(Reporter: mstanke, Assigned: karlt)



(Keywords: regression, Whiteboard: [nightly-community][tpi:+])


(3 files)

This bug started to appear about a week ago in Nightly (works in latest release). My current configuration: Linux Mint 18, Cinnamon 3.0.7, Firefox 53.0a1 (20161204030210).

When I hover any item in the address bar (with mouse cursor or arrow keys), or I select anything in the classification/product/component/... select on, the highlight style is not applied, or is not applied correctly. Seems the font color changes, but the "line" background is colored the same as non selected items.
Whiteboard: [nightly-community]
Can you please find a regression window with mozregression? ( )
Flags: needinfo?(mstanke)
Component: Theme → Untriaged
Product: Firefox → Core
Hi :Gijs.

I ended up with

> Error: Unable to exploit the merge commit. Origin branch is mozilla-central, and the commit message for 8f1e4206 was:
> Merge m-c to autoland on a CLOSED TREE. a=merge

Using mozregression I tested these builds:
- 2016-11-30 (13736e2db6eb94b02dd28cc88f2943b8109aa374) good
- 2016-12-02 (f65ad27efe839ce9df0283840a1a40b4bbc9ead0) bad
- 2016-12-01 (cd4cdcc9ad6c45dad8b8d8c0d40e459db2bca8a1) bad
- 2016-11-30 22:08:56.091000 (8f1e420699832d42753c6503aa31861be6f5b186) bad
- 2016-11-30 16:11:33.370000 (741a720c98cdb92c229376be0badbf036f653bff) good
Flags: needinfo?(mstanke)

I suspect bug 1320860.

Michal, does this reproduce with:



Also, any chance of a screenshot of the correct and broken behaviours?

Karl, any chance this regression was caused by bug 1320860 ?
Flags: needinfo?(mstanke)
Flags: needinfo?(karlt)
1480528364 is broken.
And 1480474861 still works.
Unfortunately I was unable to take the screenshot of the address bar, as it disappears immediately the screenshot tool tries to take the shot. The same for the download button "bubble", where I noticed the progress bar looks like disappearing from the left instead of being colored with the download progress.
Flags: needinfo?(mstanke)
Blocks: 1320860
Keywords: regression
Component: Untriaged → Widget: Gtk
Thanks for the quick report and regression range.
Assignee: nobody → karlt
Flags: needinfo?(karlt)
Priority: -- → P1
Duplicate of this bug: 1322413
Duplicate of this bug: 1322290
Sure, I'll look at it. I wonder if we also can get the sMozFieldBackground from the text window beside the text colors.
I have hard time to reproduce this. Michal, can you please provide exact Gtk version you use?
Flags: needinfo?(mstanke)
(In reply to Martin Stránský from comment #12)
> I have hard time to reproduce this. Michal, can you please provide exact Gtk
> version you use?

I can also reproduce this, with GTK 3.14.5. I'm running on Debian stable with KDE.
Hi Martin. I have 3.18.9-1ubuntu3.1.
Flags: needinfo?(mstanke)
I am also seeing this. There is no selection background color in the address bar and in content. In addition, the bookmarks menu, the downloads drop down and the "burger" menu are all painted extremely slowly and without a background, i.e. transparent and without anti alias.

Last good revision: 741a720c98cdb92c229376be0badbf036f653bff
First bad revision: 8f1e420699832d42753c6503aa31861be6f5b186

KDE 4.11.5 running on openSUSE 13.1

libgtk-2 is 2.24.23 (Clearlooks theme)
libgtk-3 is 3.10.9  (Default theme)

Should I file a new bug since this is somewhat different?
I do get selection background color if I change both GTK2 and GTK3 theme to "Adwaita". The transparent drop down menus are not fixed, however.
(In reply to will69 from comment #15)
> Pushlog:
> pushloghtml?fromchange=741a720c98cdb92c229376be0badbf036f653bff&tochange=8f1e
> 420699832d42753c6503aa31861be6f5b186
> [...]
> Should I file a new bug since this is somewhat different?

This regression range contains bug 1320860, the bug identified as being responsible for this bug. I would wait until this bug is fixed, since chances are the fix will fix your issue too.
Installing "gtk3-engine-oxygen" and "gtk3-theme-oxygen" and switching both GTK2 and GTK3 themes to "oxygen-gtk" solved the transparent dropdown menu problem. (Switching themes back to "Adwaita" still reproduces the problem.) Highlighting works. Tooltips are black-on-almost-black now, though. Sigh!
[Tracking Requested - why for this release]:
We should not ship 53 with this regression.
Duplicate of this bug: 1321832
Tracking 53+ so we don't ship with this regression.
Whiteboard: [nightly-community] → [nightly-community][tpi:+]
Pushed by
use text node for field and selected colors r=stransky+263117
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Works for me in build 20161217030205 again.
Depends on: 1324262
WFM with KDE 4.11.5 (with libgtk 3.10.9) using "oxygen-gtk" and "Adwaita". Thanks a lot!
Backed out for causing a worse regression, bug 1324262.
Resolution: FIXED → ---
Duplicate of this bug: 1324731
Target Milestone: mozilla53 → ---
Version: unspecified → Trunk
Fixed by
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Will verify after in a day or two after I get new update with the patch.
Flags: needinfo?(mstanke)
Build 20161230030205 works again for me too.
Flags: needinfo?(mstanke)
Updating status flags based on Comment 32 and Comment 33.
You need to log in before you can comment on or make changes to this bug.