Address bar items and select items are not highlighted properly

VERIFIED FIXED

Status

()

Core
Widget: Gtk
P1
normal
VERIFIED FIXED
7 months ago
4 months ago

People

(Reporter: MikkCZ, Assigned: karlt)

Tracking

({regression})

Trunk
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 unaffected, firefox51 unaffected, firefox52 unaffected, firefox53+ verified)

Details

(Whiteboard: [nightly-community][tpi:+])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

This bug started to appear about a week ago in Nightly (works in latest release). My current configuration: Linux Mint 18, Cinnamon 3.0.7, Firefox 53.0a1 (20161204030210).

When I hover any item in the address bar (with mouse cursor or arrow keys), or I select anything in the classification/product/component/... select on https://bugzilla.mozilla.org/query.cgi?format=advanced, the highlight style is not applied, or is not applied correctly. Seems the font color changes, but the "line" background is colored the same as non selected items.
Whiteboard: [nightly-community]

Comment 1

7 months ago
Can you please find a regression window with mozregression? ( https://mozilla.github.io/mozregression/ )
Flags: needinfo?(mstanke)

Updated

7 months ago
Component: Theme → Untriaged
Product: Firefox → Core
Hi :Gijs.

I ended up with

> Error: Unable to exploit the merge commit. Origin branch is mozilla-central, and the commit message for 8f1e4206 was:
> Merge m-c to autoland on a CLOSED TREE. a=merge

Using mozregression I tested these builds:
- 2016-11-30 (13736e2db6eb94b02dd28cc88f2943b8109aa374) good
- 2016-12-02 (f65ad27efe839ce9df0283840a1a40b4bbc9ead0) bad
- 2016-12-01 (cd4cdcc9ad6c45dad8b8d8c0d40e459db2bca8a1) bad
- 2016-11-30 22:08:56.091000 (8f1e420699832d42753c6503aa31861be6f5b186) bad
- 2016-11-30 16:11:33.370000 (741a720c98cdb92c229376be0badbf036f653bff) good
Flags: needinfo?(mstanke)

Comment 3

7 months ago
https://hg.mozilla.org/mozilla-central/pushloghtml?tochange=8f1e42069983&fromchange=741a720c98cdb92c229376be0badbf036f653bff

I suspect bug 1320860.

Michal, does this reproduce with:

https://archive.mozilla.org/pub/firefox/tinderbox-builds/autoland-linux64/1480528364/

and 

https://archive.mozilla.org/pub/firefox/tinderbox-builds/autoland-linux64/1480474861/

?

Also, any chance of a screenshot of the correct and broken behaviours?

Karl, any chance this regression was caused by bug 1320860 ?
Flags: needinfo?(mstanke)
Flags: needinfo?(karlt)
Created attachment 8817129 [details]
screenshot-1480528364.png

1480528364 is broken.
Created attachment 8817130 [details]
screenshot-1480474861.png

And 1480474861 still works.
Unfortunately I was unable to take the screenshot of the address bar, as it disappears immediately the screenshot tool tries to take the shot. The same for the download button "bubble", where I noticed the progress bar looks like disappearing from the left instead of being colored with the download progress.
Flags: needinfo?(mstanke)

Updated

7 months ago
Blocks: 1320860
Keywords: regression

Updated

7 months ago
Component: Untriaged → Widget: Gtk
(Assignee)

Comment 7

7 months ago
Thanks for the quick report and regression range.
Assignee: nobody → karlt
Status: NEW → ASSIGNED
Flags: needinfo?(karlt)
Priority: -- → P1
(Assignee)

Updated

7 months ago
Duplicate of this bug: 1322413
(Assignee)

Updated

7 months ago
Duplicate of this bug: 1322290
Comment hidden (mozreview-request)

Comment 11

7 months ago
Sure, I'll look at it. I wonder if we also can get the sMozFieldBackground from the text window beside the text colors.

Comment 12

7 months ago
I have hard time to reproduce this. Michal, can you please provide exact Gtk version you use?
Flags: needinfo?(mstanke)
(In reply to Martin Stránský from comment #12)
> I have hard time to reproduce this. Michal, can you please provide exact Gtk
> version you use?

I can also reproduce this, with GTK 3.14.5. I'm running on Debian stable with KDE.
Hi Martin. I have 3.18.9-1ubuntu3.1.
Flags: needinfo?(mstanke)

Comment 15

7 months ago
I am also seeing this. There is no selection background color in the address bar and in content. In addition, the bookmarks menu, the downloads drop down and the "burger" menu are all painted extremely slowly and without a background, i.e. transparent and without anti alias.

Last good revision: 741a720c98cdb92c229376be0badbf036f653bff
First bad revision: 8f1e420699832d42753c6503aa31861be6f5b186
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=741a720c98cdb92c229376be0badbf036f653bff&tochange=8f1e420699832d42753c6503aa31861be6f5b186

KDE 4.11.5 running on openSUSE 13.1

libgtk-2 is 2.24.23 (Clearlooks theme)
libgtk-3 is 3.10.9  (Default theme)

Should I file a new bug since this is somewhat different?

Comment 16

7 months ago
I do get selection background color if I change both GTK2 and GTK3 theme to "Adwaita". The transparent drop down menus are not fixed, however.
(In reply to will69 from comment #15)
> Pushlog:
> https://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=741a720c98cdb92c229376be0badbf036f653bff&tochange=8f1e
> 420699832d42753c6503aa31861be6f5b186
> 
> [...]
> 
> Should I file a new bug since this is somewhat different?

This regression range contains bug 1320860, the bug identified as being responsible for this bug. I would wait until this bug is fixed, since chances are the fix will fix your issue too.

Comment 18

7 months ago
Installing "gtk3-engine-oxygen" and "gtk3-theme-oxygen" and switching both GTK2 and GTK3 themes to "oxygen-gtk" solved the transparent dropdown menu problem. (Switching themes back to "Adwaita" still reproduces the problem.) Highlighting works. Tooltips are black-on-almost-black now, though. Sigh!
[Tracking Requested - why for this release]:
We should not ship 53 with this regression.
status-firefox52: --- → unaffected
status-firefox53: --- → affected
tracking-firefox53: --- → ?

Updated

7 months ago
Duplicate of this bug: 1321832

Comment 21

7 months ago
mozreview-review
Comment on attachment 8817466 [details]
bug 1322120 use text node for field and selected colors

https://reviewboard.mozilla.org/r/97722/#review98128

Yes, that reflects the gtk code:

https://git.gnome.org/browse/gtk+/tree/gtk/gtktextview.c?h=gtk-3-18#n5792
https://git.gnome.org/browse/gtk+/tree/gtk/gtktextview.c?h=gtk-3-18#n7775
Attachment #8817466 - Flags: review?(stransky) → review+
Tracking 53+ so we don't ship with this regression.
tracking-firefox53: ? → +

Updated

6 months ago
Whiteboard: [nightly-community] → [nightly-community][tpi:+]

Comment 23

6 months ago
Pushed by ktomlinson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c2cedbdeb65
use text node for field and selected colors r=stransky+263117

Comment 24

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6c2cedbdeb65
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Works for me in build 20161217030205 again.
Status: RESOLVED → VERIFIED

Updated

6 months ago
Depends on: 1324262

Comment 26

6 months ago
WFM with KDE 4.11.5 (with libgtk 3.10.9) using "oxygen-gtk" and "Adwaita". Thanks a lot!
Backed out for causing a worse regression, bug 1324262.

https://hg.mozilla.org/integration/mozilla-inbound/rev/12f4a1387fbc20a4696cd0cc9ea1ae7cddeb213c
Status: VERIFIED → REOPENED
status-firefox53: fixed → affected
Resolution: FIXED → ---

Updated

6 months ago
Duplicate of this bug: 1324731
(Assignee)

Comment 29

6 months ago
Backed out a6aabcb07a6e from bug 1320860 until bug 1324262 is addressed.

https://hg.mozilla.org/integration/mozilla-inbound/rev/b0b87b3bc2dcfe0561f05d7ac780b023ea54ac23
status-firefox50: --- → unaffected
status-firefox51: --- → unaffected
Target Milestone: mozilla53 → ---
Version: unspecified → Trunk
(Assignee)

Comment 30

6 months ago
Fixed by https://hg.mozilla.org/mozilla-central/rev/b0b87b3bc2dc
Status: REOPENED → RESOLVED
Last Resolved: 6 months ago6 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Will verify after in a day or two after I get new update with the patch.
Flags: needinfo?(mstanke)
The Nightly built from https://hg.mozilla.org/mozilla-central/rev/6f63f95e28ffc05c0d2f5ef6cd6e05905fe8ea5a

now works as expected for me.
Build 20161230030205 works again for me too.
Status: RESOLVED → VERIFIED
Flags: needinfo?(mstanke)
Updating status flags based on Comment 32 and Comment 33.
status-firefox53: fixed → verified
You need to log in before you can comment on or make changes to this bug.