1320860 - adjust textarea style contexts for GTK 3.20 theming ABI changes

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: bug 1320860 introduce MOZ_GTK_TEXT_VIEW_TEXT and move MOZ_GTK_RESIZER to WidgetStyleCache +263117

Review commit: https://reviewboard.mozilla.org/r/96192/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96192/

Comment 2

[Martin Stránský [:stransky] (ni? me) (PTO, back on Jul 7)]

Comment on attachment 8815162 [details]
bug 1320860 introduce MOZ_GTK_TEXT_VIEW_TEXT and move MOZ_GTK_RESIZER to WidgetStyleCache +263117

https://reviewboard.mozilla.org/r/96192/#review96464

Looks okay.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72eb22d75bca
adjust textarea style contexts for GTK 3.20 theming ABI changes r=stransky+263117

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/a6aabcb07a6e
adjust textarea style contexts for GTK 3.20 theming ABI changes r=stransky+263117

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a6aabcb07a6e

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0b87b3bc2dc
Back out changeset a6aabcb07a6e for causing bug 1322120 or bug 1324262

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backout merged to m-c in https://hg.mozilla.org/mozilla-central/rev/b0b87b3bc2dc

Comment 8

[Karl Tomlinson (:karlt)]

Attachment: bug 1320860 consider textview root node background in addition to text node for -moz-field

This is necessary for GTK versions > 3.18 because windows no
longer clear their backgrounds since
https://git.gnome.org/browse/gtk+/commit/?id=580ea227a6bb19ad6c6d4766b3a36dbad24583f3
and Ambiance for 3.20 has a transparent background for the "text" window.
See bug 1324262.

Review commit: https://reviewboard.mozilla.org/r/101458/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/101458/

Comment 9

[Karl Tomlinson (:karlt)]

Attachment: bug 1320860 consider textview root node background in addition to text node for -moz-appearance:textfield-multiline

This is necessary for GTK versions > 3.18 because windows no
longer clear their backgrounds since
https://git.gnome.org/browse/gtk+/commit/?id=580ea227a6bb19ad6c6d4766b3a36dbad24583f3
and Ambiance for 3.20 has a transparent background for the "text" window.
See bug 1324262.

Review commit: https://reviewboard.mozilla.org/r/101460/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/101460/

Comment 10

[Karl Tomlinson (:karlt)]

Attachment: bug 1320860 adjust textarea style contexts for GTK 3.20 theming ABI changes +263117

Review commit: https://reviewboard.mozilla.org/r/101462/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/101462/

Comment 11

[Karl Tomlinson (:karlt)]

Comment on attachment 8815162 [details]
bug 1320860 introduce MOZ_GTK_TEXT_VIEW_TEXT and move MOZ_GTK_RESIZER to WidgetStyleCache +263117

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/96192/diff/1-2/

Comment 12

[Karl Tomlinson (:karlt)]

Comment on attachment 8815162 [details]
bug 1320860 introduce MOZ_GTK_TEXT_VIEW_TEXT and move MOZ_GTK_RESIZER to WidgetStyleCache +263117

This is what landed in a6aabcb07a6e plus the fix for bug 1322120 minus the changes in behavior for 3.20 that caused bug 1324262.
This is mostly already reviewed, but not exactly, so requesting another quick look over, please?

Bug 1324262 and the changes in the node for 3.20 are in the subsequent commits.

Comment 13

[Karl Tomlinson (:karlt)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=59781c3040931d1b0544f0e40517fd1aaefa29e0
https://treeherder.mozilla.org/#/jobs?repo=try&revision=74bf7a8dfc2cc1754d4005074b5fcb796c6d4014
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8de8660836cf6fd201bb911d9c97490c665a9820

Comment 14

[Joel Maher ( :jmaher ) (UTC -8)]

this backout caused a perf regression (removing a win from the original landing):
== Change summary for alert #4664 (as of December 29 2016 07:50 UTC) ==

Regressions:

  3%  tsvgr_opacity summary linux64 pgo e10s     337.66 -> 347.12
  2%  tsvgr_opacity summary linux64 pgo          371.06 -> 380.01

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=4664

looking forward to these relanding

Comment 15

[Martin Stránský [:stransky] (ni? me) (PTO, back on Jul 7)]

Comment on attachment 8822595 [details]
bug 1320860 consider textview root node background in addition to text node for -moz-field

https://reviewboard.mozilla.org/r/101458/#review102138

::: widget/gtk/nsLookAndFeel.cpp:66
(Diff revision 1)
>  #endif
>  }
>  
>  #if MOZ_WIDGET_GTK != 2
> +// Modifies color aDest as if color aSource was painted over aDest
> +static void

Please provide comment that we apply CAIRO_OPERATOR_OVER here.

Comment 16

[Martin Stránský [:stransky] (ni? me) (PTO, back on Jul 7)]

Comment on attachment 8822596 [details]
bug 1320860 consider textview root node background in addition to text node for -moz-appearance:textfield-multiline

https://reviewboard.mozilla.org/r/101460/#review102140

Comment 17

[Martin Stránský [:stransky] (ni? me) (PTO, back on Jul 7)]

Comment on attachment 8822597 [details]
bug 1320860 adjust textarea style contexts for GTK 3.20 theming ABI changes +263117

https://reviewboard.mozilla.org/r/101462/#review102144

Comment 18

[Martin Stránský [:stransky] (ni? me) (PTO, back on Jul 7)]

Comment on attachment 8815162 [details]
bug 1320860 introduce MOZ_GTK_TEXT_VIEW_TEXT and move MOZ_GTK_RESIZER to WidgetStyleCache +263117

https://reviewboard.mozilla.org/r/96192/#review102146

Comment 19

[Karl Tomlinson (:karlt)]

(In reply to Joel Maher ( :jmaher) from comment #14)
> this backout caused a perf regression (removing a win from the original
> landing):
> == Change summary for alert #4664 (as of December 29 2016 07:50 UTC) ==
> 
> Regressions:
> 
>   3%  tsvgr_opacity summary linux64 pgo e10s     337.66 -> 347.12
>   2%  tsvgr_opacity summary linux64 pgo          371.06 -> 380.01

Interesting, thanks.

I expected changes for this bug to have a performance impact only on -moz-appearance:textfield-multiline and/or -moz-appearance:resizer.  I don't see use of these in chrome.  I wonder whether the test uses textareas somewhere.

The code affected does determine colors that are used in chrome, but these are calculated only once, and so performance differences are not expected to be measurable.

Comment 20

[Karl Tomlinson (:karlt)]

Comment on attachment 8822595 [details]
bug 1320860 consider textview root node background in addition to text node for -moz-field

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/101458/diff/1-2/

Comment 21

[Karl Tomlinson (:karlt)]

Comment on attachment 8822596 [details]
bug 1320860 consider textview root node background in addition to text node for -moz-appearance:textfield-multiline

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/101460/diff/1-2/

Comment 22

[Karl Tomlinson (:karlt)]

Comment on attachment 8822597 [details]
bug 1320860 adjust textarea style contexts for GTK 3.20 theming ABI changes +263117

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/101462/diff/1-2/

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4591009826a2
introduce MOZ_GTK_TEXT_VIEW_TEXT and move MOZ_GTK_RESIZER to WidgetStyleCache r=stransky+263117+263117
https://hg.mozilla.org/integration/autoland/rev/c47ada33b755
consider textview root node background in addition to text node for -moz-field r=stransky+263117
https://hg.mozilla.org/integration/autoland/rev/8409c3695877
consider textview root node background in addition to text node for -moz-appearance:textfield-multiline r=stransky+263117
https://hg.mozilla.org/integration/autoland/rev/e71b038223a4
adjust textarea style contexts for GTK 3.20 theming ABI changes r=stransky+263117+263117

Comment 24

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4591009826a2
https://hg.mozilla.org/mozilla-central/rev/c47ada33b755
https://hg.mozilla.org/mozilla-central/rev/8409c3695877
https://hg.mozilla.org/mozilla-central/rev/e71b038223a4

Comment 25

[Rainer Bielefeld]

OS Unspecified? This seems to be a Linux issue

Comment 26

[Rainer Bielefeld]

Linux for now.