Closed
Bug 1326114
Opened 7 years ago
Closed 7 years ago
Audio Tab notification does not go away when tab is closed
Categories
(Firefox for Android Graveyard :: Audio/Video, defect)
Tracking
(firefox52 verified, firefox53 verified, firefox54 verified)
VERIFIED
FIXED
Firefox 54
People
(Reporter: justdave, Assigned: alwu)
References
Details
Attachments
(2 files)
59 bytes,
text/x-review-board-request
|
sebastian
:
review+
gchang
:
approval-mozilla-aurora+
|
Details |
3.10 KB,
patch
|
alwu
:
review+
jcristau
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
I was watching an Air Mozilla presentation, and when the presentation ended, I tapped the tab indicator at the top to get into the tab list then swiped the tab away. However, the system notification saying that there was a Firefox tab open that was playing audio did not go away. Tapping the pause button did not do anything, and I could not swipe away the notification. I had to force-quit Nightly in order to get the notification to go away. Build: 53.0a1 (2016-12-28)
Comment 1•7 years ago
|
||
Also reproucible by directly opening some media file and then navigating away while the audio is still playing - the notification remains visible even though something else is now loaded in that tab.
Updated•7 years ago
|
Blocks: fennec-media-control
Comment 2•7 years ago
|
||
Is this a regression? - I'm pretty sure this worked before.
Comment 4•7 years ago
|
||
This is reproducible also if I go to https://people-mozilla.org/~fqueze2/webrtc/. After I share camera and microphone from the doorhanger tap "Stop" button from web page. The video and microphone is stopped but the media notification is still displayed in notification android bar.
Assignee | ||
Comment 5•7 years ago
|
||
Hi, Julian, Could you help me check this bug? If you don't have time, you can transfer the NI back, and I'll check it after finishing other works. Thanks!
Flags: needinfo?(alwu) → needinfo?(walkingice0204)
Comment 6•7 years ago
|
||
I can reproduce this bug. Let me take over this bug.
Assignee: nobody → walkingice0204
Flags: needinfo?(walkingice0204)
Comment 7•7 years ago
|
||
With fennec-nightly, I went to Air Mozilla to give a try(play and pause video), and things seems work. Could Dave and Jan try again? (some patches for were merged for bug 1322114). Actually the notification is not really relevant to Audio, but relevant to Media-playing. It is just a default icon if the web-site does not provide big-enough-favicon[1]. I followed Sorina's steps to reproduce, and found * When I click "Audio & Video& to start * got event "MEDIA_PLAYING_CHANGE" - this event creates Notification * got event "AUDIO_PLAYING_CHANGE" - so far we don't handle this event at all * Then click "Stop" to stop * only got event "AUDIO_PLAYING_CHANGE" Alastor, do you have any idea about the missing event MEDIA_PLAYING_CHANGE? [1] https://dxr.mozilla.org/mozilla-central/rev/1d025ac534a6333a8170a59a95a8a3673d4028ee/mobile/android/base/java/org/mozilla/gecko/media/MediaControlService.java#418
Comment 8•7 years ago
|
||
Still reproducible in Nightly 2017-02-06. Just open some YouTube video and play it. Then, click into the address bar and navigate to some different page - the media notification remains visible.
Comment 9•7 years ago
|
||
Thanks Jan. I tried what you said and got similar situation. When started playing Youtube video, got two events. Then only got AUDIO_PLAYING_CHANGE event when navigated to another page by changing address bar.
Comment 11•7 years ago
|
||
Just aware of that I haven't set need info flag. My bad :-/
Flags: needinfo?(alwu)
Assignee | ||
Updated•7 years ago
|
Assignee: walkingice0204 → alwu
Flags: needinfo?(alwu)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 13•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=58fd1aa1afa2253c2c0724822239a12b6d657f28
Comment hidden (mozreview-request) |
Comment 15•7 years ago
|
||
mozreview-review |
Comment on attachment 8839373 [details] Bug 1326114 - only do duration checking for active-media. https://reviewboard.mozilla.org/r/114060/#review116212
Attachment #8839373 -
Flags: review?(s.kaspari) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 17•7 years ago
|
||
Rebase to avoid conflict with bug1340191.
Comment 18•7 years ago
|
||
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/925704aab093 only do duration checking for active-media. r=sebastian
Comment 20•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/925704aab093
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Comment 21•7 years ago
|
||
Verified as fixed on build 54.0a1 (2017-02-22); Device: Motorola Nexus 6 (Android 7.0) and Huawei MediaPad M2 (Android 5.1.1). Media control notification is not displayed after I close the tab.
Assignee | ||
Comment 23•7 years ago
|
||
Comment on attachment 8839373 [details] Bug 1326114 - only do duration checking for active-media. Approval Request Comment [Feature/Bug causing the regression]: Fix regression bug [User impact if declined]: The media control won't be hided even user leave that website [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Not yet [Needs manual test from QE? If yes, steps to reproduce]: Yes, see comment0 [List of other uplifts needed for the feature/fix]: bug1340191 is related, and this bug needs to be uplifted after bug1340191 [Is the change risky?]: No [Why is the change risky/not risky?]: Only affect Fennec, and it's UI level changed [String changes made/needed]: No
Flags: needinfo?(alwu)
Attachment #8839373 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 24•7 years ago
|
||
Approval Request Comment [Feature/Bug causing the regression]: Fix regression bug [User impact if declined]: The media control won't be hided even user leave that website [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Not yet [Needs manual test from QE? If yes, steps to reproduce]: Yes, see comment0 [List of other uplifts needed for the feature/fix]: bug1340191 is related, and this bug needs to be uplifted after bug1340191 [Is the change risky?]: No [Why is the change risky/not risky?]: Only affect Fennec, and it's UI level changed [String changes made/needed]: No
Attachment #8842283 -
Flags: review+
Attachment #8842283 -
Flags: approval-mozilla-beta?
Comment 25•7 years ago
|
||
Comment on attachment 8842283 [details] [diff] [review] Bug 1326114 - only do duration checking for active-media. (for-beta) Too late for 52.
Attachment #8842283 -
Flags: approval-mozilla-beta? → approval-mozilla-beta-
Comment 26•7 years ago
|
||
While it is admittedly late, this is a new feature that has only been generally enabled starting from Firefox 52 (see bug 1290836), so shipping it with this bug still present would be somewhat annoying, especially since the notification cannot be simply swiped away.
Flags: needinfo?(jcristau)
Updated•7 years ago
|
Attachment #8842283 -
Attachment is patch: true
Comment 27•7 years ago
|
||
Comment on attachment 8839373 [details] Bug 1326114 - only do duration checking for active-media. Fix an issue that notification doesn't go away and was verified. Aurora53+.
Attachment #8839373 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Reporter | ||
Comment 28•7 years ago
|
||
(In reply to Jan Henning [:JanH] from comment #26) > While it is admittedly late, this is a new feature that has only been > generally enabled starting from Firefox 52 (see bug 1290836), so shipping it > with this bug still present would be somewhat annoying, especially since the > notification cannot be simply swiped away. Just to echo this, and be more explicit about it, once you trigger this notification, the only way to get rid of it without this fix is to force-quit Firefox. That's not user-friendly in the least.
Comment 29•7 years ago
|
||
Comment on attachment 8842283 [details] [diff] [review] Bug 1326114 - only do duration checking for active-media. (for-beta) OK, let's take this last minute fix for 52...
Flags: needinfo?(jcristau)
Attachment #8842283 -
Flags: approval-mozilla-beta- → approval-mozilla-beta+
Comment 30•7 years ago
|
||
We're going to want manual verification on this.
Flags: qe-verify+
Flags: needinfo?(ioana.chiorean)
Comment 31•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/2690fd706b25
Comment 32•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/f38b2da7ec12 https://hg.mozilla.org/releases/mozilla-release/rev/f38b2da7ec12
status-firefox52:
--- → fixed
Comment 33•7 years ago
|
||
Verified as fixed on build 53.0a2 (2017-03-03) and 52 Beta 11; Device: Nexus 9 (Android 7.1.1) and Samsung Galaxy Note 4 (Android 5.0.1). Media control notification is not displayed after the tab is closed. I followed all the scenarios described in this bug.
Status: RESOLVED → VERIFIED
Flags: needinfo?(ioana.chiorean)
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•