1329514 - Thunderbird beta: Help | About | 'release notes' brings up *Firefox* beta page

Status: RESOLVED FIXED

(www.mozilla.org Graveyard :: Thunderbird, defect)

Description

[najoll]

Attachment: Screenshot (84).png

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20161208153507

Steps to reproduce:

Opened the 'about' window and then clicked on 'release notes'.


Actual results:

The release notes for a version of *Firefox* appeared. See attached screenshot.


Expected results:

Obviously, the release notes for Thunderbird should have appeared.

Comment 1

[Jorg K (CEST = GMT+2)]

Wayne, that's not so good.

Comment 2

[Chris Ramsden]

Bug still present in TB51.0b1. About Thunderbird offers 

https://www.mozilla.org/en-US/firefox/51.0beta/releasenotes/ 

instead of 

https://www.mozilla.org/en-US/thunderbird/51.0beta/releasenotes/

Comment 3

[Wayne Mery (:wsmwk)]

The user must have been using a candidate build. So it would be expected that he/she didn't get release notes - they didn't exist.  
Note, we typically do not issue release notes until we *actually* release.  So in the reporter's case, this bug would be be closed invalid.

In Chris's case, it's that typical lovely many hours delay we always have.  Last night I had the same problem. Now I get it OK.  => WFM    Gotta love that delay.

Comment 4

[Chris Ramsden]

I could understand a 404, or even it pointing to an earlier release. But pointing to an entirely different product is unexpected.

Comment 5

[Jorg K (CEST = GMT+2)]

I installed the official 51.0 beta.
Help > Release Notes got me to the TB release notes.
Help > About, "Release Notes", next to the version brings up a tab in TB with the FF release notes.
So this isn't fixed and some redirect is still wrong.

Using the DOM inspector I can see this behind the link:
href="https://www.mozilla.org/thunderbird/51.0/releasenotes/"
I invite you to click this here and see that it takes you to FF.

Comment 6

[Wayne Mery (:wsmwk)]

my bad. I didn't correctly follow the steps. It also happens for 50.0b3  I think we already have a bug report about this. I don't have time to look for it.

FWIW This link at Help | About | ... was added in bug 1271151

Comment 7

[Jorg K (CEST = GMT+2)]

In bug 1292061 this was added:
https://hg.mozilla.org/comm-central/rev/44fe7e9a0e423a8e03bbf37528a5828e86796c35#l1.16
So the release note link in the about box goes here:
https://www.mozilla.org/thunderbird/__MOZ_APP_VERSION__/releasenotes/
the result of which can be seen in comment #5.

Help > Release Notes on the other had does |openFormattedURL('app.releaseNotesURL');| and that goes to:
https://dxr.mozilla.org/comm-central/rev/1e9544045f0986802a8701bf0a6ae8effd5cf1dd/mail/app/profile/all-thunderbird.js#122
https://live.mozillamessaging.com/%APP%/releasenotes?locale=%LOCALE%&version=%VERSION%&os=%OS%&buildid=%APPBUILDID%

So how do we fix that?

I tried:
<button id="releasenotes" label="&releaseNotes.link;" oncommand="openFormattedURL('app.releaseNotesURL');"/>
but the button is pretty ugly and doesn't work since openFormattedURL() is not available (which could be fixed with an include, I suppose).

The alternative is to back out bug 1292061 since having two mechanisms to do the same thing is error-prone, as we can see here.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Attachment: manage-version_display_tb.diff

My bad. I forgot to bump the releng config files.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Attachment: manage-version_display_tb_esr.diff

The file for esr. Will be useless now but maybe we want to deploy to avoid my short memory ;)

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8827114 [details] [diff] [review]
manage-version_display_tb.diff

not the issue, sorry, looking

Comment 11

[Sylvestre Ledru [:Sylvestre]]

I need the help of rail about this :)
So
https://hg.mozilla.org/releases/comm-beta/file/tip/mail/config/version.txt
==
https://hg.mozilla.org/releases/comm-beta/file/tip/mail/config/version_display.txt

When they should be different (this is the case with fennec)

The config file looks fine:
https://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/staging_release-thunderbird-comm-beta.py#l57
(to compare with fennec:
https://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/release-fennec-mozilla-beta.py#l40
)

Comment 12

[Rail Aliiev [:rail]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #11)
> I need the help of rail about this :)
> So
> https://hg.mozilla.org/releases/comm-beta/file/tip/mail/config/version.txt
> ==
> https://hg.mozilla.org/releases/comm-beta/file/tip/mail/config/
> version_display.txt

Thunderbird doesn't use the "tip". We create a relbranch, set the versions on it, see https://hg.mozilla.org/releases/comm-beta/file/THUNDERBIRD_50_0b3_RELEASE/mail/config/version_display.txt


BTW, to change the release configs, you need to change the templates (*.py.template), not the *.py files - they are generated runtime.

Comment 15

[Jorg K (CEST = GMT+2)]

No movement here?

Comment 16

[Kohei Yoshino [:kohei]]

Just flagged by :sancus on #www. Looks like it's a site issue as pointed out by Jorg K in comment 5. Will fix it.

Comment 17

[Kohei Yoshino [:kohei]]

Attachment: pull request

Comment 18

[Sylvestre Ledru [:Sylvestre]]

Sorry, I dropped the ball on this. Fortunately, Kohei rocks!

Comment 19

[Jorg K (CEST = GMT+2)]

Still not fixed after ten days after the pull request.

Comment 20

[Kohei Yoshino [:kohei]]

Hope my pull request get reviewed sometime this week.

Comment 21

[Albert Scheiner [:alberts]]

Can there anything be done to check where it's up to in the queue?

Comment 22

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/94c7f072df2fb4f4024b2c7a02678dbfa7c65eb1
Fix Bug 1329514 - Thunderbird beta: Help | About | 'release notes' brings up *Firefox* beta page

https://github.com/mozilla/bedrock/commit/f1149c710d90f74f0cfaf1c2732663dfb406d595
Merge pull request #4670 from kyoshino/bug-1329514-tb-beta-redirect

Fix Bug 1329514 - Thunderbird beta: Help | About | 'release notes' brings up *Firefox* beta page

Comment 23

[Kohei Yoshino [:kohei]]

The fix goes live today or tomorrow.

Comment 24

[Albert Scheiner [:alberts]]

FYI, not live yet, just tested link in 52.0b4 (64-bit) "About" window