Closed Bug 1271151 Opened 4 years ago Closed 4 years ago

Add the version number and release notes link to the about window dialog

Categories

(Thunderbird :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch add-release-notes-link.diff (obsolete) — Splinter Review
Similar to what has been done with firefox in bug 1145171 and bug 1047395, this patch adds in the about window:
* the version of Thunderbird used
* link to the release notes (when !nightly)

The next step is to update automation to automatically update that file.
Attachment #8750119 - Flags: review?(mkmelin+mozilla)
Assignee: nobody → sledru
Depends on: 1271153
FYI, I am planning to request the uplift to beta & 45.* once it landed.
Comment on attachment 8750119 [details] [diff] [review]
add-release-notes-link.diff

Review of attachment 8750119 [details] [diff] [review]:
-----------------------------------------------------------------

Please do it like firefox, so we'd have a THUNDERBIRD_VERSION_DISPLAY

::: mail/confvars.sh
@@ +23,5 @@
>  MOZ_SAFE_BROWSING=1
>  MOZ_MORK=1
>  
>  MOZ_APP_VERSION_TXT=${_topsrcdir}/$MOZ_BUILD_APP/config/version.txt
> +MOZ_APP_VERSION=`cat $MOZ_APP_VERSION_TXT

missing tick here, so it's all broken

::: mail/locales/en-US/chrome/messenger/aboutDialog.dtd
@@ +43,5 @@
>  <!-- LOCALIZATION NOTE (helpus.getInvolvedLink): This is a link title that links to http://www.mozilla.org/contribute/. -->
>  <!ENTITY helpus.getInvolvedLink     "get involved!">
>  <!ENTITY helpus.end                 "">
>  
> +<!ENTITY releaseNotes.link   "What's new">

Might as well remove the extra spaces before the value.
Attachment #8750119 - Flags: review?(mkmelin+mozilla) → review-
(In reply to Sylvestre Ledru [:sylvestre] from comment #1)
> FYI, I am planning to request the uplift to beta & 45.* once it landed.

45 won't be possible since you have string changes
Attached patch version-relnotes.diff (obsolete) — Splinter Review
Sorry about the delay.
I didn't rename MOZ_APP_VERSION_DISPLAY to THUNDERBIRD_DISPLAY_VERSION because it is was it used in Firefox.
Attachment #8750119 - Attachment is obsolete: true
Attachment #8760059 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8760059 [details] [diff] [review]
version-relnotes.diff

Review of attachment 8760059 [details] [diff] [review]:
-----------------------------------------------------------------

Thx, I like it! We do need the version bumping sorted out before we can use it though

::: mail/config/version_display.txt
@@ +1,1 @@
> +48.0a1

Well, we're at 50.0a1 now :)

Looks like firefox has automated bumping this. We probably need to do that too, or it will quickly start displaying the wrong version to you.

::: mail/locales/en-US/chrome/messenger/aboutDialog.dtd
@@ +43,5 @@
>  <!-- LOCALIZATION NOTE (helpus.getInvolvedLink): This is a link title that links to http://www.mozilla.org/contribute/. -->
>  <!ENTITY helpus.getInvolvedLink     "get involved!">
>  <!ENTITY helpus.end                 "">
>  
> +<!ENTITY releaseNotes.link          "What's new">

I think this should be "Release notes". (and remove the extra spaces)

Thunderbird has another page for "what's new" in the Help menu, and also if you go go the dialog to trigger update, it's quite confusing that you're downloading something new, but the what's new would go to the old version's release notes.
Attachment #8760059 - Flags: review?(mkmelin+mozilla) → feedback+
Here it is
About the automation, it is happening in bug 1271153
Attachment #8760059 - Attachment is obsolete: true
Attachment #8762401 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8762401 [details] [diff] [review]
version-relnotes.diff

Review of attachment 8762401 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thx! r=mkmelin
Attachment #8762401 - Flags: review?(mkmelin+mozilla) → review+
https://hg.mozilla.org/comm-central/rev/44fe7e9a0e423a8e03bbf37528a5828e86796c35
Bug 1271151 - Add a link to the release notes and display the current version
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Depends on: 1292061
(In reply to Magnus Melin from comment #5)
> Comment on attachment 8760059 [details] [diff] [review]
> version-relnotes.diff
> 
> Review of attachment 8760059 [details] [diff] [review]:
> -----------------------------------------------------------------
> Looks like firefox has automated bumping this. We probably need to do that
> too, or it will quickly start displaying the wrong version to you.

Already happened with the first bump, see bug 1292061. Do we really need this second file with the redundant information?
You need to log in before you can comment on or make changes to this bug.