1332246 - Crash with MacOS 10.11 when attempting to update Mac OS X address book [ @libsystem_kernel.dylib@0x16f06] via nsAbOSXCard::Update

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:51.0) Gecko/20100101 Thunderbird/51.0 ID:20170117151053 CSet: 13d3127744a874a46c7b65dd5fb92293bfe51a01

Earlier today I updated my local Thunderbird application from the current release to the latest beta. After a couple of minutes I got a crash, and now Thunderbird crashes each time during startup.

Report: bp-8cbba8d4-ffce-4e1a-a88b-4cc1c2170119.

As it looks like it happens when we try to access the Mac OS X address book:

0 	libsystem_kernel.dylib 	libsystem_kernel.dylib@0x16f06
[..]
13 	XUL 	AppendToString(NSString const*, nsString&) 	/builds/slave/tb-rel-c-beta-m64_bld-00000000/build/mailnews/addrbook/src/nsAbOSXUtils.mm:29
14 	XUL 	nsAbOSXCard::Update(bool) 	/builds/slave/tb-rel-c-beta-m64_bld-00000000/build/mailnews/addrbook/src/nsAbOSXCard.mm:61
15 	XUL 	non-virtual thunk to nsAbOSXCard::Init(char const*) 	/builds/slave/tb-rel-c-beta-m64_bld-00000000/build/mailnews/addrbook/src/nsAbOSXCard.mm:148
16 	XUL 	CreateCard 	/builds/slave/tb-rel-c-beta-m64_bld-00000000/build/mailnews/addrbook/src/nsAbOSXDirectory.mm:85
17 	XUL 	nsAbOSXDirectory::Init(char const*) 	/builds/slave/tb-rel-c-beta-m64_bld-00000000/build/mailnews/addrbook/src/nsAbOSXDirectory.mm:544 

Workaround here for the startup crash is to disconnect from the network. But I assume the crash comes back once a new mail arrives.

Comment 1

[Wayne Mery (:wsmwk)]

whimboo, does the workaround help you with 51.0b2 ?
System Preferences > Security & Privacy and select the Privacy tab- DEselect Thunderbird 

(note - do not dup this to bug 1286613 unless it is tested a version that has the patches from bug 1286613 and bug 1332508)

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Well, when I would do the above I wouldn't have access to any of my contacts. Also if I disable Thunderbird from having access to the addressbook, how should the crash be reproduced if the code path is no longer used?

Btw. this crash seems to happen when there is an incoming email from a person maybe not yet in the address book, and Thunderbird tries to add this person. That's why the signature: nsAbOSXCard::Update(bool). It's not a startup crash for me if there is not such an incoming email.

Comment 3

[Wayne Mery (:wsmwk)]

Thanks for pointing out these details.  Yeah, the workaround is a non-starter unless you WANT to use 51 and don't miss the AB. Just consider it a point of information. :)

A. I thought Thunderbird wasn't capable of writing to Mac contacts?

B. If you're game, the patches previously mentioned should be available in 53 nightly at https://archive.mozilla.org/pub/thunderbird/nightly/latest-comm-central/

Comment 5

[Wayne Mery (:wsmwk)]

Antony's bp-f809a931-629b-45cc-8711-9d3d32170126 Build ID 20170125030213 TB54.0a1 proves this is not fixed by bug 1286613.

It is critical to the 52 beta process that we fix this ASAP.

Comment 6

[Wayne Mery (:wsmwk)]

(In reply to Wayne Mery (:wsmwk, NI for questions) from comment #5)
> Antony's bp-f809a931-629b-45cc-8711-9d3d32170126 Build ID 20170125030213
> TB54.0a1 proves this is not fixed by bug 1286613.

Also patrick's bp-6e92da9c-874b-4fc3-b8de-e516a2170124 53.0a2 20170124004006 10.12.3 16D32

Can someone answer this question please - is TB capable of updating Mac contacts?

Comment 7

[Mike Hommey [:glandium]]

The last non-system library frame is in AppendToString(NSString const*, nsString&) at mailnews/addrbook/src/nsAbOSXUtils.mm:29, but that could be wrong because there is no debug info for CoreFoundation. The frames above that suggest whatever CoreFoundation is being called for is failing and throws an exception.

Comment 8

[Markus Stange [:mstange]]

The frames above AppendToString are:
#0 __pthread_kill (in libsystem_kernel.dylib)
#1 abort (in libsystem_c.dylib)
#2 abort_message (in libc++abi.dylib)
#3 default_terminate_handler() (in libc++abi.dylib)
#4 _objc_terminate() (in libobjc.A.dylib)
#5 std::__terminate(void (*)()) (in libc++abi.dylib)
#6 __cxa_throw (in libc++abi.dylib)
#7 objc_exception_throw (in libobjc.A.dylib)
#8 -[NSObject(NSObject) doesNotRecognizeSelector:] (in CoreFoundation)
#9 ___forwarding___ (in CoreFoundation)
#10 __forwarding_prep_0___ (in CoreFoundation)
#11 AppendToString

Comment 9

[Antony]

In ans to comment 6...
I can select and then see the Mac OSX address book in the Address Book list Pane: however, if I want to add to that book as a new contact, I do not have that AB showing in the drop down list, nor does it show in preferences for composition as an option for Default for AB.
I am still on 51.0 and have the Option in Security for TB to access the Mac contacts as Off.
I could reload 49 or earlier and reset the flag and try then as prob cannot access whilst flag off for 51.0 build.
Guess Q. is, does anyone need to write an address to the Mac Contacts or read and choose from this AB for a mail written in TB?

Comment 10

[Markus Stange [:mstange]]

So apparently, for some property, [aOSXCard valueForProperty:aProperty] returns an object that is non-null but not an NSString. With a debug build it should be fairly easy to find out what property that is and what it returns instead.

Comment 11

[Patrick Brunschwig]

(In reply to Wayne Mery (:wsmwk, NI for questions) from comment #6)
>
> Can someone answer this question please - is TB capable of updating Mac
> contacts?

No, I don't think so. If I create a new contact with TB 45, I can only choose to save the contact in one of my local address books (I don't have LDAP though). The Mac OS Addressbook seems to be read-only.

Comment 12

[Wayne Mery (:wsmwk)]

(In reply to Markus Stange [:mstange] from comment #10)
> So apparently, for some property, [aOSXCard valueForProperty:aProperty]
> returns an object that is non-null but not an NSString. With a debug build
> it should be fairly easy to find out what property that is and what it
> returns instead.

OK, too keep the ball rolling today, can someone grab https://archive.mozilla.org/pub/thunderbird/tinderbox-builds/comm-beta-macosx64-debug/1485949508/ 


10.12 signature is [@ libsystem_kernel.dylib@0x19dd6 ]

Comment 14

[Kent James (:rkent)]

(In reply to Wayne Mery (:wsmwk, NI for questions) from comment #6)

> Can someone answer this question please - is TB capable of updating Mac
> contacts?

There is no implementation of AddCard or ModifyCard in the OSX address book, so Thunderbird cannot modify OSX cards. Which is too bad, I had hoped that the solution to this in the short run was going to be to disable code that modified cards.

It's hard to believe that this is not similar to bug 1286613, even it that patch does not solve this problem.

Comment 15

[Antony]

I am a MAC user but NOT their apps... TB and Firefox fan. If one is using TB then is anyone really bothered to save contacts for use on MAC apps like Mail and such? I am not saying I do not think they would... posing the question, as this would then drive the real need to configure TB to do this. If not that a demand then just advise either turning off the flag in Security or even removing the TB code link to do so and this would fix the crash issue

Just a though

Comment 16

[Patrick Brunschwig]

I'd say the main reason why this may be an interesting feature for some users (not me though) is to synchronize contacts with their iPhone (via iCloud).

Comment 17

[Antony]

you have a good point there!!! ha ha as i am an android user was not something i considered. Be good to TB working on Android one day sooon just like FF does (and i suppose iPhone too )

Comment 18

[Wayne Mery (:wsmwk)]

(In reply to Kent James (:rkent) from comment #14)
> (In reply to Wayne Mery (:wsmwk, NI for questions) from comment #6)
> 
> > Can someone answer this question please - is TB capable of updating Mac
> > contacts?
> 
> There is no implementation of AddCard or ModifyCard in the OSX address book,
> so Thunderbird cannot modify OSX cards. Which is too bad, I had hoped that
> the solution to this in the short run was going to be to disable code that
> modified cards.

Which makes me wonder why there is an update method at all.

> It's hard to believe that this is not similar to bug 1286613, even if that
> patch does not solve this problem.

Indeed. Maybe that patch doesn't go far enough. 

Anywho, we badly need this fixed, so first we need someone with Mac to do comment 12

Comment 19

[Patrick Brunschwig]

Attachment: Output from EarlybirdDebug build

I tried the debug build and got the output attached. Is this what you need?

Comment 20

[Wayne Mery (:wsmwk)]

(In reply to Patrick Brunschwig from comment #19)
> Created attachment 8833772 [details]
> Output from EarlybirdDebug build
> 
> I tried the debug build and got the output attached. Is this what you need?

Comment 21

[Kent James (:rkent)]

Comment on attachment 8833772 [details]
Output from EarlybirdDebug build

Wayne, I'm not sure why you directed this at me. My ability to do anything on OSX is extremely limited. I can compile and do obvious fixes, but I cannot diagnose deep issues, particularly anything related to OSX core libraries.

Comment 22

[Markus Stange [:mstange]]

Attachment: Bug 1332246 - Don't expect kABInstantMessageProperty values to be NSStrings.

In 10.12 on my machine they are NSDictionary values. This patch also respects
the instant messaging service name and assigns the user name to the right
field, or even to multiple fields if multiple IM services are specified.

Review commit: https://reviewboard.mozilla.org/r/109952/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109952/

Comment 23

[Mark Banner (:standard8)]

Comment on attachment 8833825 [details]
Bug 1332246 - Don't expect kABInstantMessageProperty values to be NSStrings.

Passing to Mike as I'm not active on Thunderbird these days.

Comment 24

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8833825 [details]
Bug 1332246 - Don't expect kABInstantMessageProperty values to be NSStrings.

https://reviewboard.mozilla.org/r/109952/#review111578

Looks okay to me, but I didn't test. Thanks for the patch!

Comment 25

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/c0719df30af65ddccec6af1d8bdb60f12f36a3f5

Comment 26

[Jorg K (CEST = GMT+2)]

Comment on attachment 8833825 [details]
Bug 1332246 - Don't expect kABInstantMessageProperty values to be NSStrings.

Uplift coming. Since C-C trunk is pretty busted at the moment, perhaps someone can try this on Aurora once uplifted.

Comment 27

[Jorg K (CEST = GMT+2)]

Aurora (TB 53):
https://hg.mozilla.org/releases/comm-aurora/rev/c28d0880a96704bb87ad41b786b4395878563b87

Comment 28

[Jorg K (CEST = GMT+2)]

Beta (TB 52):
https://hg.mozilla.org/releases/comm-beta/rev/57b1d904732de210c27503a251adc246a1c27de4

Comment 29

[Wayne Mery (:wsmwk)]

(In reply to Jorg K (GMT+1) from comment #26)
> Comment on attachment 8833825 [details]
> Bug 1332246 - Don't expect kABInstantMessageProperty values to be NSStrings.
> 
> Uplift coming. Since C-C trunk is pretty busted at the moment, perhaps
> someone can try this on Aurora once uplifted.

As soon as it's done I'll have someone test https://treeherder.mozilla.org/#/jobs?repo=comm-aurora&revision=d622687456eb6da504f9b057b682b9bb88b38064

Comment 30

[Wayne Mery (:wsmwk)]

So far I have 3 good reports and none bad. So  good for uplift to beta

Comment 31

[Jorg K (CEST = GMT+2)]

Already uplifted, see comment #28.

Comment 32

[Antony]

I'll keep Earlybird running for a mo as latest and has Lightning already in it! As a heads-up, may raise another tkt as I keep getting connection issues when TB needs to get mail from my provider. been last few releases
Great to have the fix