1332867 - Date/time picker dropmarker is collapsed under recent GTK versions (~ > 3.18 ?)

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Ronan Jouchet [:ronjouch]]

Attachment: dropmarker-before-after-workaround.png

Since a few GTK releases (I think it was 3.18 that introduced the issue), the dropmarkers at the right of the date/time pickers in the new/edit Event dialog are collapsed (into hard-to-click zones of a few pixels wide, see attached screenshot).

Using DOM Inspector, I was able to botch a workaround with this ugly userChrome.css:

    datetimepicker * .menulist-dropmarker {width: 30px;}

To reproduce the issue and implement a proper fix, I guess booting in a VM a livecd for a distro shipping a recent GTK should do the job. Arch, or maybe the latest Fedora?

Configuration
=============

- GTK 3.22.7-1 under Arch Linux
- Standard unmodified GNOME "Adwaita" theme
- Thunderbird 51.0b2 from https://ftp.mozilla.org/pub/thunderbird/releases/51.0b2/linux-x86_64/en-US/thunderbird-51.0b2.tar.bz2
- Lightning 5.3b2 from https://ftp.mozilla.org/pub/calendar/lightning/candidates/5.3b2-candidates/build1/linux-x86_64/lightning-5.3b2.en-US.linux-x86_64.xpi

Comment 1

[Stefan Sitter [:ssitter]]

Richard, would it be possible for you to check if this is a problem with the Lightning default theme?

Comment 2

[Richard Marti (:Paenglab)]

I see this too in Mail Account Setup -> not a calendar only problem. It's a widget issue but the problem is, m-c uses except in tests no editable menulists and with the old CentOS builders this issue will never be seen in tests.

It's easier to fix this in TB theme as it's very unlikely it will be fixed in toolkit. I'm on a solution (similar to the proposal in comment 0) which doesn't regress on older GTK versions.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: GTK3dropmarker.patch

This patch shows the dropmarker in Mail Account Setup and datetimepicker but does not regress on older GTK3 versions. Tested on Linux Mint with older GTK3 and Fedora with newer GTK (where no dropmarker was shown before the patch).

Comment 4

[Ronan Jouchet [:ronjouch]]

(In reply to Richard Marti (:Paenglab) from comment #3)
> This patch shows the dropmarker in Mail Account Setup and datetimepicker but
> does not regress on older GTK3 versions. Tested on Linux Mint with older
> GTK3 and Fedora with newer GTK (where no dropmarker was shown before the
> patch).

Pasted the patch in my userChrome.css for testing, looks good on GTK 3.22.7 !
Thanks for the fast fix :) , feel free to RESOLVE.

Comment 5

[:aceman]

Based on comment 2, would there be a chance to fix this properly in toolkit?

Comment 6

[Neil Deakin]

We can, but it would be better to find out why this was broken. Are we certain that this is a change in GTK3.18?

Comment 7

[Richard Marti (:Paenglab)]

I can't say it's since GTK3.18 but on Kubuntu 16.10 with GTK3.20 the dropmarker of editable menulists has only a width of 2px.

Comment 8

[:aceman]

I do not see the problem on GTK3.18.9, neither in Lightning (5.6a1) nor in new account wizard (TB54).

Ronan, can you retest with current TB? Maybe the issue was already fixed on trunk.

Comment 9

[Ronan Jouchet [:ronjouch]]

Attachment: 1332867_not-fixed-in-tb54-2017-02-12.png

(In reply to :aceman from comment #8)
> I do not see the problem on GTK3.18.9, neither in Lightning (5.6a1) nor in
> new account wizard (TB54).
> 
> Ronan, can you retest with current TB? Maybe the issue was already fixed on
> trunk.

Testing Thunderbird Daily 54.0a1 (2017-02-12) (64-bit) with a fresh profile, the issue is still present in the New Event dialog. See attached screenshot

Comment 10

[:aceman]

And you are on GTK 3.22. Paenglab says it exists in GTK 3.20 already.
So can we wait until I get GTK newer than 3.18 so we see whether it isn't Ubuntu specific?

Comment 11

[Richard Marti (:Paenglab)]

It's not Ubuntu specific, I see this on Fedora 25 too.

Comment 12

[:aceman]

My distro is testing GTK 3.22 now so I should be able to check this soon.

Comment 13

[:aceman]

Comment on attachment 8830875 [details] [diff] [review]
GTK3dropmarker.patch

Review of attachment 8830875 [details] [diff] [review]:
-----------------------------------------------------------------

With Gtk 3.22 this patch is needed and fixes the problem. Can you also fix it in the account creation wizard? File -> New -> Existing mail account .
Thanks

Comment 14

[:aceman]

I know you wanted to fix it TB wide with putting it in messenges.css, but maybe that dialog does not include it.

Comment 15

[Richard Marti (:Paenglab)]

Attachment: GTK3dropmarker.patch

Added the rule in accountCreation.css too.

Comment 16

[:aceman]

This will need uplift as users will run TB52 on the new GTK for the years to come.

Comment 17

[Richard Marti (:Paenglab)]

Attachment: Patch for Beta and ESR

[Approval Request Comment]
User impact if declined: No visible dropmarker with newer GTK versions
Testing completed (on c-c, etc.): ready for c-c
Risk to taking this patch (and alternatives if risky): low

Comment 18

[Richard Marti (:Paenglab)]

https://hg.mozilla.org/comm-central/rev/66f479be94c775dabf1da9f595b99f280c84151a

Comment 19

[Jorg K (CEST = GMT+2)]

Beta (TB 54):
https://hg.mozilla.org/releases/comm-beta/rev/3bbec9a7db8501dd0df4bfaa37be8bc75cb5892a

The patch didn't apply cleanly in messenger.css, please check the result.

Comment 21

[Jorg K (CEST = GMT+2)]

TB 52 ESR:
https://hg.mozilla.org/releases/comm-esr52/rev/916c12d20362