1359297 - "Next" button not working on Gmail's Oauth google login panel with disablehistory="true" fixed in 52.1.0

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Dailison]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170413192749

Steps to reproduce:

When i try to connect my gmail in Thunderbird the button Next and notting of that window not work.


Actual results:

When i try to connect my gmail in Thunderbird the button Next not work

Comment 1

[Jorg K (CEST = GMT+2)]

Please note: Bugzilla is NOT a support forum. It is a tracking system for bugs in Mozilla products.
This is a support question. You can get support here:
https://support.mozilla.org/en-US/products/thunderbird

Comment 2

[Dailison]

"Please note: Bugzilla is NOT a support forum. It is a tracking system for bugs in Mozilla products.
This is a support question. You can get support here:
https://support.mozilla.org/en-US/products/thunderbird"

I'm short about that my friend, i'm a programmer too.

I have installed Thunderbird for the first time, when i tryed to Log-in into my account gmail the window just Freezes.

If you say for me isn't a bug, you need to contract me to do you job.

Ok, let's go.

Gmail needs an two factor authentication, when i try to open the window for authorize the Thunderbird application, that window just Freezes and i can't click in any buttons.


http://prntscr.com/f0m7gv

If you need more information, i'm here.


I'm a Mozilla lover, and i'd like to use Thunderbird

Comment 3

[Richard Marti (:Paenglab)]

Jörg, I can't check now. Could it be the same as bug 1359383 with a similar solution?

Comment 4

[Jorg K (CEST = GMT+2)]

That bug is about the Gdata provider for calendar and I don't think it's related. That bug suggests to "enable history", but I don't know what this means in the context of TB.

In any case, the user should direct the query to the support forum where they will already know such problems.

Comment 5

[Dailison]

Ok, i have unninstalled Thunderbird and on the next time i have installed http://www.emclient.com/, and i maked the SAME steps, the window oppened in emclient is the same, but the Next Button works.

I have sucess where using http://www.emclient.com/ using the same steps, and authenticating with the same window.

If you think all users will come here to report this problem, I think you're mistaken.

He just go to use another e-mail client like Outlook.

Comment 6

[Richard Marti (:Paenglab)]

(In reply to Jorg K (GMT+2) from comment #4)
> That bug is about the Gdata provider for calendar and I don't think it's
> related. That bug suggests to "enable history", but I don't know what this
> means in the context of TB.

In the other bug the authentication doesn't go further in the oauth login window and the screenshot in comment 2 looks similar to the description in bug 1359383.

New GMail accounts use also the oauth authentication like the Gdata provider for calendar.

Comment 7

[Jorg K (CEST = GMT+2)]

Any errors logged in the error console?
Tools > Developer Tools > Error Console.

Comment 8

[Jorg K (CEST = GMT+2)]

Attachment: Screnshot with Oauth panel

In fact, I have just set up my own Gmail account in a new profile using TB 52 ESR. The panel looked different to what is shown here: http://prnt.sc/f0m7gv and the setup worked without a problem.

The panel showed an e-mail address and a password field with a next button underneath.

Comment 9

[Dailison]

Ok, you don't have a two factor authentication enabled on your account, i think it's the diference.

I'm from another Country

Comment 10

[Dailison]

The error log:

http://prntscr.com/f0n4qu

Comment 11

[Jorg K (CEST = GMT+2)]

(In reply to Dailison from comment #9)
> Ok, you don't have a two factor authentication enabled on your account, i
> think it's the diference.
I do. They sent me an SMS to complete the transaction.

Matt and Magnus: Have we seen problems like documented here?

Comment 12

[Dailison]

Ok, it's a normal procedure, when you have two factor and a password for insecure application you need to use Google Autenticator Application, or Google application.

Comment 13

[Magnus Melin [:mkmelin]]

Philipp, since you know bug 1359383, should disablehistory be removed from the mail version too?

https://dxr.mozilla.org/comm-central/source/mail/base/content/browserRequest.xul#33

Comment 14

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Yes, I'd suggest to do so. If you want to go a step further you could also enable private browsing mode, but I don't think that would be a major gain.

Comment 15

[Richard Marti (:Paenglab)]

Attachment: browserRequest.patch

I removed disablehistory="true" from all browserRequest.xul in our tree (chat, mail and suite).

Comment 16

[Magnus Melin [:mkmelin]]

Comment on attachment 8861938 [details] [diff] [review]
browserRequest.patch

Review of attachment 8861938 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thx Richard! r=mkmelin

Comment 17

[Richard Marti (:Paenglab)]

Thank you.

Comment 18

[Jorg K (CEST = GMT+2)]

C-C (TB 55): https://hg.mozilla.org/comm-central/rev/540cd06b1aea0bfa6f906b86393f5480914c01c2
C-B (TB 54): https://hg.mozilla.org/releases/comm-beta/rev/d74151d79d17ee03b9de44842866e3f929339f0c

Comment 19

[Dailison]

I'm newbie, i need to wait one release with the fix to use Thunderbird?
How much time i need to wait?

@Jorg K, sorry for that commentary:
https://bugzilla.mozilla.org/show_bug.cgi?id=1359297#c2

Comment 20

[Jorg K (CEST = GMT+2)]

Just for you, I landed this fix. You can try it in tomorrow's Daily build or in TB 54 beta coming out in a few days.

I'm also sorry for closing this bug too early, but in the end, we worked something out. Thanks for the persistence.

Comment 21

[Wayne Mery (:wsmwk)]

This isn't a regression??

Comment 22

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Not one in the sense that we broke it in a different bug. The change was in Google's login window which is remote content. But going by the definition that it worked before and was now broken, it is a regression.

Comment 23

[Wayne Mery (:wsmwk)]

Is version 45 affected?

Comment 26

[Brandon M]

Sorry for the Duplicate bug. Thank you for the fix!!

Comment 29

[Jorg K (CEST = GMT+2)]

TB 52 ESR:
https://hg.mozilla.org/releases/comm-esr52/rev/019bedf1ec44515b479d5dc75687c56d96fbdd3c

Comment 30

[Feathers]

TB 54.0a2 still not producing desired result. Authoriztion page has broken buttons while auth works in regular chrome browser.

passwords stored in Tools>Options are not applied here and have not been updated along with new password changes in the past year.

still unable to use Gmail in Thunderbird. did not make any changes to account or update any .xul or anything, the problem just started after two password changes within 24 hours. worked fine on TB45.x and the next morning password was changed again on another computer (mac) and going back to TB 45.x on windows wouldn't authorize: Next button broke. updated to TB52 and downloaded EB54 and same result: unable to update PW or use TB

support forum is broke cannot register or comment https://support.mozilla.org/en-US/questions/1157498 

EarlyBird54 still has this problem and it is not fixed or resolved.

Thanks

Comment 31

[Richard Marti (:Paenglab)]

Feathers, TB 54.0a2 is the aurora channel and gets any changes since around one or two week (also when you get updates, there are no new check-ins). Please wait for a 54 beta or move to a1 (Daily) channel.

Comment 32

[Wayne Mery (:wsmwk)]

Earlybird/aurora channel is recently deprecated and no longer getting patches. 
You will want to use nightly [1], or wait for updates next week in the form of 54.0b1 and 52.1.0

[1] https://archive.mozilla.org/pub/thunderbird/nightly/latest-comm-central/

Comment 33

[Feathers]

OK thank you everyone, sorry for bringing support stuff to the wrong side of the tracks.

did get signed in per https://bugzilla.mozilla.org/show_bug.cgi?id=1359383

Due to Google not catching an error if the history is disabled, the oauth login dialog no longer allows you to click on next. Enabling history fixes the issue and should be fine since it is a confined browser element.

except did not know where to find "Enabling history"

Activity Controls was the word found and just turning on the first toggle did not do the trick. Toggled on Web & App Activity, Device Information, and YouTube Search History. Think Device Information is what it needed.

https://myaccount.google.com/activitycontrols

Cheers

Comment 34

[u594557]

Feathers, I am a TB user for many years. Could you help me understand in laymen's terms what I need to do to fix this. I cant wait until next week for an update from TB to get back into operation. My knowledge is way below a programmer etc.  

On 4/25 I had to change my Google password someone trying to log in form another state. Lucky me, so on 4/25 after all that I opened TB &  nothing new  in or out, miraculously 4/26 incoming started working & it downloaded a lot of mail,   then on evening of 4/27 both in or out, gone again.    My problems of course are exactly the same as everyone else.  I would appreciate any help.

Comment 35

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

(In reply to Feathers from comment #33)
> except did not know where to find "Enabling history"
This is exactly what the patch on this bug does. It is not a user setting that can be changed.

(In reply to RGH from comment #34)
> Feathers, I am a TB user for many years. Could you help me understand in
> laymen's terms what I need to do to fix this. I cant wait until next week
> for an update from TB to get back into operation. My knowledge is way below
> a programmer etc.  
RGH, while I appreciate that you would like to get this patch working as soon as possible, I'd appreciate if you could discuss this outside of this bug, either using the support forums or privately.

If you want to test this patch you have the option of using a nightly build, with the usual caveats that alpha versions carry, or to apply this patch manually. The latter option requires technical knowledge and is not easily done.

That said, we are working on providing a Thunderbird 52 release that contains this patch as soon as possible, as this issue affects a fair amount of users.

Comment 36

[Wayne Mery (:wsmwk)]

Unfortuantely most of the support topics don't have workarounds listed.

Possible workarounds in https://bugzilla.mozilla.org/show_bug.cgi?id=1359297#user-story

Comment 37

[Feathers]

right-o everyone


In reply to Philipp Kewisch [:Fallen] from comment #35)
> (In reply to Feathers from comment #33)
> > except did not know where to find "Enabling history"
> This is exactly what the patch on this bug does. It is not a user setting
> that can be changed.

thanks for clarifying. noticed that i must be terribly lost. but i did get it to work! found that the term being used here correlates to a term in google account settings. had to adjust that setting inside my google account and was able to switch it back off after authorizatioin. 



(In reply to RGH from comment #34)
> Feathers, I am a TB user for many years. Could you help me understand in
> laymen's terms what I need to do to fix this. I cant wait until next week
> for an update from TB to get back into operation. My knowledge is way below
> a programmer etc.  
> 
> On 4/25 I had to change my Google password someone trying to log in form
> another state. Lucky me, so on 4/25 after all that I opened TB &  nothing
> new  in or out, miraculously 4/26 incoming started working & it downloaded a
> lot of mail,   then on evening of 4/27 both in or out, gone again.    My
> problems of course are exactly the same as everyone else.  I would
> appreciate any help.



yeah man wrong place for that. see above (Feathers from comment #33) for my storyfix and personal workaround or move over to here at 2nd page at https://support.mozilla.org/en-US/questions/1157498?page=2

Comment 38

[Wayne Mery (:wsmwk)]

results reported by 52.1.0 users are favorable. 

however, has anything changed at google in the last couple days?  http://forums.mozillazine.org/viewtopic.php?p=14745619#p14745619
states "The issue was solved for me (by Google?) a couple of days ago - I got a different authentication window that worked."

Comment 39

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

There seem to be two different login windows, one with that non-working next button, and another where it works. They are testing a new login dialog, so the frantic next-clicking (that reports the js error to Google) might have caused some rolling back on their end.

I'm getting a few reports for the Provider for Google Calendar that the wrong account is being used, but I haven't been able to confirm this behavior. We should keep an eye out for it!

Comment 40

[Chriss De Grece]

Bug also affects Earlybird 54.0a2 (2017-05-02)

Changed my gmail password and now the "Next" button doesn't work.

Comment 41

[Jorg K (CEST = GMT+2)]

The Earlybird Channel has been discontinued. It receives no updates. This is fixed in TB 52.1 and Daily (TB 55) and will be fixed in the coming TB 54 beta.

Comment 47

[najoll]

I *think* I've discovered what the workaround is, by trawling through the text above. Is it too much to ask that Mozilla or the Thunderbird developers provide a more visible, clearer statement of the workaround - perhaps on this thread and also on the Thunderbird download page? Otherwise lots of people are going to be getting frustrated by this problem. K

Comment 48

[najoll]

Here is THE FIX THAT WORKED FOR ME.

Start of fix
=============

First: in Thunderbird, go to Account Settings -> [Google account] -> Server settings -> Authentication method. Change that method to 'normal password'.

Second: still in Thunderbird, go to Account Settings -> Outgoing server -> select [Google server] -> click 'edit', and then change 'authentication method' to 'normal password'.

End of fix
===========

It seems to me that, in order to solve our problem of the unclickable 'next button', using Google's webpages to change their spyware settings is neither necessary nor effective.

Comment 49

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I believe this only works if you enable the setting to "Allowing less secure apps to access your account", which is not the default in Google settings. It also scares away a fair amount of users.

Comment 50

[Nico]

Came here to mention early bird has had this bug for a while now, but it seems others have already done that.

Comment 51

[Jorg K (CEST = GMT+2)]

The Earlybird channel was discontinued a while ago. This is working in TB 52.1 and TB 55 Daily.

Comment 52

[Nico]

If earlybird is discontinued. Then why is it available for download as "newest innovations" ? If you want to mislead your customers, that's one very effective way of doing it.
I've been using thunderbird for years, but i thought i'd step up and help providing feedback etc. So one would naturally assume that earlybird is the latest and not a discontinued product some web designers were just too lazy to remove.

Comment 53

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Hi Nico, I'm sorry for the inconvenience. The channel was discontinued with the last merge following what Firefox is doing. The plan is to make automatic updates route Earlybird users to the beta channel, but we haven't gotten around to doing this! I can understand that it is a bit confusing the way we have it now.

Comment 55

[Nico]

(In reply to Philipp Kewisch [:Fallen] from comment #53)
I can understand there's a transition between things but it wouldn't have taken much to edit the text on the earlybird site informing users, maybe change the download link for earlybird to the new place, or even go as far as creating an update for earlybird that just adds some popup text. I just find it odd that considering how little effort it would've taken nothing was done. I'm most likely not the only one who didn't know earlybird was a discontinued product.

Comment 56

[Matt]

(In reply to Nico from comment #55)
> (In reply to Philipp Kewisch [:Fallen] from comment #53)
> I can understand there's a transition between things but it wouldn't have
> taken much to edit the text on the earlybird site informing users, maybe
> change the download link for earlybird to the new place, or even go as far
> as creating an update for earlybird that just adds some popup text. I just
> find it odd that considering how little effort it would've taken nothing was
> done. I'm most likely not the only one who didn't know earlybird was a
> discontinued product.

This is a volunteer organization so, if you have the time please get to fixing it.  Otherwise, be respectful of the fact the others here simply don't have time for this at the moment.

Comment 57

[Nico]

(In reply to Matt from comment #56)

I don't know what your point is or why you'd want to continue. I've given some constructive criticism and that's the end of it for my part, the information is free and if that means that a tiny bell will ring in someone head in a similar future scenario. Well then that's just fantastic. But, no need dragging me back into this.

Comment 58

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

All, lets keep in mind that Nico is actually right and the fact that we haven't changed the website and haven't migrated users is our fault. It is true that Thunderbird is a volunteer effort and that we need to wait until someone has time, but lets be mindful about observations such as these.

Nico, we appreciate your feedback and agree that it would be ideal if the website would show this correctly. We'll work on fixing this soon, although I can't promise when we'll get around to it. It is indeed not much to change the website, the auto-updating is a bit more involved. We're looking forward to future bug reports from you on the beta channel!

If there is further need for discussion lets take care off of this bug, but I think we've reached a common understanding here.

Comment 60

[Aaditya Bagga]

I have same issue on Thunderbird 45.8.0. Is it still supported?

Same message in terminal as https://bugzilla.mozilla.org/show_bug.cgi?id=1360501

Comment 61

[Wayne Mery (:wsmwk)]

(In reply to Aaditya Bagga from comment #60)
> I have same issue on Thunderbird 45.8.0. Is it still supported?

This will not be fixed in 45.x. You'll need to update to 52.

Comment 62

[smnbldwn]

I am using 45 as it is the current version for Ubuntu 16.04 powerpc. Is this going to be upgraded?

Comment 63

[Jorg K (CEST = GMT+2)]

No. TB 45 has reached the end of its life cycle. You can of course hack it. Unpack omni.ja, edit the files, pack omni.ja again or keep working on the flat install (in which case you need to delete omni.ja). There are hints on the web with instructions.

Comment 64

[Matthew S]

(In reply to Jorg K (GMT+2) from comment #51)
> The Earlybird channel was discontinued a while ago. This is working in TB
> 52.1 and TB 55 Daily.

/thunderbird/channel/ is still making reference to Earlybird in the description copy. I'm not sure if the reference is meant to state Earlybird and Beta are one and the same, or if it's old text that hasn't been modified. If the latter, I'd be more than happy to go in and snip that part out.

I apologize for replying here, this was the only spot I noticed issue was taken with the website in regards to the Earlybird channel.

Comment 65

[Matt]

This is fixed for me in Thunderbird 52.6.0 (64-bit). (Not 55 as quoted on the ticket)

Comment 66

[zunivum]

NOT FIXED FOR ME I AM ON UNUPGRADABLE VERSION 49.0 ON MAC OS X 10.7.5
Please provide the fix for this version, the thunderbird should work on all distros not only on new imacs (YES its necessary to upgrade hardware in order to use OS X >10.8 for Mac Pro users)

Comment 68

[Aahz]

(In reply to najoll from comment #48)

Here is THE FIX THAT WORKED FOR ME.

Start of fix

First: in Thunderbird, go to Account Settings -> [Google account] -> Server
settings -> Authentication method. Change that method to 'normal password'.

Second: still in Thunderbird, go to Account Settings -> Outgoing server ->
select [Google server] -> click 'edit', and then change 'authentication
method' to 'normal password'.

End of fix

It seems to me that, in order to solve our problem of the unclickable 'next
button', using Google's webpages to change their spyware settings is neither
necessary nor effective.

Your solution is genius simple, thanks, v 38.5.0 here, this solved my issue.

Comment 69

[ziggy90127]

(In reply to najoll from comment #48)

Here is THE FIX THAT WORKED FOR ME.

Start of fix

First: in Thunderbird, go to Account Settings -> [Google account] -> Server
settings -> Authentication method. Change that method to 'normal password'.

Second: still in Thunderbird, go to Account Settings -> Outgoing server ->
select [Google server] -> click 'edit', and then change 'authentication
method' to 'normal password'.

End of fix

It seems to me that, in order to solve our problem of the unclickable 'next
button', using Google's webpages to change their spyware settings is neither
necessary nor effective.

This works for TB 45, and additionally I had to go to https://myaccount.google.com/security#signin and generate an "App Password", as the previous advice about "Allowing less secure apps to access your account" is old.

Google's page says "App passwords let you sign in to your Google Account from apps on devices that don't support 2-Step Verification. You'll only need to enter it once so you don't need to remember it."

Comment 70

[ziggy90127]

(In reply to ziggy90127 from comment #69)

My cousin's Google account doesn't have App Passwords, but does have "Allowing less secure apps to access your account". I guess there's 2 types of Google accounts.