Closed Bug 1364302 Opened 3 years ago Closed 3 years ago
External Image() handling
HoldExternalImage() worked correctly when it is implemented. But it seems not work correctly since Bug 1355702 fix. In the past, ImageKey was generated on every transaction. But now ImageKey is not generated for each transaction. HoldExternalImage() start holding when ImageKey for external image id is created in WebRenderBridgeParent. And end holding its TextureHost when epoc of HoldExternalImage() called was ended on RenderThread. We do not hold TextureHost for enough period now.
Assignee: nobody → sotaro.ikeda.g
(In reply to Sotaro Ikeda [:sotaro] from comment #0) > HoldExternalImage() worked correctly when it is implemented. But it seems > not work correctly since Bug 1355702 fix. Bug 1337761 also seems to be related.
Attachment #8867081 - Flags: review?(nical.bugzilla)
Attachment #8867081 - Flags: review?(nical.bugzilla) → review+
Pushed by email@example.com: https://hg.mozilla.org/projects/graphics/rev/67ca59cd3d03 Fix HoldExternalImage() handling r=nical
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
I am still hitting crashes in [@ mozilla::wr::LockExternalImage ] in the latest nightly: https://crash-stats.mozilla.com/report/index/3afeee47-cff4-4bb8-acf1-067ad0170627. Using Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:56.0) Gecko/20100101 Firefox/56.0 ID:20170627100238 CSet: 53477d584130945864c4491632f88da437353356 Sotaro should I file a new bug or should we reopen this one?
:marcia, can you file a new bug? Thanks!
You need to log in before you can comment on or make changes to this bug.