Closed
Bug 1367894
Opened 7 years ago
Closed 7 years ago
Refactor the JSON Viewer stream converter
Categories
(DevTools :: JSON Viewer, defect)
DevTools
JSON Viewer
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: Oriol, Assigned: Oriol)
References
Details
Attachments
(1 file, 1 obsolete file)
|
17.16 KB,
patch
|
Honza
:
review+
|
Details | Diff | Splinter Review |
The stream converter is completely buggy. This patch fixes - Bug 1364794, bug 1224071, bug 1327752, bug 1327753, and probably bug 1365804 (big files became corrupted) - Bug 1364953 (NUL truncated the source) - Bug 1367881 (UTF-8 was not enforced) (tests should be added in the respective bugs) The problems are - With the approach I used, I couldn't find a simple way to trigger standards mode instead of quirks one. I thought about document.write("<!DOCTYPE html>") but that breaks various other things and gets so messy. - Adding the stylesheets at the end causes relayout. And the font-size changes, which is ugly. Maybe inserting a Link header could fix this. I think it's worth it anyways, the problems can be addressed in other bugs.
Attachment #8871441 -
Flags: review?(odvarko)
|
Assignee | |
Comment 1•7 years ago
|
||
Forgot to fix eslint complaints.
Assignee: nobody → oriol-bugzilla
Attachment #8871441 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8871441 -
Flags: review?(odvarko)
Attachment #8871449 -
Flags: review?(odvarko)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8871449 [details] [diff] [review] json-stream.patch Review of attachment 8871449 [details] [diff] [review]: ----------------------------------------------------------------- This is excellent! R+ Thanks for working on this. Honza
Attachment #8871449 -
Flags: review?(odvarko) → review+
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3c3ddcb925d1 Refactor the JSON Viewer stream converter. r=Honza
Keywords: checkin-needed
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3c3ddcb925d1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•