1369786 - Remove drag space at the start of the tab strip in maximized windows

Status: VERIFIED FIXED

(Firefox :: Theme, enhancement, P1)

Description

[Dão Gottwald [:dao]]

Based on https://people-mozilla.org/~shorlander/projects/photon/Mockups/windows-10.html, it seems that the drag space at the start of the tab strip is meant to appear in non-maximized windows but not in maximized ones.

Comment 2

[Dão Gottwald [:dao]]

Just need to replace :root[tabsintitlebar] with :root[tabsintitlebar][sizemode=normal] here:

http://searchfox.org/mozilla-central/source/browser/themes/shared/browser.inc.css#9,13

Comment 4

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: Remove drag space at the start of the tab strip in maximized windows.diff

I created patch (using kinda hacky old school method, so with Notepad and without compiling source code) basing on Comment #2. Does it look good?

Comment 5

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: Remove drag space at the start of the tab strip in maximized windows v2.diff

Fixing "file_not_specified_in_diff" based on other patches from "Theme" Component.

Comment 6

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(In reply to Virtual_ManPL [:Virtual] - (please needinfo? me - so I will see your comment/reply/question/etc.) from comment #5)
> Fixing "file_not_specified_in_diff" based on other patches from "Theme" Component.
That didn't fix that,
but looks like it's probably only PatchReader issue, which is being tracked in bug #752878.

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 8874554 [details] [diff] [review]
Remove drag space at the start of the tab strip in maximized windows v2.diff

Looks okay-ish but the patch doesn't seem to apply. Did you use hg diff to produce the patch?

applying ../Remove drag space at the start of the tab strip in maximized windows v2.diff
patching file browser/themes/shared/browser.inc.css
Hunk #1 FAILED at 6
1 out of 1 hunks FAILED -- saving rejects to file browser/themes/shared/browser.inc.css.rej
abort: patch failed to apply

Comment 8

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(In reply to Dão Gottwald [::dao] from comment #7)
> Did you use hg diff to produce the patch?
Like I said in Comment #4, I just used Notepad.

Comment 9

[Dão Gottwald [:dao]]

Will you be able to use hg diff to produce a correctly formatted patch?

Comment 10

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: Remove drag space at the start of the tab strip in maximized windows v3.patch

(In reply to Dão Gottwald [::dao] from comment #9)
> Will you be able to use hg diff to produce a correctly formatted patch?

I would like to try one more time my method of creating patches, as maybe I used wrong character encoding format, and I remember that it worked fore sure in the past, like in the bug #801386.
As for now, I'm not permitted to install any additional and external software on that system, so using Mercurial in very close time won't be possible, so other person could take this bug, if using Mercurial is needed to create the patch.

Comment 11

[Dão Gottwald [:dao]]

Comment on attachment 8874789 [details] [diff] [review]
Remove drag space at the start of the tab strip in maximized windows v3.patch

applying ../Remove drag space at the start of the tab strip in maximized windows v3.patch
patching file browser/themes/shared/browser.inc.css
Hunk #1 FAILED at 6
1 out of 1 hunks FAILED -- saving rejects to file browser/themes/shared/browser.inc.css.rej
abort: patch failed to apply

Comment 12

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

It's over my head why it fails.

Comment 13

[Ekanan Ketunuti]

Attachment: bug1369786_75b700c7225a.patch

Comment 14

[Dão Gottwald [:dao]]

Comment on attachment 8874797 [details] [diff] [review]
bug1369786_75b700c7225a.patch

Looks good. Thanks!

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e14ae1885dc
Remove drag space at the start of the tab strip in maximized windows. r=dao

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1e14ae1885dc

Comment 17

[Johann Hofmann [:johannh]]

Screenshots are looking good:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=fd04166b7114949ce63783e10a069b98d76df573&newProject=mozilla-central&newRev=5801aa478de12a62b2b2982659e787fcc4268d67

Comment 18

[Brindusa Tot, DTE]

Verified on latest Nightly 56.0a1 on Windows 10 and Mac OS 10.12.

On Mac OS X, the drag space is not smoothly removed, I logged a separate bug for this - please see bug 1372535.