1380437 - Implement REST API utility methods in global.js to replace bugzilla_ajax(), eliminate JSON-RPC usage

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, task)

Description

[Dylan Hardison [:dylan] (he/him)]

Per IRC chat, bugzilla_ajax() is very useful and should be available at all times.

Comment 1

[Kohei Yoshino [:kohei]]

* Use Promise and fetch instead of XHR
* Append the API key to the HTTP request header instead of query string

This will eventually replace jQuery.ajax, jQuery.getJSON and YAHOO.util.XHRDataSource.

Comment 2

[Kohei Yoshino [:kohei]]

And YAHOO.util.Connect.asyncRequest

Comment 3

[Kohei Yoshino [:kohei]]

One more note: since fetch() doesn't support the progress event [1], XMLHttpRequest is still required especially for uploading (large) attachments while showing a progress bar. So my plan is having both `Bugzilla.io.fetch` and `Bugzilla.io.xhr`.

[1] https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/Using_XMLHttpRequest#Monitoring_progress

Comment 4

[Kohei Yoshino [:kohei]]

The `generate_api_token` variable could be removed as part of this change. It should be defaulted to 1 at least.

Comment 5

[Kohei Yoshino [:kohei]]

WIP: https://github.com/kyoshino/bmo/compare/bug-1380437-bugzilla-ajax

Comment 6

[Kohei Yoshino [:kohei]]

bugzilla_ajax() has already been moved from bug_modal.js to global.js as part of Bug 1472954. This bug’s scope has changed.

Comment 7

[Kohei Yoshino [:kohei]]

Attachment: pull request

Comment 8

[Kohei Yoshino [:kohei]]

Merged to master.

Comment 9

[Kohei Yoshino [:kohei]]

Attachment: GitHub Pull Request - follow-up to send API key only if available