1477931 - Show number of review/feedback/needinfo in user autocomplete and prevent person from being added if requests are blocked

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, enhancement)

Description

[Pascal Chevrel:pascalc (PTO until Sept 2)]

It would be nice when you needinfo somebody that once you have selected the person, the number of pending needinfos be displayed next to their name or in a tooltip.

The reason is that if I see that a person is swamped with needinfos and the issue is urgent, I may want to needinfo another developer.

See mockup attached for a possible UX.

The need is mostly in the showbug view but having it in both showbug and editbug views.

Thanks

Comment 1

[Pascal Chevrel:pascalc (PTO until Sept 2)]

Attachment: mockup

Comment 2

[Kohei Yoshino [:kohei]]

Attachment: suggested reviewers screenshot

Reviewer suggestions are already showing their current review count.

Comment 3

[Kohei Yoshino [:kohei]]

Attachment: prototype screenshot

Added Gravatar as well.

Comment 4

[Kohei Yoshino [:kohei]]

WIP: https://github.com/kyoshino/bmo/compare/bug-1477931-request-count

This works but partially conflicts with Bug 1380437 so I’ll send a PR once the other bug is solved.

Comment 5

[Kohei Yoshino [:kohei]]

Attachment: prototype screenshot v2

Comment 6

[Kohei Yoshino [:kohei]]

We should solve Bug 1320977 as well.

Comment 7

[Kohei Yoshino [:kohei]]

Attachment: prototype screenshot v3

People blocking requests will be indicated and won’t be selected.

Comment 8

[Kohei Yoshino [:kohei]]

The behaviour isn’t the best; the blocking person(s) will still be selected in the dropdown list. They should be displayed but disabled. It’s a limitation of the autocomplete jQuery plug-in which I’m going to replace in Bug 967525.

Comment 9

[Kohei Yoshino [:kohei]]

(In reply to Kohei Yoshino [:kohei] from comment #4)
> This works but partially conflicts with Bug 1380437 so I’ll send a PR once
> the other bug is solved.

Will solve the conflict rather in Bug 1380437.

Comment 10

[Kohei Yoshino [:kohei]]

Attachment: pull request

Comment 11

[Kohei Yoshino [:kohei]]

Merged to master \o/

Comment 12

[Kohei Yoshino [:kohei]]

Gah, this is not working. Have to revert PR #946 since both Gravatar and requests are provided by extensions.

Comment 13

[Kohei Yoshino [:kohei]]

Attachment: GitHub Pull Request to revert PR #946

Comment 14

[Kohei Yoshino [:kohei]]

Attachment: GitHub Pull Request to revert PR #946

The previous PR was merged but backed out before the last release to avoid an overload. This is the same one.

Comment 15

[Dylan Hardison [:dylan] (he/him)]

I'm going to add in those fields using one query and avoid calling the slow extension code too (but the biggest win is the single SQL query)

Comment 16

[Kohei Yoshino [:kohei]]

This has been blocked by Dylan’s Captain Hook PR which is now filed as Bug 1559988.

Comment 17

[Kohei Yoshino [:kohei]]

Attachment: GitHub Pull Request - follow-up to make UI change

Comment 18

[Kohei Yoshino [:kohei]]

Merged to master.