1386265 - Exclude tippy top images directory from browser_all_files_referenced.js

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Ed Lee :Mardak]

This is in preparation for those images being packaged but not all directly referenced during tests as each image urls are dynamically calculated/used when top sites would be shown.

Comment 1

[Ed Lee :Mardak]

Try with tippytop exported https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5a7af1d7666a79b4ee515c2b41ade1004252c1f

Comment 2

[Ed Lee :Mardak]

Attachment: Bug 1386265 - Exclude tippy top images directory from browser_all_files_referenced.js.

Review commit: https://reviewboard.mozilla.org/r/163430/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163430/

Comment 3

[Ed Lee :Mardak]

Try without tippytop exported https://treeherder.mozilla.org/#/jobs?repo=try&revision=de328569512b

Sorry for the wonky failures. I forgot that the "static" directory is only run on non-debug non-linux32 builds.

Comment 4

[Ursula Sarracini (:ursula)]

Comment on attachment 8892457 [details]
Bug 1386265 - Exclude tippy top images directory from browser_all_files_referenced.js.

https://reviewboard.mozilla.org/r/163430/#review168836

looks good, thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4d89120f88d
Exclude tippy top images directory from browser_all_files_referenced.js. r=ursula

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c4d89120f88d

Comment 7

[Ed Lee :Mardak]

Comment on attachment 8892457 [details]
Bug 1386265 - Exclude tippy top images directory from browser_all_files_referenced.js.

Approval Request Comment (part 2 of 6 Mardak will uplift)
[Feature/Bug causing the regression]: Activity Stream preffed off in 56 to be enabled in Shield study
[User impact if declined]: Unable to uplift the rest of Activity Stream 56 changes due to test failures
[Is this code covered by automated tests?]: Yes this is the test
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: Bug 1385716 Bug 1386350 Bug 1385090 Bug 1386314 Bug 1386737
[Is the change risky?]: No
[Why is the change risky/not risky?]: This is making the test not fail when other changes land
[String changes made/needed]: No

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8892457 [details]
Bug 1386265 - Exclude tippy top images directory from browser_all_files_referenced.js.

Needed for Activity Stream testing in 56. This should make it into 56 beta 1.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/62fa439e3c0d

Comment 10

[Andrei Vaida [:avaida]]

(In reply to Ed Lee :Mardak from comment #7)
> [Is this code covered by automated tests?]: Yes this is the test
> [Has the fix been verified in Nightly?]: Yes
> [Needs manual test from QE? If yes, steps to reproduce]: No

Setting qe-verify- based on Ed Lee's assessment on manual testing needs and the fact that this fix has automated coverage.