Turn off snippets in activity stream for tests

RESOLVED FIXED in Firefox 56

Status

()

Firefox
Activity Streams: Newtab
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: k88hudson, Assigned: k88hudson)

Tracking

unspecified
Firefox 57
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox56 fixed, firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

6 months ago
As we are about to pref on snippets on activity stream, we need to turn them off in tests to prevent network calls
Comment hidden (mozreview-request)
(Assignee)

Updated

6 months ago
Attachment #8892558 - Flags: review?(dmose)
(Assignee)

Updated

6 months ago
Assignee: nobody → khudson
Comment hidden (mozreview-request)

Comment 3

6 months ago
mozreview-review
Comment on attachment 8892558 [details]
Bug 1386350 - Turn off snippets in activity stream for tests

https://reviewboard.mozilla.org/r/163564/#review168918

Looks good, r=dmose
Attachment #8892558 - Flags: review?(dmose) → review+

Comment 4

6 months ago
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/877a7dc33e3d
Turn off snippets in activity stream for tests r=dmose

Comment 5

6 months ago
We're sorry - something has gone wrong while rewriting or rebasing your commits. The commits being pushed no longer match what was requested. Please file a bug.

Comment 6

6 months ago
We're sorry - something has gone wrong while rewriting or rebasing your commits. The commits being pushed no longer match what was requested. Please file a bug.

Comment 7

6 months ago
I think multiple people tried to autoland multiple times. It actually landed in comment 4.

Updated

6 months ago
Duplicate of this bug: 1386426

Updated

6 months ago
Blocks: 1386785

Comment 9

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/877a7dc33e3d
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57

Comment 10

6 months ago
Comment on attachment 8892558 [details]
Bug 1386350 - Turn off snippets in activity stream for tests

Approval Request Comment (part 3 of 6 Mardak will uplift)
[Feature/Bug causing the regression]: Activity Stream preffed off in 56 to be enabled in Shield study
[User impact if declined]: Unable to uplift the rest of Activity Stream 56 changes due to test failures
[Is this code covered by automated tests?]: Yes, many tests are negatively impacted without this
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: Bug 1385716 Bug 1386265  Bug 1385090 Bug 1386314 Bug 1386737
[Is the change risky?]: No
[Why is the change risky/not risky?]: This is pre-preffing off functionality that doesn't exist
[String changes made/needed]: No
Attachment #8892558 - Flags: approval-mozilla-beta?
status-firefox56: --- → affected
Comment on attachment 8892558 [details]
Bug 1386350 - Turn off snippets in activity stream for tests

Test fix in order to get some other Activity Stream uplifts to beta 56.
Attachment #8892558 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 12

6 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/8e84cc9bb922
status-firefox56: affected → fixed
(In reply to Ed Lee :Mardak from comment #10)
> [Is this code covered by automated tests?]: Yes, many tests are negatively
> impacted without this
> [Has the fix been verified in Nightly?]: Yes
> [Needs manual test from QE? If yes, steps to reproduce]: No

Setting qe-verify- based on Ed Lee's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.