1386350 - Turn off snippets in activity stream for tests

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Kate Hudson :k88hudson]

As we are about to pref on snippets on activity stream, we need to turn them off in tests to prevent network calls

Comment 1

[Kate Hudson :k88hudson]

Attachment: Bug 1386350 - Turn off snippets in activity stream for tests

Review commit: https://reviewboard.mozilla.org/r/163564/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163564/

Comment 2

[Kate Hudson :k88hudson]

Comment on attachment 8892558 [details]
Bug 1386350 - Turn off snippets in activity stream for tests

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/163564/diff/1-2/

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8892558 [details]
Bug 1386350 - Turn off snippets in activity stream for tests

https://reviewboard.mozilla.org/r/163564/#review168918

Looks good, r=dmose

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/877a7dc33e3d
Turn off snippets in activity stream for tests r=dmose

Comment 5

[Mozilla Autoland]

We're sorry - something has gone wrong while rewriting or rebasing your commits. The commits being pushed no longer match what was requested. Please file a bug.

Comment 6

[Mozilla Autoland]

We're sorry - something has gone wrong while rewriting or rebasing your commits. The commits being pushed no longer match what was requested. Please file a bug.

Comment 7

[Ed Lee :Mardak]

I think multiple people tried to autoland multiple times. It actually landed in comment 4.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/877a7dc33e3d

Comment 10

[Ed Lee :Mardak]

Comment on attachment 8892558 [details]
Bug 1386350 - Turn off snippets in activity stream for tests

Approval Request Comment (part 3 of 6 Mardak will uplift)
[Feature/Bug causing the regression]: Activity Stream preffed off in 56 to be enabled in Shield study
[User impact if declined]: Unable to uplift the rest of Activity Stream 56 changes due to test failures
[Is this code covered by automated tests?]: Yes, many tests are negatively impacted without this
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: Bug 1385716 Bug 1386265  Bug 1385090 Bug 1386314 Bug 1386737
[Is the change risky?]: No
[Why is the change risky/not risky?]: This is pre-preffing off functionality that doesn't exist
[String changes made/needed]: No

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8892558 [details]
Bug 1386350 - Turn off snippets in activity stream for tests

Test fix in order to get some other Activity Stream uplifts to beta 56.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8e84cc9bb922

Comment 13

[Andrei Vaida [:avaida]]

(In reply to Ed Lee :Mardak from comment #10)
> [Is this code covered by automated tests?]: Yes, many tests are negatively
> impacted without this
> [Has the fix been verified in Nightly?]: Yes
> [Needs manual test from QE? If yes, steps to reproduce]: No

Setting qe-verify- based on Ed Lee's assessment on manual testing needs and the fact that this fix has automated coverage.