Closed Bug 1386314 Opened 3 years ago Closed 3 years ago

Add default icons, enable snippets and bug fixes to Activity Stream

Categories

(Firefox :: New Tab Page, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox56 --- fixed
firefox57 --- fixed

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

(Whiteboard: [export])

User Story

https://github.com/mozilla/activity-stream/compare/729f4c653209e6af0df98fcbd94709b794aeebcd...44ba8561d895a7defcf08d46d877a4d239395ecb

Attachments

(1 file)

No description provided.
User Story: (updated)
Summary: Add ... and bug fixes to Activity Stream → Add default icons, enable snippets and bug fixes to Activity Stream
Separately pushed to try as I needed to rebase on top of autoland https://treeherder.mozilla.org/#/jobs?repo=try&revision=a381effef3ae69f0daa120c90f6462905f267f1e
Comment on attachment 8892741 [details]
Bug 1386314 - Add default icons, enable snippets and bug fixes to Activity Stream.

https://reviewboard.mozilla.org/r/163728/#review169110

r=dmose
Attachment #8892741 - Flags: review?(dmose) → review+
Also pushed here in case artifact goes wonky from the rebased-onto-autoland: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd2925124893e13b6adf042c830aaebfbadc14a8
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/70cbfc193b9d
Add default icons, enable snippets and bug fixes to Activity Stream. r=dmose
Depends on: 1382703
Blocks: 1386737
Blocks: 1386785
https://hg.mozilla.org/mozilla-central/rev/70cbfc193b9d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment on attachment 8892741 [details]
Bug 1386314 - Add default icons, enable snippets and bug fixes to Activity Stream.

Approval Request Comment (part 5 of 6 Mardak will uplift)
[Feature/Bug causing the regression]: Activity Stream preffed off in 56 to be enabled in Shield study
[User impact if declined]: Users could see default sites with screenshots made with network connections instead of local high resolution icons
[Is this code covered by automated tests?]: Yes, Activity Stream has 100% line coverage
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: Bug 1385716 Bug 1386265 Bug 1386350 Bug 1385090 Bug 1386737
[Is the change risky?]: No
[Why is the change risky/not risky?]: The feature is preffed off
[String changes made/needed]: Localized strings were added
Attachment #8892741 - Flags: approval-mozilla-beta?
Comment on attachment 8892741 [details]
Bug 1386314 - Add default icons, enable snippets and bug fixes to Activity Stream.

Icon fix for Activity stream testing in beta 56. Let's uplift it.
Attachment #8892741 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Assignee: nobody → edilee
(In reply to Ed Lee :Mardak from comment #7)
> [Is this code covered by automated tests?]: Yes, Activity Stream has 100%
> line coverage
> [Has the fix been verified in Nightly?]: Yes
> [Needs manual test from QE? If yes, steps to reproduce]: No
> [List of other uplifts needed for the feature/fix]: Bug 1385716 Bug 1386265
> Bug 1386350 Bug 1385090 Bug 1386737
> [Is the change risky?]: No
> [Why is the change risky/not risky?]: The feature is preffed off
> [String changes made/needed]: Localized strings were added

Setting qe-verify- based on Ed Lee's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: qe-verify-
Whiteboard: [export]
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.