1386314 - Add default icons, enable snippets and bug fixes to Activity Stream

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1386314 - Add default icons, enable snippets and bug fixes to Activity Stream.

Review commit: https://reviewboard.mozilla.org/r/163728/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163728/

Comment 2

[Ed Lee :Mardak]

Separately pushed to try as I needed to rebase on top of autoland https://treeherder.mozilla.org/#/jobs?repo=try&revision=a381effef3ae69f0daa120c90f6462905f267f1e

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8892741 [details]
Bug 1386314 - Add default icons, enable snippets and bug fixes to Activity Stream.

https://reviewboard.mozilla.org/r/163728/#review169110

r=dmose

Comment 4

[Ed Lee :Mardak]

Also pushed here in case artifact goes wonky from the rebased-onto-autoland: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd2925124893e13b6adf042c830aaebfbadc14a8

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70cbfc193b9d
Add default icons, enable snippets and bug fixes to Activity Stream. r=dmose

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/70cbfc193b9d

Comment 7

[Ed Lee :Mardak]

Comment on attachment 8892741 [details]
Bug 1386314 - Add default icons, enable snippets and bug fixes to Activity Stream.

Approval Request Comment (part 5 of 6 Mardak will uplift)
[Feature/Bug causing the regression]: Activity Stream preffed off in 56 to be enabled in Shield study
[User impact if declined]: Users could see default sites with screenshots made with network connections instead of local high resolution icons
[Is this code covered by automated tests?]: Yes, Activity Stream has 100% line coverage
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: Bug 1385716 Bug 1386265 Bug 1386350 Bug 1385090 Bug 1386737
[Is the change risky?]: No
[Why is the change risky/not risky?]: The feature is preffed off
[String changes made/needed]: Localized strings were added

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8892741 [details]
Bug 1386314 - Add default icons, enable snippets and bug fixes to Activity Stream.

Icon fix for Activity stream testing in beta 56. Let's uplift it.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/37c48e24473b

Comment 10

[Andrei Vaida [:avaida]]

(In reply to Ed Lee :Mardak from comment #7)
> [Is this code covered by automated tests?]: Yes, Activity Stream has 100%
> line coverage
> [Has the fix been verified in Nightly?]: Yes
> [Needs manual test from QE? If yes, steps to reproduce]: No
> [List of other uplifts needed for the feature/fix]: Bug 1385716 Bug 1386265
> Bug 1386350 Bug 1385090 Bug 1386737
> [Is the change risky?]: No
> [Why is the change risky/not risky?]: The feature is preffed off
> [String changes made/needed]: Localized strings were added

Setting qe-verify- based on Ed Lee's assessment on manual testing needs and the fact that this fix has automated coverage.