1390448 - Tab strip on OSX has moved up by 1px

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Johann Hofmann [:johannh]]

This was caught by mozscreenshots:

https://screenshots.mattn.ca/comparisons/mozilla-central/824d4f269c6323e1ad2bd8ebeb6496d60b8ba3e5/mozilla-central/92f3de33d97f55d54b2baad585b87e76aaa5ec58/osx-10-10/controlCenter_04_noLWT_httpSubView.png

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1390448 - Restore vertical margin calculation in browser-tabsintitlebar.js, add 1px to window control margin on Windows 10.

Review commit: https://reviewboard.mozilla.org/r/168710/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168710/

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8897392 [details]
Bug 1390448 - Restore vertical margin calculation in browser-tabsintitlebar.js, add 1px to window control margin on Windows 10.

https://reviewboard.mozilla.org/r/168710/#review174452

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7d05f4db14d
Restore vertical margin calculation in browser-tabsintitlebar.js, add 1px to window control margin on Windows 10. r=dao

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f7d05f4db14d

Comment 5

[Dão Gottwald [:dao]]

I think we may need to revert this after bug 1390888.

Comment 6

[Johann Hofmann [:johannh]]

(In reply to Dão Gottwald [::dao] from comment #5)
> I think we may need to revert this after bug 1390888.

Yes, let's monitor that bug.

Here are the screenshots for this bug:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=833f84d0d5c729054a3aa8b3f34735f56fe6436b&newProject=mozilla-central&newRev=1d38626ba9686d119e489db538ce84f8f9854217

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

we have a perf improvement with this bug (which seems to fix bug 1390796):
== Change summary for alert #8829 (as of August 16 2017 13:48 UTC) ==

Improvements:

  3%  tresize windows7-32 opt e10s     12.00 -> 11.58

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=8829

Comment 8

[Johann Hofmann [:johannh]]

Quite interesting.

Comment 9

[Johann Hofmann [:johannh]]

Actually, looking at the results on central, I think this is exactly what we want. I'll check with shorlander once this hits Nightly.

Comment 10

[Johann Hofmann [:johannh]]

I think we can leave this as it is, bug 1391328 will remove the top border on OSX and that is how it's supposed to look then.

Comment 11

[ovidiu boca[:Ovidiu]]

I tested this on Mac OS X 10.10 with FF 57.0b9 and I can't reproduce this issue. I will mark as verified fixed.