1390741 - webrender: panels of remote webextensions are white

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Darkspirit]

Nightly 57 x64 20170815100349 @ Debian Testing with webrender+servo enabled

STR:
1. Install the latest "pure webext version" from https://addons.mozilla.org/de/firefox/addon/ublock-origin/versions/beta

2. set
gfx.webrender.enabled;true
extensions.webextensions.remote;true (default)
and click on Ublock Origin's icon: the bubble is white, but you can hover things

3. set extensions.webextensions.remote;false
Now we can see its contents.

Please correct the bug title if you have more appropriate words for it or mark this as duplicate. I haven't found a bug with this search terms and also nothing open that blocked webrender. I might have tomatoes on my eyes.

Comment 1

[Darkspirit]

(comment 0 = fresh profile on Windows 10)
I can't reproduce it in Nightly 57 x64 20170815100349 @ Debian Testing
and couldn't test it on a Mac of a friend yet.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

On my Mac I can see the contents of the popup with webrender + remote webextensions turned on. (Note that remote webextensions is off by default on OS X, it's only on by default on Windows). I can reproduce the behaviour on Windows though.

Comment 3

[Darkspirit]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #0)
> Nightly 57 x64 20170815100349 @ Debian Testing with webrender+servo enabled
I meant "Windows 10" there. I was tired, sorry.

Comment 6

[Sotaro Ikeda [:sotaro]]

This is a transparent window's problem. Gecko does not support accelerated composition with transparent windows. Non webrender case, it fallback to BasicCompositor. But in WebRender case, it fallback to BasicLayerManager, since WebRender does not support  software composition nor support of mixed usage of ClientLayerManager and WebRenderLayerManager.

Then if panels of remote webextensions is loaded in content process, its rendering is not connected to Compositor.

Comment 7

[Sotaro Ikeda [:sotaro]]

There seems to be 2 ways to solve the problem.
[1] Disable remote webextensions
[2] Add support of mixed usage of WebRender and BasicCompositor(only for transparent window).

[1] seems not ideal. [2] seems better solution, but it might becomes a bit complex.

Comment 8

[Darkspirit]

(This reminds me of bug 1377321.)

Comment 9

[Sotaro Ikeda [:sotaro]]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #8)
> (This reminds me of bug 1377321.)

Yes, it is also try to do similar thing. Bug 1333122 already did preparation work for [2].

Comment 10

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #9)
> (In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #8)
> > (This reminds me of bug 1377321.)
> 
> Bug 1333122 already did preparation work for [2].

But some implementation was removed by Bug 1351384. Current gecko controls and checks more about how LayerManager is created by puppet widget. Then we could try the way again, I think.

Comment 11

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use BasicCompositor if widget type does not support acceleration

Comment 12

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use BasicCompositor if widget type does not support acceleration

Comment 13

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f5692e836b24455a8f9f5aa16230f1c8eeaa2c0

Comment 14

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use BasicCompositor if widget type does not support acceleration

Comment 15

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8924494 [details] [diff] [review]
patch - Use BasicCompositor if widget type does not support acceleration

Review of attachment 8924494 [details] [diff] [review]:
-----------------------------------------------------------------

The patch looks ok to me. I'd like Andrew to also take a look since he also worked on some of these fallback codepaths.

Comment 16

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 8924494 [details] [diff] [review]
patch - Use BasicCompositor if widget type does not support acceleration

Review of attachment 8924494 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 17

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use BasicCompositor if widget type does not support acceleration

Comment 18

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=590a0a072de2895200b433ef08d73822e3961a0b

Comment 19

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use BasicCompositor if widget type does not support acceleration

Comment 20

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=98f8e8abd9824d875e955b5ed672088d11692f32

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2dbd4a1032d0
Use BasicCompositor if widget type does not support acceleration r=aosmond,kats

Comment 22

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2dbd4a1032d0

Comment 23

[Darkspirit]

Verified fixed in Nightly 58 x64 20171108110838 de_DE @ Windows 10 1709 (Radeon RX480). Thank you!
fresh profile: extensions.webextensions.remote (default), gfx.webrender.enabled

https://addons.mozilla.org/firefox/addon/ublock-origin/ works as intended.