1429235 - regression: oblique background on https://superhuman.com/ gets drawn on chrome

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Darkspirit]

Attachment: 2018-01-09_22-43-09.mp4

(OT: Yes, bug 1421747 is really fixed.)

Radeon RX480 @ Debian Testing

mozregression --good 2017-11-30 --bad 2018-01-09 --pref layers.acceleration.force-enabled:true gfx.webrender.enabled:true gfx.webrender.blob-images:true image.mem.shared:true layout.display-list.retain:false startup.homepage_welcome_url:"https://superhuman.com/"
> 14:09.57 INFO: Last good revision: c174ef283f5561aa3cf24b1d014b5f62dcd5ccd4
> 14:09.57 INFO: First bad revision: 8ccb0e9d9bbeeed7d7e4474849debd7d21b65971
> 14:09.57 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c174ef283f5561aa3cf24b1d014b5f62dcd5ccd4&tochange=8ccb0e9d9bbeeed7d7e4474849debd7d21b65971

> 8ccb0e9d9bbe	Ethan Lin — Bug 1426116 - Update the reftest annotations after we fixed the webrender box shadow problem (WR PR 2261). r=kats
> ca6f08cff784	Kartikaya Gupta — Bug 1426116 - Update reftest results from WR PR 2262. r=jrmuizel
> a7f7b7350673	Kartikaya Gupta — Bug 1426116 - Update reftest results for changes from WR PR 2200. r=jrmuizel
> 39f6c70f793e	Kartikaya Gupta — Bug 1426116 - Regenerate FFI header and remove RGB8 references to go with changes in WR PR 2260. r=jrmuizel
> e37afa9046ed	Kartikaya Gupta — Bug 1426116 - Update Cargo lockfiles and re-vendor rust dependencies. r=jrmuizel
> 7855af69185d	Kartikaya Gupta — Bug 1426116 - Update for changes in WR PR 2251. r=jrmuizel
> da9b75fc0866	Kartikaya Gupta — Bug 1426116 - Update webrender to commit a422f907be948b92bf5c7003a01f7744391a795e. r=jrmuizel

Comment 2

[Markus Stange [:mstange]]

There's a related testcase in attachment 8941421 [details].

Comment 3

[Kartikaya Gupta (email:[e-mail])]

WR regression range:

*   45dc6a3a Auto merge of #2244 - glennw:dual-source-blending, r=kvark
|\
| * 5f6b3868 Add dual-source blending path for subpixel text when supported.
* 97479a41 Auto merge of #2242 - glennw:gen-seg8, r=kvark
* 9423cf20 Address review comments
* 6ef9d025 Adding edge flags to unit tests
* 479e48f5 Fix borders with pre-built segments not checking clip mask kind.
* fdac2304 Extend segment building to handle clip in/out, multiple clip regions.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Filed servo/webrender#2283 for this.

Comment 5

[Darkspirit]

I maximize Nightly to see it faster.
bad = black on scrollbar, white on tab bar, on the left something is not cropped.
mozregression --find-fix --bad 2018-01-12 --good 2018-01-20 --pref gfx.webrender.all:true layout.display-list.retain:false startup.homepage_welcome_url:"https://superhuman.com/"
> 6:00.80 INFO: First good revision: b59b5e6e7070f3d47835ac5003e7a8c4c24d64e7
> 6:00.80 INFO: Last bad revision: 6bb6f3b25f9fe7ae1ef5092496776a891250cbb6
> 6:00.80 INFO: Pushlog:
> https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6bb6f3b25f9fe7ae1ef5092496776a891250cbb6&tochange=b59b5e6e7070f3d47835ac5003e7a8c4c24d64e7
> 
> 6:03.05 INFO: ************* Switching to autoland by process of elimination (no branch detected in commit message)
> 6:03.05 INFO: Getting autoland builds between 7b66479caadb664cee58e428d7a9972d8f592be4 and b59b5e6e7070f3d47835ac5003e7a8c4c24d64e7
> 6:03.52 ERROR: The url u'https://hg.mozilla.org/integration/autoland/json-pushes?fromchange=b59b5e6e7070f3d47835ac5003e7a8c4c24d64e7&tochange=7b66479caadb664cee58e428d7a9972d8f592be4' contains no pushlog. Maybe use another range ?

mozregression --repo autoland --launch 1a4f40cd0bea --pref gfx.webrender.all:true layout.display-list.retain:false startup.homepage_welcome_url:"https://superhuman.com/"
bad

mozregression --repo autoland --launch d1a22efb9e43 --pref gfx.webrender.all:true layout.display-list.retain:false startup.homepage_welcome_url:"https://superhuman.com/"
good
> d1a22efb9e43	Kartikaya Gupta — Bug 1430829 - Update webrender to commit e9269c7e06e20363be0b2a2a1be98d292ff7acca. r=jrmuizel

Linux x64 opt

> WR @ 9cad76acef7c1da00ba4beb1e01e764eee8fe4d5
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c4cea5ad05fb531fa50a113b5fbd86c26b8ef7a
bad

> WR @ 8811f69c4940b8d37b09aacf449f1b1932bf1e5e
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7839088a9fb83f04c92216088ee4ab71537b4dd
bad

> WR @ 2547f6fe91da018cd3374acd661effb5f8fbe022
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=8915a19fda816b4a7e040c30fda26241dd0f96eb
bad

> WR @ 46bd3a07cd002401005d8387f98fe187cc3b8cdf with bustage fix
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=375987120b09b3a5b7e4f42192237c9a0afcf13b
bad

> WR @ 46bd3a07cd002401005d8387f98fe187cc3b8cdf
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=d13fe8c4f00dbc5071624b7f035464162595371c
bad

> WR @ 5fae1ac37d9c9adf45601cfad83b31a3d6bafd68
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=dad0ba506f8aa8065af431056303d50c5b40ff61
bad

> Err the R4-opt unexpected pass only showed up at WR @ e9269c7e06e20363be0b2a2a1be98d292ff7acca:
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4e69355476318fbc918eb08a802e1d2cc27a7ed
good

Fix range:
https://github.com/servo/webrender/compare/5fae1ac37d9c9adf45601cfad83b31a3d6bafd68...e9269c7e06e20363be0b2a2a1be98d292ff7acca

which practically is
https://github.com/servo/webrender/pull/2324