143810 - Remove cookie options from Scripts & Windows prefs

Status: VERIFIED DUPLICATE of bug 223782

(SeaMonkey :: Preferences, defect)

Description

[Jesse Ruderman]

We should remove "Create or change cookies" and "Read cookies" from the Scripts
& Windows prefs panel.

We already have options for disabling cookies and for disabling scripts, and
there isn't anything special or evil about the combination of cookies and
scripts.  Also, unlike most of the options in the Scripts & Windows panel, the
script-cookie prefs only make sense to someone very familiar with the Web.

Comment 1

[Matthew T (active 1999-2002)]

Fair enough. -->Doron.

Comment 2

[Doron Rosenberg (IBM)]

hmm, what if you want js to not set cookies, but allow servers to do so?

Comment 3

[Jeremy M. Dolan]

Doron: you can always manually set the pref. This just removes the UI.

Personally I do want just that. Generally, sites that use JS to set cookies are
hacked together by kids, where I don't need to allow cookies anyway.
Professional sites where cookies are required (and where I actually am using the
cookie for a purpose, ie, bugzilla login) use HTTP headers.

As long as cookie manager blocking and 'ask me' affects JS-set cookies too, we
probably shouldn't expose JS cookie prefs to mortal users.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

I don't quite get why we need that pref at all, isn't the cookie manager enough?

Comment 5

[Cees T.]

If this pref UI is removed, won't it be impossible for the average user to
easily block cookie scripts in HTML E-mail without denying themselves access to
the website itself?

Comment 6

[Jesse Ruderman]

CT: if scripts in mail can set or read cookies, that's a bug and keeping this 
pref is a really bad way to work around it.

Comment 7

[Jesse Ruderman]

See also bug 172097, "Site falsely claims cookies are disabled".  The reporter
marked it as WFM after realizing the problem was due to his script-cookie settings.

Comment 8

[Jesse Ruderman]

Increasing severity from enh to maj because bug 177426 (Yahoo Mail gets caught
in a reload loop when its scripts can't access cookies) has 15 dups.

Comment 9

[Doron Rosenberg (IBM)]

-> 1.4a

Comment 10

[sairuh (rarely reading bugmail)]

fwiw, phoenix has removed these options from its analogous JavaScript pref panel.

Comment 11

[Susie Wyshak]

*** Bug 177426 has been marked as a duplicate of this bug. ***

Comment 12

[Daniel Veditz [:dveditz] out until Nov 10]

nominating nsbeta1 -- too easy to get into unexplainable trouble using these
settings, even if you think you're smart enough to mess with the Advanced panel.
It makes little sense to allow cookies and allow scripts, but not allow scripts
to do cookies.

Comment 13

[Doron Rosenberg (IBM)]

Attachment: remove the code

trivial patch - remove the code

Comment 14

[Josh Birnbaum]

*** Bug 191760 has been marked as a duplicate of this bug. ***

Comment 15

[Josh Birnbaum]

*** Bug 183242 has been marked as a duplicate of this bug. ***

Comment 16

[Josh Birnbaum]

*** Bug 193210 has been marked as a duplicate of this bug. ***

Comment 17

[Josh Birnbaum]

*** Bug 193207 has been marked as a duplicate of this bug. ***

Comment 18

[Stephen Walker]

doron, can you get r=/sr= for this patch? samir/dveditz might be some quick
available choices.

Comment 19

[Daniel Veditz [:dveditz] out until Nov 10]

I don't think you need to remove the underlying pref implementation, See comment
3 saying this bug is just about the UI for the prefs.

Comment 20

[Daniel Wang]

*** Bug 194936 has been marked as a duplicate of this bug. ***

Comment 21

[Doron Rosenberg (IBM)]

Attachment: patch, only ui removal

OK, this one removes only the UI

Comment 22

[Chris Lyon]

*** Bug 191652 has been marked as a duplicate of this bug. ***

Comment 23

[Chris Lyon]

*** Bug 197377 has been marked as a duplicate of this bug. ***

Comment 24

[Olivier Cahagne]

*** Bug 197454 has been marked as a duplicate of this bug. ***

Comment 25

[Rafael Ebron (:rebron)]

adt: nsbeta1-

Comment 26

[Jesse Ruderman]

Bug 223782 has an up-to-date patch.

*** This bug has been marked as a duplicate of 223782 ***

Comment 27

[Daniel Wang]

v