1438542 - logStringMessage() does not work after the Browser Console is opened

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

This used to work with the old frontend:

```
hud = await HUDService.toggleBrowserConsole();
Services.console.logStringMessage("test2");
await waitFor(() => findMessage(hud, "test2"));
```

It times out waiting for "test 2", which isn't actually displayed in the Browser Console.

Logging the message and then opening the console works just fine:

```
Services.console.logStringMessage("test2");
hud = await HUDService.toggleBrowserConsole();
await waitFor(() => findMessage(hud, "test2"));
```

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: STR.diff

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

The string is logged to e.g. bash but is not logged in the browser console.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1438542 - Fix rendering of non-cached message issued from logStringMessage; .

We weren't doing the right transform for cached messages, and thus
we weren't creating the ConsoleMessage with the correct properties.
This is now fixed and a mocha test is added to make sure we don't
regress on this.

Review commit: https://reviewboard.mozilla.org/r/221374/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221374/

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8952143 [details]
Bug 1438542 - Fix rendering of non-cached message issued from logStringMessage; .

https://reviewboard.mozilla.org/r/221374/#review227220

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58cf8ba79e97
Fix rendering of non-cached message issued from logStringMessage; r=miker.

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/58cf8ba79e97