1440506 - Dropdowns probably should be preserved among reframe

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Xidorn Quan [:xidorn] UTC+10]

Attachment: testcase

Steps to reproduce:
1. open the testcase
2. click the combo box to open the dropdown
3. wait for several seconds

Expected result:
The dropdown never disappears automatically as far as you don't move the focus

Actual result:
It disappears when position value change.


(Chrome and Edge seem to give the expected result for this testcase.)

Comment 1

[Jet Villegas (inactive)]

[Triage 2018/03/23 - P3]

Comment 2

[Emilio Cobos Álvarez (:emilio)]

So this happens because this runnable:

  https://searchfox.org/mozilla-central/rev/49cc27555d5b7ed2eb06baf156693dd578daa06f/layout/forms/nsListControlFrame.cpp#159

Hides the popup unconditionally even if it was reframed, unlike nsHideViewer does, for example:

  https://searchfox.org/mozilla-central/rev/49cc27555d5b7ed2eb06baf156693dd578daa06f/layout/forms/nsListControlFrame.cpp#159

Content-select would also fix this of course.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

This is way more painful than what I thought, there's all sorts of state along nsComboboxControlFrame and nsListControlFrame that would really need to be moved to HTMLSelectElement...

I'll take it if I have the time, but not this week...

Comment 14

[Daniel Holbert [:dholbert]]

(ni=emilio to try out an idea he has here, applying a similar approach to our strategy for iframe-preservation here.)

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1440506 - Do not destroy dropdowns on reframe. r=dholbert

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ce3566b9e52
Do not destroy dropdowns on reframe. r=dholbert

Comment 17

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0ce3566b9e52