1442419 - Snap fails to open downloaded files

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Ken VanDine]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/65.0.3325.88 Chrome/65.0.3325.88 Safari/537.36

Steps to reproduce:

After downloading a file, opening it fails.  The snap attempts to exec that process registered to handle the type by default, which is not denied by apparmor.

Comment 1

[Ken VanDine]

Attachment: Bug 1442419 - Fix failure to open files after downloading with snap

This fix does several things:
 * Removes the mime cache generated by the desktop-gtk3 remote part
 * Installs a stub shared-mime-info database
 * Set default association for all types to use xdg-open

Note: There is still work[1] to be completed in snapd, adding OpenFile
support to xdg-open.  Landing this is harmless though, it will fail
silently just as it does today but will start working when the snapd
feature lands.

1. https://github.com/snapcore/snapd/pull/4766
opening requested files,

Review commit: https://reviewboard.mozilla.org/r/224480/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224480/

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8955319 [details]
Bug 1442419 - Fix failure to open files after downloading with snap

https://reviewboard.mozilla.org/r/224480/#review230646

Looks right to me. Thank you very much for the detailed explanations!

Comment 3

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8955319 [details]
Bug 1442419 - Fix failure to open files after downloading with snap

Approval Request Comment
[Feature/Bug causing the regression]: None
[User impact if declined]: Unable to ship the first Snap release. Snaps are a new package format powered by Canonical.
[Is this code covered by automated tests?]: N/A
[Has the fix been verified in Nightly?]: N/A. Releng crafts Snap on beta. Starting Firefox 59, Snap are also built on release.
[Needs manual test from QE? If yes, steps to reproduce]: No. This has been tested by Canonical's QA.
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: This is a Snap only fix for 59. It has no impact on the regular product.
[String changes made/needed]: None.

Comment 4

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8955319 [details]
Bug 1442419 - Fix failure to open files after downloading with snap

Should help with new snap builds. OK to uplift to m-r.

Comment 5

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Best to land this on trunk first though.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3800cbeee1e3
Fix failure to open files after downloading with snap r=jlorenzo

Comment 7

[Ryan VanderMeulen [:RyanVM]]

This needs a rebased patch for 59 (based on mozilla-release).

Comment 8

[Johan Lorenzo [:jlorenzo]]

I'll take care of the rebase once comment 6 reaches central.

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/3800cbeee1e3

Comment 10

[Johan Lorenzo [:jlorenzo]]

Landed on release: https://hg.mozilla.org/releases/mozilla-release/rev/92d434aa93f9950f5f1807e69c060fdac5944f8e

Comment 11

[Ken VanDine]

This needs a bit of a tweak, we can drop the mime handler override and ship a mimeapps.list for xdg-open in the snap.

Comment 12

[Ken VanDine]

Attachment: 1442419.patch

Bug 1442419 - Fixed typo in the mimeapps.list bundled in the snap

Comment 13

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8957138 [details] [diff] [review]
1442419.patch

Review of attachment 8957138 [details] [diff] [review]:
-----------------------------------------------------------------

Okay to use .desktop instead of .html

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d6891646adb
Fixed typo in the mimeapps.list bundled in the snap r=jlorenzo

Comment 15

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8957138 [details] [diff] [review]
1442419.patch

See comment 3.

Comment 16

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/5d6891646adb

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8957138 [details] [diff] [review]
1442419.patch

Taking for 59rc3 since it doesn't affect anything we ship and doesn't require verification from our QE people.

Comment 18

[Johan Lorenzo [:jlorenzo]]

Attachment 8957138 [details] [diff] landed on release at https://hg.mozilla.org/releases/mozilla-release/rev/327bf5f74019e7b65b12ee0098e560eab30476d3