1463753 - DnD tabs broken on today's Nightly for Linux

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P1)

Description

[Andrew Halberstadt [:ahal]]

I ran mozregression and this is the culprit:
https://hg.mozilla.org/integration/autoland/rev/7e4166e13b3e

Which makes a lot of sense as I'm using Fedora 28 with Wayland.

I can pick up and drag a tab just fine, but the arrows to slot it in somewhere else never appear. If I drag horizontally along the tab bar, then the tab stays put instead of displacing its neighbouring tabs.

Comment 1

[Andrew Halberstadt [:ahal]]

I had surmised that starting my session with Gnome Xorg instead of the default Wayland would work, but it's broken there too.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

I'll look at it ASAP.

Comment 7

[imyxhuang]

It seems that drag-and-drop almost works when moving the cursor to the title bar on Wayland. Perhaps it's related to Firefox using XWayland and the title bar using native Wayland? GIF below if it's helpful.

https://postimg.cc/image/sle0eeyqf/

Comment 8

[Richard Marti (:Paenglab)]

I'm also unable to move buttons etc. in customize mode on TB Daily on Ubuntu 18.4.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1463753 - [DragAndDrop] Update mTarget(Wayland)DragContext unconditionally and check its validity after that,

Review commit: https://reviewboard.mozilla.org/r/246374/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246374/

Comment 11

[Jan Horak [:jhorak]]

Comment on attachment 8980227 [details]
Bug 1463753 - [DragAndDrop] Update mTarget(Wayland)DragContext unconditionally and check its validity after that,

https://reviewboard.mozilla.org/r/246374/#review252484

Comment 12

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8980227 [details]
Bug 1463753 - [DragAndDrop] Update mTarget(Wayland)DragContext unconditionally and check its validity after that,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246374/diff/1-2/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/172827af80fa
[DragAndDrop] Update mTarget(Wayland)DragContext unconditionally and check its validity after that, r=jhorak

Comment 14

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/172827af80fa