Open Bug 1475652 (mojave-sdk) Opened Last year Updated 11 days ago

[meta] Build Firefox with macOS 10.14 SDK (CI is currently using the 10.11 SDK)

Categories

(Core :: Widget: Cocoa, enhancement, P2)

enhancement

Tracking

()

People

(Reporter: ntim, Unassigned)

References

(Depends on 1 open bug, Blocks 3 open bugs)

Details

(Keywords: meta)

Apparently it gives some benefits in regards to dark mode integration, so it's probably worth doing.
Alias: mojave-sdk
Keywords: meta
Depends on: 1475653
(In reply to Tim Nguyen :ntim from comment #0)
> Apparently it gives some benefits in regards to dark mode integration, so
> it's probably worth doing.

What specific benefits are you referring to? Note that we're currently doing a lot of "non-standard" things, so building with the 10.14 SDK may not give us any benefits at all with respect to dark mode.

There are other bugs (such as bug 1470597) that may accelerate the timeline to build with the 10.14 SDK, but dark mode may not be it.
Blocks: mojave
Flags: needinfo?(ntim.bugs)
Depends on: 1475654
(In reply to Stephen A Pohl [:spohl] from comment #1)
> (In reply to Tim Nguyen :ntim from comment #0)
> > Apparently it gives some benefits in regards to dark mode integration, so
> > it's probably worth doing.
> 
> What specific benefits are you referring to? Note that we're currently doing
> a lot of "non-standard" things, so building with the 10.14 SDK may not give
> us any benefits at all with respect to dark mode.
> 
> There are other bugs (such as bug 1470597) that may accelerate the timeline
> to build with the 10.14 SDK, but dark mode may not be it.

Dialogs and different -moz-appearance values get the dark mode integration automatically.

It looks like the profile selector/crash reporter already benefit from dark mode integration (with the right native textures) in my local build. There may be more, but unfortunately my build crashes so I don't know.
Flags: needinfo?(ntim.bugs)
Blocks: 1475679
To build with MacOS 10.14 SDK:
- Download Xcode beta
- Add this to mozconfig:

ac_add_options --with-macos-sdk=/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk
No longer blocks: 1475679
Depends on: 1475679
Note that you'll need to work around bug 1475654 by commenting out: https://searchfox.org/mozilla-central/rev/46292b1212d2d61d7b5a7df184406774727085b8/widget/cocoa/nsChildView.mm#1564

In order for the build to actually run.

It has a couple of bugs with the dark mode, but it also fixes the appearance of the Crash reporter, the "Save As" dialog and the "Print" dialog.
Depends on: 1475694
Duplicate of this bug: 1391023
As far as I can tell the hardest part of this bug is to build on Linux.  We need some works in cctools.
I haven't looked into this lately, so bug 1391023 comment 2 is the last I knew of what we'd need to do that.
No longer depends on: 1475653
No longer blocks: 1479051
See Also: → 1480171
FWIW, building apple-libtapi with '/usr/bin/cc' and '/usr/bin/c++' causes some errors[1] like this;

 /builds/worker/workspace/apple-libtapi/src/apple-llvm/src/projects/libtapi/include/tapi/Core/Symbol.h:114:21: error: 'class std::map<tapi::internal::Arch, tapi::internal::AvailabilityInfo>' has no member named 'emplace'

I guess the compiler is older than expected one. 

Also, building the apple-libapi with clang (which is used for building cctools-port) causes other errors [2] like this;
 CMake Error at /usr/share/cmake-3.7/Modules/CMakeDetermineCCompiler.cmake:48 (message):
 Could not find compiler set in environment variable CC:

I have no idea what this error means.:/

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5f5b2af1046823d01423661345e3beb7499638c&selectedJob=196340566
[2] https://treeherder.mozilla.org/logviewer.html#?job_id=196303372&repo=try&lineNumber=183
No longer blocks: 1475462
Depends on: 1494022
No longer blocks: 1470597
No longer blocks: 1470607
Summary: Build Firefox with macOS 10.14 SDK → [meta] Build Firefox with macOS 10.14 SDK
Depends on: 1515374
No longer blocks: 1474447
Depends on: 1551223
Summary: [meta] Build Firefox with macOS 10.14 SDK → [meta] Build Firefox with macOS 10.14 SDK (CI is currently using the 10.11 SDK)
Priority: -- → P2
Depends on: 1578917
You need to log in before you can comment on or make changes to this bug.