Closed Bug 1482085 Opened Last year Closed Last year

TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/unifiedcomplete/test_PlacesSearchAutocompleteProvider.js

Categories

(Firefox :: New Tab Page, defect)

63 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox62 --- fixed
firefox63 --- fixed

People

(Reporter: jorgk, Assigned: jorgk)

References

Details

(Whiteboard: [fxsearch][Thunderbird-testfailure: X all])

Attachments

(1 file)

TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/unifiedcomplete/test_PlacesSearchAutocompleteProvider.js | xpcshell return code: 0

First seen: Wed, Aug 8, 09:49:28
M-C last good: d9e6ce390607ad8c227adc2ad2ff3cac89
M-C first bad: 17116905bc072c37d74226ccc46c93f0bd
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d9e6ce390607ad8c227adc2ad2ff3cac89&tochange=17116905bc072c37d74226ccc46c93f0bd

test_PlacesSearchAutocompleteProvider.js was last changed in bug 1480504 which landed in that range.

Sadly I didn't see the failure since we already have failures due to bug 1481420.

Running this locally I see:
INFO toolkit/components/places/tests/unifiedcomplete/test_PlacesSearchAutocompleteProvider.js | Starting ensure_search_engine
INFO (xpcshell/head.js) | test ensure_search_engine pending (2)
INFO (xpcshell/head.js) | test run_next_test 0 finished (2)
pid:1952 [1952, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004002: file c:/mozilla-source/comm-central/toolkit/components/resistfingerprinting/nsRFPService.cpp, line 682
pid:1952 JavaScript strict warning: file:///c:/mozilla-source/comm-central/obj-x86_64-pc-mingw32/dist/bin/components/nsSearchService.js, line 1870: ReferenceError: reference to undefined property "localName"
pid:1952 JavaScript strict warning: file:///c:/mozilla-source/comm-central/obj-x86_64-pc-mingw32/dist/bin/components/nsSearchService.js, line 1789: ReferenceError: reference to undefined property "localName"
INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "localName"" {file: "file:///c:/mozilla-source/comm-central/obj-x86_64-pc-mingw32/dist/bin/components/nsSearchService.js" line: 1870}]"
INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "localName"" {file: "file:///c:/mozilla-source/comm-central/obj-x86_64-pc-mingw32/dist/bin/components/nsSearchService.js" line: 1789}]"
pid:1952 JavaScript strict warning: file:///c:/mozilla-source/comm-central/obj-x86_64-pc-mingw32/dist/bin/components/nsSearchService.js, line 694: ReferenceError: reference to undefined property "name"

Mike, what do we need to do here?
Flags: needinfo?(mozilla)
Also:
ERROR Unexpected exception TypeError: match is undefined at c:/mozilla-source/comm-central/obj-x86_64-pc-mingw32/_tests/xpcshell/toolkit/components/places/tests/unifiedcomplete/test_PlacesSearchAutocompleteProvider.js:119
I'm going to build Thunderbird locally and figure this out. I saw this failure elsewhere and couldn't figure out why. If you see this consistently, it will help me debug.

I'll push on bug 1481420.
Flags: needinfo?(mozilla)
Thanks Mike. Yes, the failure is always visible on our tree on all platforms and it fails locally (tried in Windows).
I'm going to be removing this test completely, so this should go away. I'll verify.
It appears that Services.appinfo.name is not defined for Thunderbird?

https://searchfox.org/mozilla-central/source/toolkit/components/search/nsSearchService.js#694

I'm still trying to figure out the localName strict error.
the localName is because there are text nodes. I'll open a bug for that.

The core problem here is the match undefined and as I said, I'm removing that test.
(In reply to Mike Kaply [:mkaply] from comment #5)
> It appears that Services.appinfo.name is not defined for Thunderbird?
It seems to be defined, we use it here:
https://dxr.mozilla.org/comm-central/search?q=appinfo.name&redirect=false
Typing |Services.appinfo.name;| into the browser console gives "Thunderbird".

I added |dump(Services.appinfo.name);| to an Xpcshell test and locally I see |xpcshell| being dumped out.
> I added |dump(Services.appinfo.name);| to an Xpcshell test and locally I see |xpcshell| being dumped out.

That's weird. I'll have to do some more research on this. I'm getting the same error on Firefox as well about Services.appinfo.name.
Bug 1482235 is for the name error.
Bug 1482230 is for the localName error.
Bug 1482125 will remove this test.
Thanks Mike, I'm a little confused now. So bug 1482125 (https://phabricator.services.mozilla.com/D3033) will remove the code you've just added: https://hg.mozilla.org/mozilla-central/rev/2ab02d99fe7e#l1.12
> So bug 1482125 (https://phabricator.services.mozilla.com/D3033) will remove the code you've just added: https://hg.mozilla.org/mozilla-central/rev/2ab02d99fe7e#l1.12

That was my original plan, but I think we're going to keep the test.

My recommendation is that you turn off this test for Thunderbird. 

Thunderbird would never use the functions in this file.
Attached patch 1482085.patchSplinter Review
Hmm, I'm still confused. This test has run in TB for ages and never caused a problem. I thought the other three bugs will fix the issue. But if you think we should switch it off, here's a patch.
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #8999012 - Flags: review?(mozilla)
Let me see if my new patch works (where I just have google and no amazon).
I'm not sure which "new patch" you're referring to. Perhaps bug 1482125. That sadly didn't fix it.

Running this locally still produced the localName error (see bug 1482230) and
ERROR Unexpected exception TypeError: match is undefined at c:/mozilla-source/comm-central/obj-x86_64-pc-mingw32/_tests/xpcshell/toolkit/components/places/tests/unifiedcomplete/test_PlacesSearchAutocompleteProvider.js:121

Should we go ahead and disable the test?
Whiteboard: [Thunderbird-testfailure: X all]
Flags: needinfo?(mozilla)
I think you should disable the test. It's not really valid for Thunderbird anyway. Sorry for the hassle.
Flags: needinfo?(mozilla)
OK, then please r+ the patch so I can get it landed.
Attachment #8999012 - Flags: review?(mozilla) → review+
Thanks. Moving this to Product Firefox so the sheriffs see it.
Component: General → Activity Streams: Newtab
Keywords: checkin-needed
Product: Thunderbird → Firefox
Version: 63 → 63 Branch
Not sure if thunderbird builds from mozilla-beta, but I suppose we can uplift the fix here to be safe ?
Blocks: 1482398
Yes, please. Same for bug 1482627.
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/68995614a1c3
Disable test_PlacesSearchAutocompleteProvider.js for Thunderbird. r=mkaply
Keywords: checkin-needed
Whiteboard: [Thunderbird-testfailure: X all] → [fxsearch][Thunderbird-testfailure: X all]
https://hg.mozilla.org/mozilla-central/rev/68995614a1c3
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.