Closed Bug 1482172 Opened 7 years ago Closed 1 year ago

Implement color customization for mail accounts

Categories

(Thunderbird :: Folder and Message Lists, enhancement, P1)

Desktop
All
enhancement

Tracking

(thunderbird_esr115 wontfix)

RESOLVED FIXED
128 Branch
Tracking Status
thunderbird_esr115 --- wontfix

People

(Reporter: elluki59, Assigned: aleca)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [addon: Account Colors])

Attachments

(1 file)

Hi, Since the thunderbird 60 the great addon "account colors" does not work. The good thing on thunderbird is, that I can use a different accounts in the inbox. But without account colors it is not good to see for wich account I received mails. With account Colors I see it quick and clear. My Suggestion, why not implent as default account Color possibility in Thunderbird. Because I think this is a problem that have a lot of users. It would be nice, when you will think about it. Thanks for this good work, greetings Looks
Severity: normal → enhancement
Component: Untriaged → Folder and Message Lists

I'd like to second this. In fact, I'm really confused and frustrated as why it's not been a standard feature for years.

For some of us who use TB heavily, it is really important not to confuse different accounts and doing so can be really professionally embarrassing. The whole point of a good mail client should be for it to do everything in its power not to allow the user to confuse accounts. If it treats every account as equal (which TB does, pretty much) then I might as well resort to just accessing all my mail accounts through a web-browser tab.

Fobbing the responsibility for this kind of function to add-on developers is an awful solution, because as shown by the recent v78, add-ons aren't always backwardly compatible and most developers don't have the resources to update stuff ad-infinitum (good will doesn't pay the bills!). Besides, and as I say above, the whole point of a mail client is to "manage multiple mail accounts", and not to demote the responsibility of that management to an afterthought.

Functionality should include:

  • assign a color to each account in the account's settings
  • use this color in the side-pane and mail list (as "account colors" add-on used to do)
  • use this color as a background in the from/to/cc/bcc when composing mails (as "account colors" used to do)
  • allow you to change the "from" box in every composition window (and change field colors when the "from" box changes, as "account colors" used to do)
  • put a sub-menu under each "send/reply/forward" button to allow you to decide which account you want to send from (as "Identity Chooser" does)
  • on each account, include the option of enabling/disabling an "are you sure you want to send with this account" popup
  • in the navigator pane (left side of the main TB screen) allow me to change the order of mail-accounts so that I can put my more important ones on top (without having to resort to hacking the config-editor)
  • bonus features (though I realize this requires quite a lot of complexity) add intelligent warnings such as:
    • "Are you sure you want to send a mail to John Doe from account A, because you normally send from account B"
    • "This mail is being sent to persons at '@companyA.com' as well as '@companyB.com'. Are you really sure you want to do this?"

In my opinion this is just standard functionality as to what a multi-account e-mail client should do. Otherwise it's just a web browser with a tweaked front-end

I just came in to support the comments by Looks and osian78.

"In my opinion this is just standard functionality as to what a multi-account e-mail client should do."
Exactly! This should be a must. Every new-launched app enables coloring of accounts, though it is a "pro" feature sometimes.

Please, read the reviews here, addressing the developer of an addon used by 5.000 people (at minimum).
https://addons.thunderbird.net/en-US/thunderbird/addon/account-colors/#reviews
User are even "offering money" for such addon... :)

Hope sometimes happens soon, I do not fancy using outdated software version, but I am forced to now - in my TB I have 15 different accounts.

I also liked the add-on, but deprecation of add-ons is not the primary responsibility of those who ship Thunderbird. Even if it was, it would seem there has been insufficient understanding of https://bugzilla.mozilla.org/page.cgi?id=etiquette.html. So we will take a break from bug comments.

Version 78 partly implements this, but there is more to do, sufficiently described in Comment 0 and 1.

Status: UNCONFIRMED → NEW
Ever confirmed: true
Restrict Comments: true

(In reply to Wayne Mery (:wsmwk) from comment #9)

Version 78 partly implements this ...

... as noted in https://blog.thunderbird.net/2020/07/whats-new-in-thunderbird-78/ and https://support.mozilla.org/en-US/kb/new-thunderbird-78

Severity: normal → S3

I recently had discussion with the author of https://addons.thunderbird.net/en-US/thunderbird/addon/account-colors/ for another user. The author indicates they will not be supporting their add-on in the future. So someone will need to adopt the add-on or it gets adopted into Thunderbird core.

See Also: → 1674996, 355520, 1668203
Summary: account colors → account and message list colors

We will try to get this in for next ESR.

Priority: -- → P1
Hardware: All → Desktop
Summary: account and message list colors → Implement color customization for mail accounts
Assignee: nobody → arschmitz

Plans for this feature:

  • Add input color in the account settings page.
  • Store the color in the account properties so we can reuse it across the application (not just as folder property).
  • Apply the color to the server icon in the folder pane.
  • Set the default color for existing profiles to the TB primary blue.

Follow ups (in this bug or others):

  • Show colored indicator in the list of identities in the compose window, bug 355520.
  • Show colored indicator in the message list, bug 1882368.
  • Create an array of colors to choose from so new accounts can each get a unique color.
Assignee: arschmitz → alessandro
Status: NEW → ASSIGNED
Blocks: 1882368

Add input color in the account settings page.

There is an existing implementation that adds it here and further down.

Store the color in the account properties so we can reuse it across the application.

This implementation stores the color against the incoming server.

The patch should apply to Daily.

Thanks Jorg, but I'm not looking at Betterbird code for this implementation and I already have some WIP patches I did almost a year ago but never completed.
I just need to implement test to complete these.

Good find!

Blocks: 355520
Whiteboard: [addon: Account Colors]
Attachment #9404042 - Attachment description: WIP: Bug 1482172 - Implement color customization for email accounts. → WIP: Bug 1482172 - Implement color customization for email accounts. #thunderbird-reviewers
Attachment #9404042 - Attachment description: WIP: Bug 1482172 - Implement color customization for email accounts. #thunderbird-reviewers → WIP: Bug 1482172 - Implement color customization for accounts. #thunderbird-reviewers
Attachment #9404042 - Attachment description: WIP: Bug 1482172 - Implement color customization for accounts. #thunderbird-reviewers → Bug 1482172 - Implement color customization for accounts. r=#thunderbird-reviewers
Blocks: 1901154
Target Milestone: --- → 128 Branch

Pushed by alessandro@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/61da4e8d6e25
Implement color customization for accounts. r=mkmelin,vineet

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Restrict Comments: false
Blocks: 1901333

(In reply to Alessandro Castellani [:aleca] from comment #13)

Plans for this feature:

  • Store the color in the account properties so we can reuse it across the application (not just as folder property).

This hasn't been implemented, has it? The colour is stored using FolderTreeProperties which may not be the best place given further use in bug 355520 and bug 1882368. Storing it as an account preference mail.server.serverNN.color would have been more universal.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: