1496697 - (phab-sync-stuck) Phabricator revisions are remaining as secure, not being linked to bugzilla

Status: RESOLVED FIXED

(Conduit :: General, defect, P2)

Description

[Mark Banner (:standard8)]

Phabricator revisions since https://phabricator.services.mozilla.com/D7840 are remaining as secure and not being linked to bugzilla:

From https://phabricator.services.mozilla.com/D7857 (which I can see):

This is a secure revision.
Please use the CC list of the associated bug in Bugzilla to manage access and subscribership of this revision. Changes made here may be overwritten.
Please do not land this revision using `arc land` to prevent data leakage.

This draft revision will be sent for review once this build passes: Build 18346: Wait Until Bugzilla Updates Revision.

Other example issues:

https://phabricator.services.mozilla.com/D7856
https://phabricator.services.mozilla.com/D7859

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

To make progress on my patches I changed the following:

Visible To: Public
Editable By: bmo-editbugs-team
Tags:

Now reviewers can review, and I can land the patch. But it still doesn't seem to appear in Bugzilla. See https://phabricator.services.mozilla.com/D7859

Comment 2

[David Lawrence [:dkl]]

Revisions updates are flowing again. The daemon process crashed around 11:34PM EST last night and a restart fixed the issue. Working with ops to see what may have caused the crash. Thanks for the report.

Comment 3

[Dão Gottwald [:dao]]

Looks like this is happening again.

Comment 4

[:glob ✱]

(In reply to Dão Gottwald [::dao] from comment #3)
> Looks like this is happening again.

everything appears to be working; no errors were triggered around the time of your comment, and i see the process successfully updating new revisions.

Comment 5

[Dão Gottwald [:dao]]

(In reply to Byron Jones ‹:glob› 🎈 from comment #4)
> (In reply to Dão Gottwald [::dao] from comment #3)
> > Looks like this is happening again.
> 
> everything appears to be working; no errors were triggered around the time
> of your comment, and i see the process successfully updating new revisions.

Yeah, my bug got updated eventually, but it took a while and I saw the same weird security classification in phabricator until the request appeared in bugzilla, although I'm now guessing that's somehow normal and expected.

Comment 6

[:glob ✱]

(In reply to Dão Gottwald [::dao] from comment #5)
> Yeah, my bug got updated eventually, but it took a while and I saw the same
> weird security classification in phabricator until the request appeared in
> bugzilla, although I'm now guessing that's somehow normal and expected.

yes; that transitional state is expected - from https://wiki.mozilla.org/Phabricator/FAQ#Can_I_use_Phabricator_for_patches_to_security_bugs.3F

> Note there may be a short delay after submission before the revision is visible to other users.
> 
> Reviews are connected with the BMO security groups. All revisions on Phabricator are initially
> non-public; when Bugzilla sees a new revision it checks the visibility of the bug and will
> update the revision to match: revisions referencing public bugs will be made public, and
> non-public bugs result in the BMO security group and CC list being mapped to the revision's
> policies. These are kept in sync as the bug changes.

this delay should be short however these updates need to be processed in strict FIFO order times of high activity may cause a backlog.  if you provide a bug or revision id i can look at the logs to get the timings.

Comment 7

[Dão Gottwald [:dao]]

(In reply to Byron Jones ‹:glob› 🎈 from comment #6)
> this delay should be short however these updates need to be processed in
> strict FIFO order times of high activity may cause a backlog.  if you
> provide a bug or revision id i can look at the logs to get the timings.

This was in bug 1497464.

Comment 8

[:glob ✱]

(In reply to Dão Gottwald [::dao] from comment #7)
> (In reply to Byron Jones ‹:glob› 🎈 from comment #6)
> > this delay should be short however these updates need to be processed in
> > strict FIFO order times of high activity may cause a backlog.  if you
> > provide a bug or revision id i can look at the logs to get the timings.
> 
> This was in bug 1497464.

there was 14 seconds between the revision creation (17:54:12) and phab-bot updating it to be public (17:54:26).

Comment 9

[Dão Gottwald [:dao]]

That seems strange, as it means I would have needed to load the bug, see that the attachment isn't there, find the phabricator link and open it to see the weird security status all within 14 seconds. It's possible though.

Comment 10

[Mark Côté [:mcote]]

Happened again this morning.

Comment 11

[Mark Côté [:mcote]]

bobm restarted the container and things started flowing again.

Comment 13

[:glob ✱]

the changes have improved the recoverability here.

dropping priority, but leaving open as there's still some work required here.

Comment 14

[Dão Gottwald [:dao]]

Happening again: https://phabricator.services.mozilla.com/D18676

Comment 15

[:glob ✱]

(In reply to Dão Gottwald [::dao] from comment #14)

Happening again: https://phabricator.services.mozilla.com/D18676

i filed bug 1525273 for this one.

Comment 16

[:glob ✱]

this has been resolved.

please file new bugs should the issue reoccur.