1497077 - Convert links, image/iframe sources, form actions to absolute path

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, task)

Description

[Kohei Yoshino]

Before adopting pretty URLs like /bug/ID, /user/ID or whatever, the current links with a relative path like `query.cgi` have to be converted to an absolute path like `/query.cgi`.

Comment 1

[Kohei Yoshino]

But some installations are not on the root, e.g. https://www.w3.org/Bugs/Public/ so it has to be `[% urlbase FILTER html %]query.cgi` ideally excluding the origin part.

Comment 2

[Kohei Yoshino]

WIP: https://github.com/kyoshino/bmo/compare/bug-1497077-links-abs-path

Comment 3

[Kohei Yoshino]

Attachment: GitHub Pull Request

Comment 4

[Kohei Yoshino]

Merged to master.

Comment 5

[Kohei Yoshino]

Attachment: GitHub Pull Request follow-up

Comment 6

[Kohei Yoshino]

Attachment: GitHub Pull Request another follow-up

Comment 7

[Kohei Yoshino]

Follow-up PRs also merged to master. Let’s move on to Bug 1468848.

Comment 8

[Kohei Yoshino]

I have found that some redirects are relative URLs, not prefixed with `urlbase` (now those could be mostly replaced with `basepath`). It’s difficult to find all the relative stuff in the complex codebase, but I’ll try to scan further.

Comment 9

[Kohei Yoshino]

I’ll fix redirects in a separate bug.