Implement "WebDriver:NewWindow" command
Categories
(Remote Protocol :: Marionette, enhancement, P1)
Tracking
(firefox66 fixed)
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: ato, Assigned: whimboo)
References
(Blocks 5 open bugs)
Details
Attachments
(7 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Comment 3•6 years ago
|
||
Comment 4•6 years ago
|
||
Assignee | ||
Comment 5•6 years ago
|
||
Assignee | ||
Comment 6•6 years ago
|
||
Comment 7•6 years ago
|
||
Assignee | ||
Comment 9•6 years ago
|
||
Assignee | ||
Comment 10•6 years ago
|
||
Assignee | ||
Comment 11•6 years ago
|
||
Assignee | ||
Comment 12•6 years ago
|
||
Assignee | ||
Comment 13•6 years ago
|
||
Assignee | ||
Comment 14•6 years ago
|
||
Assignee | ||
Comment 15•6 years ago
|
||
Assignee | ||
Comment 16•6 years ago
|
||
Comment 17•6 years ago
|
||
Assignee | ||
Comment 18•6 years ago
|
||
Assignee | ||
Comment 19•6 years ago
|
||
Assignee | ||
Comment 20•6 years ago
|
||
Assignee | ||
Comment 21•6 years ago
|
||
Comment 22•6 years ago
|
||
Comment 23•6 years ago
|
||
Comment 24•6 years ago
|
||
Assignee | ||
Comment 25•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 26•6 years ago
|
||
Comment 27•6 years ago
|
||
Comment 28•6 years ago
|
||
bugherder |
Assignee | ||
Comment 29•6 years ago
|
||
Updated•6 years ago
|
Comment 30•6 years ago
|
||
Comment 31•6 years ago
|
||
Assignee | ||
Comment 32•6 years ago
|
||
Assignee | ||
Comment 33•6 years ago
|
||
Assignee | ||
Comment 34•6 years ago
|
||
Assignee | ||
Comment 35•6 years ago
|
||
Assignee | ||
Comment 36•6 years ago
|
||
Comment 37•6 years ago
|
||
Assignee | ||
Comment 38•6 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #36)
- Bug 1512342 - hang when opening a new window and not focusing it (details
see bug 1512342 comment 2)
Uh, I just noticed that we register the events for the newly opened window after calling focus()
on it. This perfectly would indicate a race condition as seen here.
I pushed a new try build with all the fixes included:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4dd2722de6563a97a019b32fa65db99238a8e419
Assignee | ||
Comment 39•6 years ago
|
||
(In reply to :Felipe Gomes (needinfo me!) from comment #37)
I think the question to answer is if the outerWindowId ever gets set, just
slowly (i.e., past 2s), or if that never happens.. Bumping the 2s timeout
to e.g. 30s would probably answer this easily. (Or, as it looks like you're
planning, changing to a normal promise which will "bump" it to infinity)
Ok, great. So we are on the right path. Thanks for your reply!
Assignee | ||
Comment 40•6 years ago
|
||
I missed to re-add the formerly removed import of waitForObserverTopic
to browser.js. Here a new try build:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f352d949c5430172ab1226ca5fe6b23796d5217
Assignee | ||
Comment 41•6 years ago
|
||
This try build looks pretty promising. I triggered some extra Mn jobs to verify that the low intermittent for the race condition is also no longer present.
Assignee | ||
Comment 42•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Comment 43•6 years ago
|
||
Fixing summary given that the new command has been named differently as the name we initially assumed.
Updated•6 years ago
|
Assignee | ||
Comment 44•6 years ago
|
||
It's all done now. And for safety I just pushed a final try build:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d193642cc5a96c1331c21feedf3c53f2cff6e80
Updated•6 years ago
|
Assignee | ||
Comment 45•6 years ago
|
||
We changed the spec to New Window.
Comment 46•6 years ago
|
||
Comment 47•6 years ago
|
||
Backed out 7 changesets (Bug 1504756) for xpcshell failures on test_sync.js.
Backout: https://hg.mozilla.org/integration/autoland/rev/4ff41b70cbd8e7d24242ee6839199875893b5cac
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=220898057&repo=autoland&lineNumber=2400
Assignee | ||
Comment 48•6 years ago
|
||
It's only happening on Windows and Linux but not MacOS, where I was testing locally. And I actually missed to also trigger xpcshell tests with my last try build :/.
Here the failure which is consistent across both platforms:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=220893546&repo=autoland&lineNumber=2507
TEST-UNEXPECTED-FAIL | testing/marionette/test/unit/test_sync.js | test_PollPromise_timeoutElapse - [test_PollPromise_timeoutElapse : 217] 11 <= 10
With a timeout of 100ms and an interval of 10ms I thought it would run 10 times at maximum. But that is actually not the case because we also run the callback already before setting up the timer to cover the case of a timeout of 0s. Why it only runs 10 times on MacOS might be related to some extra delays.
I will get this fixed by just bumping the maximum number of iterations to 11 so that the check reads:
lessOrEqual(nevals, 11);
Assignee | ||
Comment 49•6 years ago
|
||
Assignee | ||
Comment 50•6 years ago
|
||
This try build looks fine now for xpcshell. I'm going to push this patch series again now.
Comment 51•6 years ago
|
||
Comment 52•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1c023add0d15
https://hg.mozilla.org/mozilla-central/rev/70e87e4f91d0
https://hg.mozilla.org/mozilla-central/rev/4e0d85dd8ee0
https://hg.mozilla.org/mozilla-central/rev/ae09fe7cb735
https://hg.mozilla.org/mozilla-central/rev/bd95222980e2
https://hg.mozilla.org/mozilla-central/rev/8a0f8116e6bb
https://hg.mozilla.org/mozilla-central/rev/ecb0589b1079
Comment hidden (Intermittent Failures Robot) |
Updated•2 years ago
|
Description
•