1509711 - Firefox-window isn't draggable anymore on the menubar-toolbar since latest Nightly versions

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[macko]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

1) Use latest Nightly-build. (with a new profile)
2) Enable the menubar-toolbar.
3) Try to drag the firefox-window with the mouse on the menubar-toolbar.


Actual results:

You can't drag the firefox-window on the menubar-toolbar (no-drag area).
Only the tabbar/navigationtoolbar is draggable with the mouse.


Expected results:

The menubar-toolbar should be draggable with the mouse.

Additional information:
According to mozregression the problem was caused because of the introduced change of Bug 1507536.

Comment 1

[Itiel]

Also double-clicking there doesn't maximize/minimize the window.

Comment 4

[Asa Dotzler [:asa]]

mconley, can you look into this? seems to have been caused by your change.

Comment 7

[gixxpunk]

Can confirm the bug. See also here: http://forums.mozillazine.org/viewtopic.php?p=14816368#p14816368

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Thanks folks, bug is understood and assigned. I'll take it from here.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1509711 - Make toolbar-menubar flexed and draggable. r?dao

Originally, there was a spacer node after the menubar items that was
draggable, but this was removed to simplify the DOM. This restores the
ability to drag and change the sizemode of the window with double-clicks
when the menubar is enabled.

Comment 11

[Mike Conley (:mconley) (:⚙️)]

I think this is much more painful for our users than bug 1507536. What I suggest we do is:

1. Back out the fix for bug 1507536 to close out this bug
2. Keep the spacer after the menubar items, but put skipintoolbarset="true" on it to avoid the redundant context menu items.

Does that sound acceptable, dao?

Comment 12

[Mike Conley (:mconley) (:⚙️)]

In the interest of getting this into tomorrow's Nightly, I'm going to go ahead with this plan.

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Fixed now that bug 1507536 has been backed out of central.

Comment 14

[Md. Majedul islam]

I have reproduced this bug with Nightly 65.0a1(2018-11-25) on Windows 10, 64 bit!

The Bug's fix is now verified on Latest Beta 65.0b6

Build ID 	20181220174318
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Comment 15

[Catalin Sasca, Desktop QA [:csasca]]

I successfully reproduced the issue on Firefox Nightly 65.0a1 under Windows 10 (x64) using the STR from Comment 0.

The issue is no longer reproducible on Firefox Beta 65.0b8 and latest Nightly 66.0a1 (2019-01-06) under Windows 10 (x64).

Thanks to Md. Majedul for verifying it too.