1518587 - Break out the profile selection logic from nsAppRunner.cpp

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, enhancement)

Description

[Dave Townsend [:mossop]]

Moves the startup profile selection code from nsAppRunner.cpp to the profile manager.

Comment 1

[Dave Townsend [:mossop]]

Attachment: Bug 1518587: Move startup profile selection to nsToolkitProfileService. r=froydnj

Currently nsAppRunner is responsible for choosing or creating a profile to use
at startup. It then has to create a reset profile if necessary and lock the
selected profile directories. But these latter things are done in different
places of the selection code and done in different ways, sometimes we delay
while trying to get the lock, sometimes we don't.

This patch moves the profile selection part of the code to its own function so
that then we only have to have one place that does the profile reset and
locking logic.

It makes a lot of sense to have the selection code live in the profile service.
It can use information from the database load to help make the choices and it
also means that we can expose the profile selection code through xpcom allowing
it to be easily automatically tested. It will also be more important for future
patches for the dedicated profiles feature.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/394b490d3e2d
Move startup profile selection to nsToolkitProfileService. r=froydnj

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/394b490d3e2d

Comment 4

[Petru-Mugurel Lingurar [:petru]]

When building Firefox for Android I get

50:51.76 In file included from .../mozilla-unified/obj-i686-linux-android/toolkit/xre/Unified_cpp_toolkit_xre0.cpp:119:
50:51.76 .../mozilla-unified/toolkit/xre/nsXREDirProvider.cpp:22:10: fatal error: 'commonupdatedir.h' file not found

Dave, can you take a look?

Comment 5

[xftroxgpx]

for x86_64 also: https://bugzilla.mozilla.org/show_bug.cgi?id=1520131

Comment 6

[Cosmin Sabou [:CosminS]]

Created Bug 1520139 for these failures, please follow the progress over there. Thank you.

Comment 7

[Jan Alexander Steffens [:heftig]]

There's also bug 1520131.